Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Feedback-ID: i84614614:Fastmail
References: <20230926040939.516161-1-shr@devkernel.io>
 <20230926040939.516161-2-shr@devkernel.io>
 <ae2be79c-a030-a4d2-0d89-15efa17fe77c@redhat.com>
 <qvqwmsx83o68.fsf@devbig1114.prn1.facebook.com>
 <20230926140955.8b2627711116339af80731f2@linux-foundation.org>
User-agent: mu4e 1.10.1; emacs 28.2.50
From:   Stefan Roesch <shr@devkernel.io>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     David Hildenbrand <david@redhat.com>, kernel-team@fb.com,
        hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCH v3 1/4] mm/ksm: add "smart" page scanning mode
Date:   Tue, 26 Sep 2023 17:39:09 -0700
In-reply-to: <20230926140955.8b2627711116339af80731f2@linux-foundation.org>
Message-ID: <qvqw5y3w30w4.fsf@devbig1114.prn1.facebook.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Andrew Morton <akpm@linux-foundation.org> writes:

> On Tue, 26 Sep 2023 09:13:31 -0700 Stefan Roesch <shr@devkernel.io> wrote:
>
>> > Thinking about it, what are the cons of just enabling this always and not
>> > exposing new toggles? Alternatively, we could make this a compile-time option.
>> >
>> > In general, LGTM, just curious if we really have to make this configurable.
>> >
>>
>> The only downside I can see is that it might take a longer time for some
>> pages to be de-duplicated (a new candidate page is added, but its
>> duplicate is skipped in this round). So it will take longer to
>> de-duplicate this page.
>>
>> I tested with more than one workload, but it might be useful to get some
>> data with additional workloads. I was thinking of enabling it after one or
>> two releases.
>
> We could keep the tunable and make it default "on"?

Sounds good to me