Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <d4823817e907527119f7bb7fb7a4f77e8ce4dcc5.camel@linux.intel.com>
Subject: Re: [PATCH 01/11] platform/x86/intel/vsec: Add intel_vsec_register
From:   "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To:     Ilpo =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        platform-driver-x86@vger.kernel.org, rajvi.jingar@linux.intel.com
Date:   Tue, 26 Sep 2023 16:51:14 -0700
In-Reply-To: <1ed7ddc8-18a-cfbc-a4cd-baaa5751493e@linux.intel.com>
References: <20230922213032.1770590-1-david.e.box@linux.intel.com>
         <20230922213032.1770590-2-david.e.box@linux.intel.com>
         <1ed7ddc8-18a-cfbc-a4cd-baaa5751493e@linux.intel.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Precedence: bulk

Hi Ilpo,

Thanks for reviewing.

On Tue, 2023-09-26 at 17:17 +0300, Ilpo J=C3=A4rvinen wrote:
> On Fri, 22 Sep 2023, David E. Box wrote:
>=20
> > From: Gayatri Kammela <gayatri.kammela@linux.intel.com>
> >=20
> > Add and export intel_vsec_register() to allow the registration of Intel
> > extended capabilities from other drivers. Add check to look for memory
> > conflicts before registering a new capability.
> >=20

...

>=20
> Please split this patch properly. I see at least 3 components (some of=
=20
> which were not even mentioned in the changelog):
>=20
> - Moving enum, struct & defines (no functional changes intended patch)
> - Moving quirks to new place
> - The rest
>=20

Will split up the patch.