Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
Subject: RE: [PATCH v4 01/17] iommu: Add hwpt_type with user_data for
 domain_alloc_user op
Thread-Topic: [PATCH v4 01/17] iommu: Add hwpt_type with user_data for
 domain_alloc_user op
Thread-Index: AQHZ7GCQqMA2D6hFIkG8of68DC8uNLAss+nA
Date:   Tue, 26 Sep 2023 06:56:33 +0000
Message-ID: <BN9PR11MB52767E1B944C0B2F0667D5DE8CC3A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-2-yi.l.liu@intel.com>
In-Reply-To: <20230921075138.124099-2-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/btOpIEAC8H+YL7YJdhNRHU/H0W+xOrv0ALBTg9LWVJPxs41gJWD0oqTxqSX?=
 =?us-ascii?Q?++V9QQNOb1p9VW1E/7tPnM1VcufQts6E1YgAt9bwNoSOTCStKpdgs6mENzF7?=
 =?us-ascii?Q?2VvfGovQKQg8Einei61JA5F6fZnkJUgzopOI2ltxeBGUqSOhFM3PSqvUdP9Q?=
 =?us-ascii?Q?1DShCA7iCohlhrH+WfGCBS2OYu+F9wg7t4ahzM71uVQKaqoHl4HrnlveuYuD?=
 =?us-ascii?Q?zYMwUt8Trzp+fOMjZpfWr1+AjqcNqB5umMbwFjfQBYIEEJHq5mo4FLMWBL9p?=
 =?us-ascii?Q?jm4qtHX3H0DvQWmMdADYIoWS0kyrdppXaD8RSsJ0eWxdnG1FLYjqFP248qyn?=
 =?us-ascii?Q?QxOKjIFDnqd1hSE2si5Fox3uWRaSPVtHK+rTbkF4mniL7etqj8rS4aADmlbR?=
 =?us-ascii?Q?tYr29T+1tbEUgtUHY90cJaKOqnY53Z0B/LMFybDVwJ3X0LwSA+pVG1K1WPNE?=
 =?us-ascii?Q?y51AAKjtm4J4Rwa+FnuBaUv8oTKKn9hBs3hA3DZcMRmWUgeXPP0Tp+Z2dJw2?=
 =?us-ascii?Q?/sEH7XYJZ650JLubCV08Iu1p/63lxVgx80dhuSycVj8qkU2/Mp4+nFmU3cCb?=
 =?us-ascii?Q?xQmuH5JZ6aO+Mw+pnV3bft3eCyWWZFg3hIHZ/VnFrX9Yyask67P/m9pl6uuo?=
 =?us-ascii?Q?9s2/rVLIT3s/T5vsYfJrulkwtGFBdJKgIXd9LWF8cqDgAMsi06QtjCzgQHEY?=
 =?us-ascii?Q?5RYhoNID9PzySCcyHYYFf8hqJmenTqE5m4X3SjkAOU9hi2w+0TYm1Wgp1G9E?=
 =?us-ascii?Q?Ed3fW8VF8wPCljNDqhzuNSKLR/YAIs/S4PXIqw6U+caBO8Zj5zd/spr6sC40?=
 =?us-ascii?Q?EFk4jxgiUkFLR+/3ut8kLmF7Jg1Zo7gXvI8T9azbDJ3KdCD1Th0fcNMKHsbk?=
 =?us-ascii?Q?GHuViH/SVA9nLC44bxxmjxxah9aTCA+/qdekFl4JPmcw5uBS/Z0uwAhzAExg?=
 =?us-ascii?Q?UShY34NZf+0Ed51yIlWxaJ3mRNNlc2WN26lzs8DPPhzkouGJIES292IdEku+?=
 =?us-ascii?Q?W96PpwQ+0iHsHifvOrEyHjffqMduLMUjSVkyQdMdS2SMM9nI63dtqsbWKPTE?=
 =?us-ascii?Q?WfeeuTmVZ0C3OlsC4fSmJ+HqrOFWMkMRGl5ykXmT9iBWPSGXyKu4sbaMBXJ3?=
 =?us-ascii?Q?BZ7/qr/2zX+L5/raT0Lqf8dVYs04kf+j2BtM8VfsHgYOfXP7QPy+S7DZTh9d?=
 =?us-ascii?Q?xJpcEkh52vMvl6mLuiXnYS8tTtXtnFvau4kjb6OhIBoDg+jXzXbsydD+fiyJ?=
 =?us-ascii?Q?VoT7annZoZrzKcU5GZ9Ze+3wHQK7PpJ2awZ2YrWNAinauFTYfI4VgdsvgRQU?=
 =?us-ascii?Q?ioK8xEmWUIqL9QwQuOEpMUf+muXym/swUg0DAO8PP5UkbtJUXwOMV5XNTUax?=
 =?us-ascii?Q?ubmy5Q7EJj9i+t6xecBgzv/DNx8SHwROh1ZU+owUy7bz8n/XXoBiX4Vev14I?=
 =?us-ascii?Q?H9r4t3pMuOMxnHlET8VunPkzsYgRaSy+2A5D8M9QLvO7d9v3avNyGrySaDMD?=
 =?us-ascii?Q?Q/GfIGiuKA0l0x/AhdGGmNwz2Y73ZwMDIo2DitF8NBGVNaITAXr7O43+0kSK?=
 =?us-ascii?Q?5ZGl0BjXZ3bhARLUoptw5SYoGlAQN4STx2ESENDW?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5258b38-807c-4558-1830-08dbbe5db882
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 06:56:33.9415
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7Ee+PROxNZbfAzt4gvFraSgiPbIWvxuNpM7inn7LVdV35MH8M3CT3eI9Js0H/psvaFmFqRIAGVQCzHeiexq05Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7727
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 25 Sep 2023 23:56:54 -0700 (PDT)

> From: Yi Liu <yi.l.liu@intel.com>
> Sent: Thursday, September 21, 2023 3:51 PM
> +
> +/**
> + * iommu_copy_user_data - Copy iommu driver specific user space data
> + * @dst_data: Pointer to an iommu driver specific user data that is defi=
ned
> in
> + *            include/uapi/linux/iommufd.h
> + * @src_data: Pointer to a struct iommu_user_data for user space data in=
fo
> + * @data_len: Length of current user data structure, i.e. sizeof(struct =
_dst)
> + * @min_len: Initial length of user data structure for backward compatib=
ility.
> + *           This should be offsetofend using the last member in the use=
r data
> + *           struct that was initially added to include/uapi/linux/iommu=
fd.h
> + */
> +static inline int iommu_copy_user_data(void *dst_data,
> +				       const struct iommu_user_data *src_data,
> +				       size_t data_len, size_t min_len)

iommu_copy_struct_from_user()?

btw given the confusion raised on how this would be used is it clearer
to move it to the patch together with the 1st user?