Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757214AbXKLTma (ORCPT ); Mon, 12 Nov 2007 14:42:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753406AbXKLTmW (ORCPT ); Mon, 12 Nov 2007 14:42:22 -0500 Received: from netrider.rowland.org ([192.131.102.5]:4464 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751029AbXKLTmV (ORCPT ); Mon, 12 Nov 2007 14:42:21 -0500 Date: Mon, 12 Nov 2007 14:42:19 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Tilman Schmidt cc: Greg Kroah-Hartman , Andrew Morton , , Subject: Re: [PATCH] USB: power-management.txt - disconnect clarification In-Reply-To: <20071112095535.B778111004B@xenon.ts.pxnet.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1721 Lines: 42 On Mon, 12 Nov 2007, Tilman Schmidt wrote: > From: Tilman Schmidt > > Add a paragraph to Documentation/usb/power-management.txt about the > interaction between suspend and disconnect. > > Signed-off-by: Tilman Schmidt > --- > > --- linux-2.6/Documentation/usb/power-management.txt 2007-10-14 00:41:08.000000000 +0200 > +++ linux-2.6.24-rc2-work/Documentation/usb/power-management.txt 2007-11-12 10:27:30.000000000 +0100 > @@ -278,6 +278,12 @@ > (although the interfaces will be in the same altsettings as > before the suspend). > > +If the device is disconnected or powered down while it is suspended, > +the disconnect method will be called instead of the resume or > +reset_resume method. This will also happen if the system is resumed > +from hibernation, as the device could have been disconnected without > +the system being able to detect it. > + I don't like the second sentence very much. How about something like this instead: +If the device is disconnected or powered down while it is suspended, +the disconnect method will be called instead of the resume or +reset_resume method. This is also quite likely to happen when +waking up from hibernation, as many systems do not maintain suspend +current to the USB host controllers during hibernation. (It's +possible to work around the hibernation-forces-disconnect problem by +using the USB-Persist facility, described in +Documentation/usb/persist.txt.) Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/