Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <75a47252-f304-5377-f4a3-87a07cf4e2c5@intel.com>
Date:   Tue, 26 Sep 2023 14:41:24 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v2 5/6] selftests/resctrl: Fix feature checks
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        <linux-kselftest@vger.kernel.org>,
        =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        <stable@vger.kernel.org>
References: <20230915154438.82931-1-ilpo.jarvinen@linux.intel.com>
 <20230915154438.82931-6-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230915154438.82931-6-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cm02aDZqOTdFQldNZW83UWhEL0oybTU5dGo5UTIzbnlLcTVDVnRGSk9mN2tn?=
 =?utf-8?B?SW1pVjh6R3p3UFBJYndYZU9XNmhmYlM2VURscUIzWXMwVC9kdC8zRWRCYUVv?=
 =?utf-8?B?RnkyMi9USFVtTnRoMFZPNE04R2pZNURiQVdFTy85Rm5WbVNCMkxhS1BucnhR?=
 =?utf-8?B?eUZPc0FsUUt0YTM1RDlxVnY2azFxbmVRZlJvYjZqeE9nSlRPMHhUQWRjY09U?=
 =?utf-8?B?azFTTXJpU0VIZkZCeUkyWkxSR3N0MDF0ZDB2QW9jREN3SG5iNUFjMlk3STU4?=
 =?utf-8?B?NmcxTmtYYTcwQWZHaEMrQ2txYzcrKzliZ2hGV05ibXl4RFdPMERvWG5jTzkw?=
 =?utf-8?B?RGdzdHlBNktrVnFRTHY5bmZKVW5YY2t0by9BNHFTQXNNeStIUHpuQlkzQnpC?=
 =?utf-8?B?eEtDYXJycnJzTTZSVllvaUlWTy94NXE2NkxiRDJxQm5KdExmaEF4alc4R2xa?=
 =?utf-8?B?K0toUmp5MTVUMFpHVXpFdkRXQ29YNnJYTXVJSHROQkdxaUxEVDdSc0dqZ01P?=
 =?utf-8?B?aXQ2MU9FcnltZGVuYnZHTXJacytlMUhqOGtaY3d2NVE3eFNrck5HR3Qzd2pl?=
 =?utf-8?B?eFRYR0R6SlNIZjdIYnBkQTIveWgrcHpJRHlXbjVXaGYzeVpyQzNVajlFajdo?=
 =?utf-8?B?ZkZab00yU1RlRjdWMmFhQStNVXVNZzV2R00waUNqSlBMajRvRTJqNWNZN2Nq?=
 =?utf-8?B?OXFDbnVFNXJiSVJuaTZDaUVhU2RVSWZ5bTdLM2E0ck9oeG9KV0cwUzE0Tmxa?=
 =?utf-8?B?bmFiMVN2Umc3QlByc08xZWNNUDYvVm44MlE3VEY3bjNYZkJ0T0NGdjVDMWJo?=
 =?utf-8?B?SndiU09hREJmaEQwZjBxQUNCM1ZTbVpsSkZVR0VBTUEyeTMxNUtHRkl6N05T?=
 =?utf-8?B?ckdiaXlSUjJKVm92QTUxZ0EvWjBwMGZoS2VSRCt5bERObGtIeHY5b0RZRkdl?=
 =?utf-8?B?VjBFeTlUc1VZcW1XcVJhdTRQcUtOcFhHL0plMWNpY09KZVp1cXc3SjA5SHd1?=
 =?utf-8?B?bjR2eUVFeHZNRzVOVzNJRDArNEIzWUJZM1dxaUl1ejMzZDN1NlVqY0ZXSzZ2?=
 =?utf-8?B?YUlJek9ESHRVbHFhK1c4cW1oaVJ0cVhlaUpDeTFBcGhaM1NhU0JFYnI2bVJm?=
 =?utf-8?B?YnF1ZWVTMDZDU2Z0a0ZxV1NhSFB6Y3h1UzYwZlZqSi85K2FWU1BTekRud01z?=
 =?utf-8?B?MmVqTlozMENXQmxzT0d2ZlFlWmN3b3E0TlRWdWREVTlSVFpPcWFhUDJpdFV5?=
 =?utf-8?B?Yk9lT2cxWjloYXd5SnM4L1dnUHZiK08vMHZGY3F5aUdqbXVodld2a1BUQmww?=
 =?utf-8?B?ck03ZU9BdFVpMGZURVZuYkFKTXRtVElVWEhwL2MzYWFaSENhYlgyZnFJNzRU?=
 =?utf-8?B?T3dBekFPVGpid0ZISVFFYjhKMnd3aTlXcFpYcWtyVW85eE9mUWpXMDRVWlAw?=
 =?utf-8?B?MVdVSXp5ZmpabUhlaExWYlpNbCtaZlJRZ3lTTEVSNFpsenMzTEx2em1XTElU?=
 =?utf-8?B?RWxHRm5NaHl1Qk45RTF4bXBBeXhidjZDaENFQ2c4cUdlbXBndUJUN2tnMVQ0?=
 =?utf-8?B?a2ZpaS9vWks3YldZOGY3aFhjY3k5Sy9aL2Y5M3pIT2tiQlVFblQ5TVV4b3FD?=
 =?utf-8?B?bDZnbHR1eVltaEFLK2tvdWx1cWE2cHBLZFh0OXNzQTFQSzRHMitwU096QlZR?=
 =?utf-8?B?WDgwZEJBODZVNk5Ya0M0cjVqYU1JTWlXL1JOdU5sME0vTXR3T2lLVk9uS0lk?=
 =?utf-8?B?Q0pqU28rSFUxNlNNQnNTbmdnWFRBYndrWDlJNWFOOXROV2VLSVh4a2x4QWlq?=
 =?utf-8?B?QjhiaVJWVTkzM2dhUkh4VEV4cjJhQldZMk51N2ZGNFA4V29CWUlBVUtvN1Rh?=
 =?utf-8?B?OTV4YWRTeGZYSnB6QzlLdFJNTHA1OFMzdldwSHV4aDRhRE1Fb1l0OVFFaUVm?=
 =?utf-8?B?c3NLRjNObXpSSElhZkhkclhzRkJ0OVVaZmgzUkVrZHQ3Q1JsKzgyUExzU1hF?=
 =?utf-8?B?V0hDczR5bDZiQ1FZQWFLcTRITFlva3M4T3hZM3kwd1NuM25yWlNoVkc2dmJp?=
 =?utf-8?B?elVSeWJnK0tBM0JudlhhaTEvazRSQ2gvSUhVTi9FSmNFUC94K0NDMHl1MHBB?=
 =?utf-8?B?dm1JZmlrdmk1dVJsN0dsU092V3lORHF5djhLTzF0WktCdURvUUZkY0RoQUlT?=
 =?utf-8?B?VlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f8707886-d6e0-41aa-257a-08dbbed95638
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 21:41:26.8120
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rDRWgy+2sTri4nhRE9kLjaI/DTVy1sZZCEHs5pUMIvAoNyXBKki+XkExkf0BKrNEAHLMEnujGW8N6/KR5PwH1JEchN9eccciQ2rJkvyDGm8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8424
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 26 Sep 2023 16:14:05 -0700 (PDT)

Hi Ilpo,

On 9/15/2023 8:44 AM, Ilpo Järvinen wrote:
> The MBA and CMT tests expect support of other features to be able to
> run.
> 
> When platform only supports MBA but not MBM, MBA test will fail with:
> Failed to open total bw file: No such file or directory
> 
> When platform only supports CMT but not CAT, CMT test will fail with:
> Failed to open bit mask file '/sys/fs/resctrl/info/L3/cbm_mask': No such file or directory
> 
> Extend feature checks to cover these two conditions.

It may be helpful to expand on this more to justify why this is
stable material. At this point it sounds as though (from user space
perspective) one error is replaced by another. Perhaps just a snippet
that states that this fix will cause the test to be skipped on these
platforms.

> 
> Fixes: ee0415681eb6 ("selftests/resctrl: Use resctrl/info for feature detection")
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Cc: <stable@vger.kernel.org> # selftests/resctrl: Refactor feature check to use resource and feature name

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette