Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: RE: [PATCH v5 06/11] iommu/vt-d: Set the nested domain to a device
Thread-Topic: [PATCH v5 06/11] iommu/vt-d: Set the nested domain to a device
Thread-Index: AQHZ7GDtob+tP6CFnEugYDjif1Do2rAuQeLQ
Date:   Wed, 27 Sep 2023 06:40:42 +0000
Message-ID: <BN9PR11MB527627C665FE2AC737AC09308CC2A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230921075431.125239-1-yi.l.liu@intel.com>
 <20230921075431.125239-7-yi.l.liu@intel.com>
In-Reply-To: <20230921075431.125239-7-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VEwzzNVAgmWVc6lDvGdHLe5A8sNAAKPO16OaOcBK9P8IBZs1oI/uOVuT4sL2?=
 =?us-ascii?Q?DF21hKFBVr+CfL231CVV8Y/aF6lbJYu2SmcWzr3MJADkacteyNAQFWI/vqLh?=
 =?us-ascii?Q?1N0hA1+XF00XjA51GbjTX2b7rbfKbx7xSv+LFZdCsgIiXeJ140IjvuGr1/1X?=
 =?us-ascii?Q?h0mzxiCAp0IuMzBqnk//kqRnNWvOuxqDekrX4Lauhnb2i1XffDM6Y4+0zvIC?=
 =?us-ascii?Q?34vUSlSwRh4ojwf6z8sYaKTNofpDczZzt9HjibYoT53+z8s/LFbRDPfPzP8V?=
 =?us-ascii?Q?POfzQKvaDlb7PkXa/KlowFreFGnYmEyVdMm7kkKk+4OLVgBh8bqAfUa4/utk?=
 =?us-ascii?Q?7Z7GZ4VlvpRU/4YzGtO8wJN6qeUm0G9KR3ntd4o60A+w7Shc5w2k6BjfLwrs?=
 =?us-ascii?Q?PZ9AY3GDEt5iSmIMqYiCzol+PQq388uIeXqV8+ePOerVMv/d+ZMc/WJa4WCV?=
 =?us-ascii?Q?9ri+lrzjZ9RAPosE6rbg7aXM73LjTrTHmg5vlOQ9cK2rOs+lBzr7B6xtWQPO?=
 =?us-ascii?Q?hy+BZeMqylBWm4FZLHwp2oilxXnsVVkFmsNSiSP554pvzfcEe7a1YGkrFxXd?=
 =?us-ascii?Q?hIx/C+sh6/RY51cJnlrtg+/clG8e7voeaWW0J3SrSK69n4jzR1mGZ7Fm1+dQ?=
 =?us-ascii?Q?T9YwvJL0M+/MAmPXT5yyFvGtz3q2XIPi8B1LdsN+ZN1GRGWng/wAOFrOAXAH?=
 =?us-ascii?Q?Q64p9DqBxiP/wrQEfedENBj8DFZj8Y+YC9t4io1ZH4yESB616LRMIXuqhnv3?=
 =?us-ascii?Q?gVXmPYv2FNhE8edJwzu3Rxmv9AsjZwEfHXdXqYie4UQiNTK6X8RI7PVL+CU6?=
 =?us-ascii?Q?JLNbfU1BB/mXbdnEFei/rfsbyUDqIjq/Bl6f9zKeBZgKgR2pbGBycfXuP35N?=
 =?us-ascii?Q?AMKcCRhE57v03VzxZzis/WqeXixIZNngpnIDE2dtfpUV62AL1F59aSb2RO8O?=
 =?us-ascii?Q?awL2wrFttaURRo87JrNU8sMbTE33YOLy76Ue68LlMg9bShg2VCScc1/RfRgP?=
 =?us-ascii?Q?Xjp+oFFBhToawx9a2MFe2FaNMvbn+dvrMOB6A9dt0y9tdexFESzfHa/Y+Hjx?=
 =?us-ascii?Q?eehV1L0ATEynD+mSC6Nk0xvPSJSE1Bv5oepf0UK2x9gP2iwvGlI24R9XZBJa?=
 =?us-ascii?Q?RRuu0w9DoIA/Bt2GXMQnY87P10YEbR2aeUSPeRCAjiD+eAOVIApSr4/JXy9X?=
 =?us-ascii?Q?lUi1UmQ92pxUD9CcZALk30timAWPPwkG33wgCztOmbiA/aS08bXBfIko38mn?=
 =?us-ascii?Q?vibTARqXf0GG7vsdf7ED0IE+fmlOhpijSCHRA9IC/bTyyub0FoEELF2yWWDZ?=
 =?us-ascii?Q?BY2YO+dJ6aH0FeVZ2K6C4ygGXNveplc2eVzSldIVjvzh3TRsYu9spM+gsZb/?=
 =?us-ascii?Q?OnunVXgLSFkY6Es6TpMEqrRXSELffpedndHpf+VBVhxXI6usKqLS1R6obD3Z?=
 =?us-ascii?Q?ifkS5Mjd98wpVWepN/Ezmfs/oZ+gXlCsa5BPH0AX+UUogvXA7awrQK/5sR8h?=
 =?us-ascii?Q?bCIqKoU/iVQW4wyVbM45PkInvb97bu2AHVmS0J3krjh3rSbcd+CLXXjCXcnt?=
 =?us-ascii?Q?NrCjhBlD/mP7Jz11eutKOmyJzvdJI4qdjrXnr6k7?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4caa48a7-89c4-4abd-3fcb-08dbbf24abad
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2023 06:40:42.3011
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: K99zx1yjDLAf4el2/IELFX6F2rZsz13m+Q6+Wb/bNkEaqyhp9HsuCHToEWGT8HwIhZLhApjEwSMLlNcLyh/CqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7976
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 26 Sep 2023 23:41:06 -0700 (PDT)

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, September 21, 2023 3:54 PM
>=20
> +
> +	/* Is s2_domain compatible with this IOMMU? */

Add more words on why prepare_attach uses s2_domain when the actual
attach is for s1

> +	ret =3D prepare_domain_attach_device(&dmar_domain->s2_domain-
> >domain, dev);
> +	if (ret) {
> +		dev_err_ratelimited(dev, "s2 domain is not compatible\n");
> +		return ret;
> +	}
> +
> +	ret =3D domain_attach_iommu(dmar_domain, iommu);
> +	if (ret) {
> +		dev_err_ratelimited(dev, "Failed to attach domain to
> iommu\n");
> +		return ret;
> +	}
> +