Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <595d6062-fece-83c0-5d5d-2f9405f6b842@intel.com>
Date:   Tue, 26 Sep 2023 16:06:18 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v5 3/8] x86/resctrl: Split the rdt_domain structure
Content-Language: en-US
To:     "Luck, Tony" <tony.luck@intel.com>
CC:     "Yu, Fenghua" <fenghua.yu@intel.com>,
        Peter Newman <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>,
        "x86@kernel.org" <x86@kernel.org>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
References: <20230722190740.326190-1-tony.luck@intel.com>
 <20230829234426.64421-1-tony.luck@intel.com>
 <20230829234426.64421-4-tony.luck@intel.com>
 <5f1256d3-737e-a447-abbe-f541767b2c8f@intel.com>
 <ZRMnCFWzcxa6Qa4E@agluck-desk3>
 <5b2fd31e-3cef-3c35-7d17-411cea27502a@intel.com>
 <SJ1PR11MB6083D9AA22033235210BD847FCC3A@SJ1PR11MB6083.namprd11.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <SJ1PR11MB6083D9AA22033235210BD847FCC3A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SldycEVFdUVSaG5laFo4MDN1TGJPTWlIaDBjb3R4VHJVQlRYSUVMdGUrRzl1?=
 =?utf-8?B?dXpDS2FqVHZ3NmdQU0txb3dmUTdrR2wwWlB2MmkwazhtaFkxdE5XWkZKMTlr?=
 =?utf-8?B?RTNDR1cwaW12bXZYUXgyZHV1NVlZV0RxZzN5VCtRZFh0Z1ZaSm9CRFJSd0U5?=
 =?utf-8?B?d2dKby90UTdJSXU3SjI5VjcyVzgzNjZ0QlJ3MVBCZ1pITE5nNjdDMkcrUGNK?=
 =?utf-8?B?WkZBMi9YWTFZbndiVWp3ZC9mWUVRdElWSERaZ1pnTEI2M0ROcnVzRmpldGw2?=
 =?utf-8?B?TEg4VEZEckoycEdkb28vNWZ1UmNFd0VJM1ZSb1I2S0FtTTB3TmZRWjVkM3JU?=
 =?utf-8?B?K2xaSWVGS3lGbjBRK1VJdDRmWFhEeGRQQnpvT2hLMEhZZm94bW80K0dhTjh1?=
 =?utf-8?B?Q1pzd1VrTHR3d1BMYUJxeVZ2MmZBYzdWNzNCNytsaWtnN0UzdFdOZWNGQ0FU?=
 =?utf-8?B?RjkyVEdCMEF1VEdiT3gvalBMMGZTakY1WmxpT28rMG1ySStyMnFJanQ4Qy9W?=
 =?utf-8?B?STUwOVVqY3lYbWFJdWIySHRhV0NWMHdyV3N5ZVFDdlJ1dStOUHJBcVc5ZGc2?=
 =?utf-8?B?MFd6eVdHcnpObzFYYko3WnlOdFVZWkxwaEk0VzdWdUQ2VXVudXdSWG5kKzZG?=
 =?utf-8?B?akQ4T1QyamF1aU5Sd1A2Z0JjcE5yWnhhUDI5NVpZbjM0dkIwZy8rdlJTdUYv?=
 =?utf-8?B?SnlEQ3BLeVJOcDg2Zy9lR0dwYWp2M1ZDeUY4YlZZTXE1Q09DQTQzRVdhWGI2?=
 =?utf-8?B?L04vbFVxUXIrV3FXN3FId09neGZvNXpVemN2T1o4TmxhcHorbWFOZkFYd1hD?=
 =?utf-8?B?akUxeUpQblUxcTJJOEcyOTZ6eHY2TDF1NThSZklTdDZJZitPVHordzZ5dWZs?=
 =?utf-8?B?VElYdVRpblN1akNkdkxpcEVsUi9OL0VVK2pPa3ZkYnI3T1lmMmRFZ1pvS3Uw?=
 =?utf-8?B?ekdoc1JGWG14ZkVXLzNKR2tIM3M1T0QxbksybFBQVzA2Rnk0Wk5wTERNbEtQ?=
 =?utf-8?B?TkpOQncvYkVPNjNuOVk0ckRwcGxSR28ybEhhN0xodEpsZjVSVU5DbHNCUGF2?=
 =?utf-8?B?dUJuMldLS0hzOWdaNzdlYXhDRmpyWWxqVjVzMnFlcWtjVysvVHFySXQxT0l0?=
 =?utf-8?B?NkdrRnV6QUZVS0R2bXBTV3R5cDNxNkE3anJjT016am1VRXpSWEMvQWNMUGZE?=
 =?utf-8?B?bnl5U0FGRmNPcHJpWURCbjVyMWpsQ3NHM1BCSzNGaEFmMXVQajlGQ0lQbzZT?=
 =?utf-8?B?QjdxeEl4TWNHZ1ljTzNyNFlWY0NqcmRGMXJFZEFvUkRQRTQ3dFZRY1BCeEpa?=
 =?utf-8?B?VlFwMmVKYlFuRiszejhPVGFOK0dxc2NVb1Vmb0pCN21wa3JTbzAvZGdGNXZj?=
 =?utf-8?B?U01vZURBUEZGcW1HR0k2dXh6bVNhZmdhWkpEcThMZGpQYXVkYmp5RWJBckx4?=
 =?utf-8?B?b3BwYno0aUJBY2lCUU84ajc2ZklmbTljQVdzdHlWZDVCMzYwZDZQN2lkL2NW?=
 =?utf-8?B?S29wNXFQdVlxL3MvZExDVDlNeEYwVUtyRmhmc2gzS21WTEJjUDF0TFZYZjZq?=
 =?utf-8?B?S1NueVNWS2xEaHZaMTU5SEc3SEpwZEJ5d3FMTzUzcjhWUEpFSU45ZFhzZGZ0?=
 =?utf-8?B?LzY1UXlsQjVtOUpCbnF4NXJWOFYzemIrSFY4NnZiMktadlpDbWt3SW1OdlR5?=
 =?utf-8?B?UXVHNTdXcnZkSHc5Ym5KbUw5MUxXTEVhT2lRUjhHVlZ6TzhtSDRsMGRIRUNF?=
 =?utf-8?B?MEVNdUw0MERpVW1rQkp2T2tNdFhDMFkyV2JieDJhSWVxSU5qZ3hoWjlVSFF5?=
 =?utf-8?B?RFhUUnJuNFFqRFVMWG50dUJNakdocnU1Q1FqNmlVZDZFakFlYjdVT0NkQzdy?=
 =?utf-8?B?a3Vsenp6SlkxQW9OWEluZXlSMlNQcVo3Y1dPTzVXVlVtSEp5RTRxZlRWSnR3?=
 =?utf-8?B?Kzg0R1pkWUVoVEFpdFljbWQ0ZzRMU2Fzd1NvMVA4cmdXRmFxS0pEbmtTQjRV?=
 =?utf-8?B?R1JPenRhZTdmRVVmOFRMTEp6WVBjRitpbXVPVEt5U3k0VkJoZSt4QmxGSmxm?=
 =?utf-8?B?V1F4TXd3NXZ1Uk40a3FjL2x5K1Eva3NIMHl3MC9Rd0NSZUhscXdtc04wbi9l?=
 =?utf-8?B?THBsYVZnN0xURmdNaGYvTytmcmlUYnhJVC9oZU1PMzFmeVdMNmlHcktFVVhj?=
 =?utf-8?B?YXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b7765f3-f0fa-416e-a0ce-08dbbee53322
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 23:06:22.4856
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kRaQxWa9b3bFFJ2DVBV/ZUjsqPaVuT/op7Cwkf5XhmCO8nnkQp+4M5XFWuQnhKTM2/J8Q3TZF7ke6pCDri2MbgilJJj++0gV9RRvp2Rnf7M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7639
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 26 Sep 2023 16:48:11 -0700 (PDT)

Hi Tony,

On 9/26/2023 3:14 PM, Luck, Tony wrote:
>>> But this seems like it is a lot of churn to avoid having separate
>>> functions to search control and monitor lists. Each a clone of
>>> the existing ~24 line rdt_find_domain() with just the type changed
>>> for the return value and the list travsersal.
>>
>> Yes. Sorry, I did not realize this implication during the earlier
>> discussions.
>>
>>>
>>> What do you think?
>>>
>>
>> It sounds to me as though you are advocating for open coding
>> rdt_find_ctrl_domain() and rdt_find_mon_domain()? That sounds good
>> to me.
> 
> Reinette,
> 
> While there is some churn, it maybe isn't all that bad.  I also ran the open
> coding case and having a pair of 24-line functions one after the other with
> just two trivial lines changed between them is unlikely to get past the x86
> maintainers without running this same conversation again.
> 

I expect you are right and your proposal makes the code cleaner.
Could the list_entry() call within rdt_find_domain() instead
extract a pointer to a struct rdt_domain_hdr? To me that would make
it most generic and avoid using wrong type for a pointer. I do think that
may have been what you intended by moving id in there though ...

Reinette