Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Wed, 27 Sep 2023 01:21:27 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Thomas Fossati <thomas.fossati@linaro.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <linux-coco@lists.linux.dev>,
        Dionna Amalie Glaze <dionnaglaze@google.com>,
        James Bottomley <James.Bottomley@hansenpartnership.com>,
        Peter Gonda <pgonda@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Samuel Ortiz <sameo@rivosinc.com>,
        Thomas Gleixner <tglx@linutronix.de>, <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v4 2/6] configfs-tsm: Introduce a shared ABI for
 attestation reports
Message-ID: <6513e6079a427_91c1e294e@dwillia2-xfh.jf.intel.com.notmuch>
References: <169570181657.596431.6178773442587231200.stgit@dwillia2-xfh.jf.intel.com>
 <169570182987.596431.14062417344858914481.stgit@dwillia2-xfh.jf.intel.com>
 <c3d347a7-58d6-4830-aad4-d354b83f0704@linux.intel.com>
 <CA+1=6yfmLXJbZu7Gd7cp_HOAbmHwx54aPgozWKBikWwZSYTOZw@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CA+1=6yfmLXJbZu7Gd7cp_HOAbmHwx54aPgozWKBikWwZSYTOZw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FGt/EsURtWwJz6C8Sr7LogUZl66b51mPq7w085GAmQ4tPxffd283nb9zwN8G?=
 =?us-ascii?Q?VcuKNF42mjBMTXvK/NfH+N2Wm8Q09TlLrjI7ZRrKM0RlN8jHFFl60kPy/xfh?=
 =?us-ascii?Q?yQ8HFsAkNjQUVrv57t/nNtf1+Tj4akx5cvXp+q7CUDE/8M7orc36BLkFvfOD?=
 =?us-ascii?Q?3riPKlG8mx2DQDjnvP5N+RNQPzJJJZ379FUNZy4znMItF08CG9GQM4/c7jUu?=
 =?us-ascii?Q?gRLzqnNGpX08SkZ+bNl3VglmdwjLEfW9HgaDNlLlU9hlCg7UX4J7+KOff7o6?=
 =?us-ascii?Q?D3HhnDkygomKHydXiwQyLQlj4c4uB+9Jiras7LUyYSwUsDGfN7ja05zumb2f?=
 =?us-ascii?Q?WFXEtktHAK7BsQIWxoa/ofGKitbTzhkc/xehOIw5/FQWXy5gA074GLXjOIE0?=
 =?us-ascii?Q?0uIQuQdLLkOFBNJGmEBhBP6J4zmrVA1hSWB4HV5waUDO8dOavp4FotlTbwF4?=
 =?us-ascii?Q?fkoiWMWpbmjEy0MyhCc/w6DLThk2VI0lnxw0k1696Dfa47T86yWXWVTlbRb3?=
 =?us-ascii?Q?sC907vROD4ZY+TpIa9CQBGpotmgasKzYjyqBd303MPsDpmwWidx+o+GjnCZT?=
 =?us-ascii?Q?kqGOHSU1Kr37NPKq/+Z3YHNkXt3JDFrSsVFppYKW8xMIEI6Mx1snFt9N3uqt?=
 =?us-ascii?Q?GeBmB/m420n/nS+C93xyc5ZPcpAcs/k0/FUsVAO45+OwqyDUIkh7ehhYIs5p?=
 =?us-ascii?Q?a17LWiUTf5ZW3m8fTAvZA9C+tPXN5UzSNAXxZhk5HRdUZnGS6pUX1FIYY9Xb?=
 =?us-ascii?Q?zUcvf21dkl+fI/J/BBOHow/sMWhqSR4aTZBLjd6R/vp9DvblIQi3JUFiLKDc?=
 =?us-ascii?Q?qFoJrJX0L9czHxHiBArPop0+GPhnWs9Je73lu2zxXeavvPzkwkoKdRYL9Ddd?=
 =?us-ascii?Q?i+52H6RUnVgucxHzlQaiT+fCk6fAgH6KNHSL4StijPJpDqDFYBVmZK1rpq+X?=
 =?us-ascii?Q?UdrcuY6ksMzBV1r8Fw9eNH9rwbwRMSu0dvzwvo2tYBnVaSFbKpoepz6i7lFx?=
 =?us-ascii?Q?b+yi/1azRkB7YnQIu+3Pd0mGIpmOAl6+OCDypFS2tiJirheuKyEglhrik7mR?=
 =?us-ascii?Q?CoRvCTPAHe1XV/F+1bzx0GmS+51pSK2PFpKxv8ArDnODGbwxF739lDFgpP9A?=
 =?us-ascii?Q?s8W3syZMtUN7vj1KmZHdYVcbwe/tleb5ddTrgPEJ8dmQqlPzATQBbIdXGNuF?=
 =?us-ascii?Q?uHl6qB7P2+bOIuj7qvSEvkovQ4ZlMPs7iAIp6vrR5/SjHfD7gFOAAts08F7Y?=
 =?us-ascii?Q?tlNorK6SIDpwaHfZ/1S148Gbvyw0ox7ExIOFjaldGfLz8B8mEl7JrxA0o34p?=
 =?us-ascii?Q?TuSodINA+4MJvRwLuBl+miKh3IISMqb3QN0+GVH8QPyqyODYSsf2JcdDDG3r?=
 =?us-ascii?Q?yOtKIu5x3C18aqX6m28Vej2h2ofmABhgHDdpReOcD51lxiz5e8WhwztiOaJd?=
 =?us-ascii?Q?JHwLJ1YW8VliNFnx4esMUxTldjv2/ykB5AuAC8ORZphinmchFwCg9QmdDlcS?=
 =?us-ascii?Q?n5HRdLCTgW+xtFZ+n/ybNKLbR0+5sWx2CKH3tBjF1WM3+k/9Ej/H+ZN58cns?=
 =?us-ascii?Q?SvxPJU4dRP9BeQkGhzDBAMK8TFUtBKth6H7HbDVw54z0NssLE+lt/v6KVWzS?=
 =?us-ascii?Q?uw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1194e3ff-53ef-425e-158e-08dbbf32c08f
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 08:21:30.4901
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jG4qaVQkq+3PTuzfWt0bRe66mUKL00jhJgBjJbG03imO5YxWNEwz+GFZYBxViCN2q3epFhbY6Q60DiZsd8SUEgKtuRA0fDfvqK5QOF0IUS4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5617
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 27 Sep 2023 01:22:42 -0700 (PDT)

Thomas Fossati wrote:
> Hi Dan,
> 
> > On 9/25/2023 9:17 PM, Dan Williams wrote:
> > > +++ b/include/linux/tsm.h
> > > @@ -0,0 +1,63 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> > > +#ifndef __TSM_H
> > > +#define __TSM_H
> > > +
> > > +#include <linux/sizes.h>
> > > +#include <linux/types.h>
> > > +#include <linux/device.h>
> > > +
> > > +#define TSM_INBLOB_MAX 64
> 
> I guess @inblob is supposed to (possibly) accommodate nonces from a
> challenger, correct?
> If so, 64 bytes may not be enough for attesters that produce
> EAT-formatted reports -- see [1], and [2].
> 
> [1] https://www.ietf.org/archive/id/draft-ietf-rats-eat-21.html#section-4.1-5
> [2] https://github.com/ietf-rats-wg/eat/pull/421/files

Hmm, but 64-bytes is the hard limit of the supported platform
implementations.

It can be expanded when/if those platforms expand the
size of the supported user data, or another configfs-tsm backend arrives
that needs that capability.