Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2423105rdh; Wed, 27 Sep 2023 02:02:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEuPSoBbC1M5UtP705JMPEVOfTxWiclRLoO1LPUkU+Mb7x5AnjkZW3pxLy3wdpEiR1QbO0K X-Received: by 2002:a17:902:7888:b0:1bd:d15f:bdfa with SMTP id q8-20020a170902788800b001bdd15fbdfamr973717pll.68.1695805373698; Wed, 27 Sep 2023 02:02:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695805373; cv=none; d=google.com; s=arc-20160816; b=CUugU1EOIvYpFex4ZMcSc4ZhdACtGbewr0f1sgE1RMbs6BkJtlMbn3N6qKENxgLY1P RUVvOPkM2XBXY8CHF9orgfo7MNEBN4b5IIvcE+tEywg8sKFEwFf5t1RX5DO91kJa/WqR 7lXST2IFmU2QzINGmJPlhx9eKlkw6xSFySvf9RplVbV0an7ynU3ace/CXKTYpOOP96KD Jnl8PAYJW8Khl+0Ckdy7ogdF5SA3tGYM6j5Ulb6EuzfUQ62MqYCKaC8neDugfkOaLwg8 RKxj9IH3EXA3gfROZs4tmkB/YKyeDD5OaMKukUmxBnIGY14j6SrFoz8UPmnjjPPsS7UT SNRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MwEDd7lXj2bXGV+so2/RWLmuszrHLj3xfaoIMd/pJXo=; fh=vmLV8/jeNKg38+l1nM6Q1Ajfo2uMYplbbecNRrz2VWM=; b=DVBokL5nI0A2psMiXzXOo9j98ATHywo6LUJCxY9KVHmpQ70t8DSW4WD4imZkfyowu8 M4ijSJBOj/YAaanVM4iEHcny2uGnHrG2yYXCnQY3v/rhTTsucpo2YtFd4iznmd2v1Akj TTo3eB7DAGDdzflRyn0iXhffUNJNfIpJYFUU2o66ucl8A5829pydYEi34GDg0t+r/rxX H4AwyZRke/4cR+LHJiWTJ/XHANvSMB0pOPdlg/C5UTt1zA0fhcBeA3M3oF4Q+5o3UCuW gQY4PrxE4FcS36GYXF0pC9u8t6MmyEYlJppUxZTQrMlgKg0uouUIk43WLxMX+sMr7du0 cwEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OJMjLJNd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id l11-20020a170903120b00b001c3845d008csi15637635plh.424.2023.09.27.02.02.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 02:02:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OJMjLJNd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 471F0832D715; Tue, 26 Sep 2023 17:59:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231245AbjI0A7Y (ORCPT + 99 others); Tue, 26 Sep 2023 20:59:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232008AbjI0A5X (ORCPT ); Tue, 26 Sep 2023 20:57:23 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C35083F1 for ; Tue, 26 Sep 2023 17:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695773687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MwEDd7lXj2bXGV+so2/RWLmuszrHLj3xfaoIMd/pJXo=; b=OJMjLJNdycffdWEmYSEOl7hyqTC5sC3HOkdYnKX7HOvxmSE3WN64KtXcyBtzxQ3fXYQqFf UpEicSQLdQAM+fFfH7HKcap10KDbFZJJo5jU9/Z1aGdDYm/Msg7shWe5DLdzxkkYo8rmqA l87bHG6rsfiIBGg0aiLFpg/1bJlsWNg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-436-oDALSo7ZOnaxTmKVT_hOCQ-1; Tue, 26 Sep 2023 20:14:45 -0400 X-MC-Unique: oDALSo7ZOnaxTmKVT_hOCQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1836485A5BE; Wed, 27 Sep 2023 00:14:45 +0000 (UTC) Received: from localhost (unknown [10.72.112.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 567262026D4B; Wed, 27 Sep 2023 00:14:44 +0000 (UTC) Date: Wed, 27 Sep 2023 08:14:41 +0800 From: Baoquan He To: Andrew Morton , Eric DeVolder Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, vschneid@redhat.com, sourabhjain@linux.ibm.com Subject: Re: [PATCH v3] Crash: add lock to serialize crash hotplug handling Message-ID: References: <20230926120905.392903-1-bhe@redhat.com> <20230926135001.4eb6ca73b1a4aa6224355ad1@linux-foundation.org> <11bebd5e-8183-d7a7-6acc-53b00a6cc2d5@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11bebd5e-8183-d7a7-6acc-53b00a6cc2d5@oracle.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 26 Sep 2023 17:59:26 -0700 (PDT) On 09/26/23 at 04:53pm, Eric DeVolder wrote: > > > On 9/26/23 15:50, Andrew Morton wrote: > > On Tue, 26 Sep 2023 20:09:05 +0800 Baoquan He wrote: > > > > > Eric reported that handling corresponding crash hotplug event can be > > > failed easily when many memory hotplug event are notified in a short > > > period. They failed because failing to take __kexec_lock. > > > > I'm assuming that this failure is sufficiently likely so as to justify a -stable > > backport of the fix. Please let me know if this is incorrect. > > Andrew, > Correct, this is sufficiently likely to happen. Agree. Maybe a Fixes tag need be added: === Fixes: 247262756121 ("crash: add generic infrastructure for crash hotplug support")