Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Wed, 27 Sep 2023 08:14:41 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Andrew Morton <akpm@linux-foundation.org>,
        Eric DeVolder <eric.devolder@oracle.com>
Cc:     linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
        vschneid@redhat.com, sourabhjain@linux.ibm.com
Subject: Re: [PATCH v3] Crash: add lock to serialize crash hotplug handling
Message-ID: <ZRNz8T1XOX7PWOt6@MiWiFi-R3L-srv>
References: <20230926120905.392903-1-bhe@redhat.com>
 <20230926135001.4eb6ca73b1a4aa6224355ad1@linux-foundation.org>
 <11bebd5e-8183-d7a7-6acc-53b00a6cc2d5@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <11bebd5e-8183-d7a7-6acc-53b00a6cc2d5@oracle.com>
Precedence: bulk

On 09/26/23 at 04:53pm, Eric DeVolder wrote:
> 
> 
> On 9/26/23 15:50, Andrew Morton wrote:
> > On Tue, 26 Sep 2023 20:09:05 +0800 Baoquan He <bhe@redhat.com> wrote:
> > 
> > > Eric reported that handling corresponding crash hotplug event can be
> > > failed easily when many memory hotplug event are notified in a short
> > > period. They failed because failing to take __kexec_lock.
> > 
> > I'm assuming that this failure is sufficiently likely so as to  justify a -stable
> > backport of the fix.   Please let me know if this is incorrect.
> 
> Andrew,
> Correct, this is sufficiently likely to happen.

Agree. Maybe a Fixes tag need be added:
===
Fixes: 247262756121 ("crash: add generic infrastructure for crash hotplug support")