Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Wed, 27 Sep 2023 10:56:42 +0200
From:   Mark Brown <broonie@kernel.org>
To:     Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>, linux-spi@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-renesas-soc@vger.kernel.org,
        Chris Paterson <Chris.Paterson2@renesas.com>,
        Biju Das <biju.das@bp.renesas.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 1/2] spi: renesas,rzv2m-csi: Add SPI Slave related
 properties
Message-ID: <ZRPuSidGd5zO6pXf@finisterre.sirena.org.uk>
References: <20230926210818.197356-1-fabrizio.castro.jz@renesas.com>
 <20230926210818.197356-2-fabrizio.castro.jz@renesas.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="NweErwwnK6vf4dVT"
Content-Disposition: inline
In-Reply-To: <20230926210818.197356-2-fabrizio.castro.jz@renesas.com>
Precedence: bulk


--NweErwwnK6vf4dVT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Sep 26, 2023 at 10:08:17PM +0100, Fabrizio Castro wrote:
> The CSI IP found inside the Renesas RZ/V2M SoC can also work
> in SPI slave mode.
> When working in slave mode, the IP can make use of the SS
> (Slave Select) pin, with "low" as default active level.
> The active level of SS can be changed to "high" upon configuration.
> This patch adds two new properties, one to make use of the
> SS pin when in slave mode, and one to make the SS pin active high.

Please avoid the use of outdated terminology like this, prefer "device
mode" or similar.

> +  renesas,csi-ss:
> +    type: boolean
> +    description:
> +      Use CSI Slave Selection (SS) pin to enable transmission and reception when
> +      in slave mode.

When would this ever not be true when in device mode?

--NweErwwnK6vf4dVT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUT7kkACgkQJNaLcl1U
h9AMqgf/ZuFxoWKxQxzkjvFfE0DOLwBfbcS17S+hLEbttlrCE5+4EBd224qBeKYQ
iRQpyNVbPXfCJesuwKzplzK1EMJ3bmgtf2JksGIEwxchjCPEcAB3MakWimJyRfeN
CunfmZ6US/62Xg+X8ZTO2F9IYpwfxK2xcT2bwuF1iDNMaYuuH0ohYN8TyRJ1P/d6
2mrkBs367ZBYilYKWICHV3HxBy8HlkAqGG8v5HdoUd5CrJVCyUpuW9NVTbNerSru
XQhvx3DVdPzpBKDv+d7XPsAGD4UhbBBsUKyUsV8l15wgqBy/bzscRM5Qx6nhW4qA
2Ni1w+aITJRQnwtge9UPpruggz0cQA==
=aQdy
-----END PGP SIGNATURE-----

--NweErwwnK6vf4dVT--