Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Wed, 27 Sep 2023 11:59:31 +0200
From:   Mark Brown <broonie@kernel.org>
To:     ChiYuan Huang <cy_huang@richtek.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Allen Lin <allen_lin@richtek.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: rtq9128: Add TDM data source selection
Message-ID: <ZRP9Aw904ynL5Se/@finisterre.sirena.org.uk>
References: <1695780376-32301-1-git-send-email-cy_huang@richtek.com>
 <ZRPyMolOIjLBWXPC@finisterre.sirena.org.uk>
 <20230927094637.GA25905@linuxcarl2.richtek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="1C4mWfMNaZDyDOFk"
Content-Disposition: inline
In-Reply-To: <20230927094637.GA25905@linuxcarl2.richtek.com>
Precedence: bulk


--1C4mWfMNaZDyDOFk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Sep 27, 2023 at 05:46:37PM +0800, ChiYuan Huang wrote:
> On Wed, Sep 27, 2023 at 11:13:22AM +0200, Mark Brown wrote:

> > Is this something that's going to be changing dynamically at runtime or
> > should this be a device property that's set either by firmware or when
> > we're doing the TDM setup?  This sounds like something I'd expect to be
> > fixed by the board design.

> I may think one case if ASoC platform support multiple data source outputs
> that share the same bck/lcrk on different data pin. If it can be dynamically
> adjusted for the scenarios, this will keep the flexibility for the differet
> platform design.

Sure, but is that actually a practical design - or if someone is doing
this shouldn't it be joined up with the TDM configuration since with
just the control it'd only be possible to switch the pins but not change
the TDM layout?  I'm not sure that this control works as a standalone
thing.

--1C4mWfMNaZDyDOFk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUT/P8ACgkQJNaLcl1U
h9A3nAf9H92yVuO7k/UTjTIXfx3suPYVPOICJ5sKklHL8Vd2+uL3ks7E9EbmnCzR
Me3Esxfs9EdVnBVgIpoOBUOmtrZTzrlm9Y7DG6q0y4gV/6ShctHIqKgXhGlPftUY
7iUgF1GPTeHjpqg+PmlWh/C7zqtjrcauyxzrGclpBbilg/1CKRwaSyJNwblLXLDZ
c4kBua84DXvkBEUYRyr+S1HNzwo1bd2R3FF9Q39kgunTl+PAcEVs8AqzsnZx7Tgg
EABemg1WEyrRVjvVyfyZP7BmdjGcFzCllD96yJsIQf0W25a9ne3PxVftFbsiATVH
hic094EtySRJ8jr+PI+QWbqRCwYPYw==
=uBaT
-----END PGP SIGNATURE-----

--1C4mWfMNaZDyDOFk--