Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Wed, 27 Sep 2023 11:13:22 +0200
From:   Mark Brown <broonie@kernel.org>
To:     cy_huang@richtek.com
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Allen Lin <allen_lin@richtek.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: rtq9128: Add TDM data source selection
Message-ID: <ZRPyMolOIjLBWXPC@finisterre.sirena.org.uk>
References: <1695780376-32301-1-git-send-email-cy_huang@richtek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5fIGTM3mlZcEO9YK"
Content-Disposition: inline
In-Reply-To: <1695780376-32301-1-git-send-email-cy_huang@richtek.com>
Precedence: bulk


--5fIGTM3mlZcEO9YK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 27, 2023 at 10:06:16AM +0800, cy_huang@richtek.com wrote:

> Since rtq9128 can support 4 channel I2S mode audio data, there are two
> dedicated data input pins for CH12 and CH34.  But in TDM mode, input
> source was already drived on one data pin for multiple data slots. In
> this case, only one input source is needed for TDM mode.
>=20
> This patch is to add the data source pin selection for CH12 and CH34.

> +	SOC_ENUM("CH12 TDM Data Select", rtq9128_ch12_tdm_data_select_enum),
> +	SOC_ENUM("CH34 TDM Data Select", rtq9128_ch34_tdm_data_select_enum),

Is this something that's going to be changing dynamically at runtime or
should this be a device property that's set either by firmware or when
we're doing the TDM setup?  This sounds like something I'd expect to be
fixed by the board design.

--5fIGTM3mlZcEO9YK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUT8jEACgkQJNaLcl1U
h9AD9gf/XjwqNVU01O8geeDs/n0uPuij3TFEV+9FdQXoWkepHbUHI3z9MKx9QH2w
mrLYz27YdS0unjrkqXZk6L53daybs2KxJQCb1HlV3/YsFiwsWII6ZCYeAZASTwFs
SOXf8ZJmdkgXJxf0lYq+m7dNCG6e9EVqC2XlUWvbnUdVkYstni7TKSK7i/lvoT/1
+4WezkK8onTaoz3mprbc2TBDGfwATC5LA7E2CGZ0734rZd9XjyzY0wK8SPJn5cL3
1rNPGqvjzdc+f6VtpVKvZHK3JhONqKMCX+DWrf6Wx24QxjA5xzYpKMBviVSzEbMh
MDPRg6Bo5Dl8fezHnz75NQjf2hUBog==
=oiAQ
-----END PGP SIGNATURE-----

--5fIGTM3mlZcEO9YK--