Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2459967rdh; Wed, 27 Sep 2023 03:26:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyDddB4uZ31eC3PR58O5Vbb8tUCGJXVFSPB7Y1vaVNaUvwZ/T4qCaEh5I3fk/fo3kXC8tB X-Received: by 2002:a17:90a:71c9:b0:276:ae8f:2456 with SMTP id m9-20020a17090a71c900b00276ae8f2456mr1098328pjs.3.1695810365876; Wed, 27 Sep 2023 03:26:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695810365; cv=none; d=google.com; s=arc-20160816; b=S9FNj6Lel5LLvJPchMiUF9Dbd24OSC5YNIZQlSBxik4WwUwSgVCjWyfYr7rA0jAxGJ 80WuhvIrYtgZzgt6KfQAumTpyN2rGJm+tZE+0Ys2pDmyLEmeb65vKqFFyh+Q/pxOHQD8 Kx4me/NS72xTMXam1lKfZ4tvVHHvPS7nfpuzQw3/PybFiHE3b+9id7PVldlbXvLrLAqW YfgN1LS3RR4mu2SNTp5Nd7bKFzcyt+Ztjrroqq+CtMzxi4+4QBPJnNnesKtsYz3XlxBq G8UrztmFjd+u9CGVaA+fTjNVL3l0euqXx/Dp37IYiVHzAkJ0ozRmx3fTOkQlW5whZZUE VG8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=Tcr0CN9PcXUgHUapLQF78CZqwTi7GXoA2ts5IH+FQdM=; fh=jPdFUD1CQ5rDhbF2+xKyNiuEjfJXzge+nILCgiV5KPE=; b=OvIYXSgUgQ7lnWZXKsC3PYTh7ylRkX6R6PJEUg8cBRy0lZE/FgkyqNIwvF1Jx48G3q bFetTbNOaphZ7lUOtls41hTGeLDZSrWbnHXa0DGeSJhP0a99yPnOsFNYqT58gn+ccm5T FK5ippBalbOb8CGRluzT0RGzdBYC14Fn5z2+4wDQQdHzyVNZesF5DYr8ebdy83t9FKcd b1XJD0+TCZEeqkE6FILzodn5VUYrxL4u4nmb+IA/ooj+oTtpns/Vj5D8T04a75QcgeO6 TnEtEZiB9egkpAsh86+J7O/1tmpvkmDyRAnffLRm2E1S9gxoAvaDVKS975fYmNm7mIKI E3mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="V7/ueg+u"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id fa14-20020a17090af0ce00b00277624ffa82si6889061pjb.86.2023.09.27.03.26.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 03:26:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="V7/ueg+u"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id CD8C980ECF25; Wed, 27 Sep 2023 01:51:14 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230175AbjI0Iu5 (ORCPT + 99 others); Wed, 27 Sep 2023 04:50:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbjI0Iuy (ORCPT ); Wed, 27 Sep 2023 04:50:54 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17C27E4 for ; Wed, 27 Sep 2023 01:50:53 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E248FC433C7; Wed, 27 Sep 2023 08:50:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695804652; bh=9vFab4sPRBAj5706m3HoSNU3XGY+zOPkRZTBDOQYU+o=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=V7/ueg+ufSKsCz8S79hASiKUTQk/PoP0RKHm+fyd47r/fKQKSfYi1uL+VyqZe2od/ VTJs3zzkGNtRSdQTk2JCMdDqnevrdKnh2ucFbUWvk76xl40cs+nExh+c9W6AkiTsXe mCHpQwaEKamoyDD3uBMrqU1HRiadaoklgyGEzaz6XD1pGYsq/jbLm1q/7PKTEqS3bd vof9i4KJ9SbvEWDVW0ETKdzbeua/6cMsMWCkoQ04lVlVqqhDceVWAy85YXShTEGXa+ o0GxxcC+1KlXUOe4KBLxCKFcnejqUomhBAGRgCkkOuESiv+r6UqsTK6av7di4ZFOx7 tYS/Dx1+4JGVQ== From: Mark Brown To: Liam Girdwood , =?utf-8?q?Micha=C5=82_Miros=C5=82aw?= Cc: Vladimir Zapolskiy , linux-kernel@vger.kernel.org In-Reply-To: References: Subject: Re: [PATCH v2 1/2] regulator/core: regulator_register: set device->class earlier Message-Id: <169580465113.2674076.14526284679681937734.b4-ty@kernel.org> Date: Wed, 27 Sep 2023 10:50:51 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.13-dev-099c9 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 27 Sep 2023 01:51:15 -0700 (PDT) On Tue, 19 Sep 2023 00:50:26 +0200, Michał Mirosław wrote: > When fixing a memory leak in commit d3c731564e09 ("regulator: plug > of_node leak in regulator_register()'s error path") it moved the > device_initialize() call earlier, but did not move the `dev->class` > initialization. The bug was spotted and fixed by reverting part of > the commit (in commit 5f4b204b6b81 "regulator: core: fix kobject > release warning and memory leak in regulator_register()") but > introducing a different bug: now early error paths use `kfree(dev)` > instead of `put_device()` for an already initialized `struct device`. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/2] regulator/core: regulator_register: set device->class earlier commit: 8adb4e647a83cb5928c05dae95b010224aea0705 [2/2] regulator/core: Revert "fix kobject release warning and memory leak in regulator_register()" commit: 6e800968f6a715c0661716d2ec5e1f56ed9f9c08 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark