Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Wed, 27 Sep 2023 12:28:29 +0200
From:   Mark Brown <broonie@kernel.org>
To:     ChiYuan Huang <cy_huang@richtek.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Allen Lin <allen_lin@richtek.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: rtq9128: Add TDM data source selection
Message-ID: <ZRQDzZG7PPovUIsf@finisterre.sirena.org.uk>
References: <1695780376-32301-1-git-send-email-cy_huang@richtek.com>
 <ZRPyMolOIjLBWXPC@finisterre.sirena.org.uk>
 <20230927094637.GA25905@linuxcarl2.richtek.com>
 <ZRP9Aw904ynL5Se/@finisterre.sirena.org.uk>
 <20230927101948.GA27975@linuxcarl2.richtek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="D0qJCejxf+Euu+mv"
Content-Disposition: inline
In-Reply-To: <20230927101948.GA27975@linuxcarl2.richtek.com>
Precedence: bulk


--D0qJCejxf+Euu+mv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Sep 27, 2023 at 06:19:48PM +0800, ChiYuan Huang wrote:
> On Wed, Sep 27, 2023 at 11:59:31AM +0200, Mark Brown wrote:

> > Sure, but is that actually a practical design - or if someone is doing
> > this shouldn't it be joined up with the TDM configuration since with
> > just the control it'd only be possible to switch the pins but not change
> > the TDM layout?  I'm not sure that this control works as a standalone
> > thing.

> I think if two data source input for different scenarios, then the data source
> switch will become practical. For the standalone usage, keep a device property
> to decide this may be enough. But consider the future application, to keep this
> in general mixer control is still usable to meet the complex design.

My concern is that the control might not actually be usable without also
changing the TDM mode so we might need the machine driver to add a
control which flips the input and also changes the TDM mode - it feels
likley that if there are two inputs they won't have identical formats.

--D0qJCejxf+Euu+mv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUUA8wACgkQJNaLcl1U
h9AkUQf/bHqfsJCtxIZwe9pBVupRqgu3iwyqLmWXWCS8b3tyO4RvM/XBxkSH8NDY
6Plwt9R4CuvRGgVUyMLyuCNnZWj8925kgcmhPtXA2l3wdGq4pyvvxR3k4/tNJtpS
W5d1csRIOqWJQSpR/L/THHCj1JcTqDnGLdU724MHA5QvVFjBgOLGFAnRgUmiZr5z
ftO8+UoQsMrjzG7pAlMo7ACQ5EP7GLk865NzBloiiVOizs6tWBZHnIDup8vJJA2I
n8i8bnblQBghWL4SZ6oBlr2AeRNTVDbKQXQnvSi8eLhU2qDwwAH61906roRs4ZQH
N5khCHwX0zTrKaDUmzlPpAb7Gr8srw==
=Fp4G
-----END PGP SIGNATURE-----

--D0qJCejxf+Euu+mv--