Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Wed, 27 Sep 2023 17:46:37 +0800
From:   ChiYuan Huang <cy_huang@richtek.com>
To:     Mark Brown <broonie@kernel.org>
CC:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Allen Lin <allen_lin@richtek.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: codecs: rtq9128: Add TDM data source selection
Message-ID: <20230927094637.GA25905@linuxcarl2.richtek.com>
References: <1695780376-32301-1-git-send-email-cy_huang@richtek.com>
 <ZRPyMolOIjLBWXPC@finisterre.sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZRPyMolOIjLBWXPC@finisterre.sirena.org.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Wed, Sep 27, 2023 at 11:13:22AM +0200, Mark Brown wrote:
> On Wed, Sep 27, 2023 at 10:06:16AM +0800, cy_huang@richtek.com wrote:
> 
> > Since rtq9128 can support 4 channel I2S mode audio data, there are two
> > dedicated data input pins for CH12 and CH34.  But in TDM mode, input
> > source was already drived on one data pin for multiple data slots. In
> > this case, only one input source is needed for TDM mode.
> > 
> > This patch is to add the data source pin selection for CH12 and CH34.
> 
> > +	SOC_ENUM("CH12 TDM Data Select", rtq9128_ch12_tdm_data_select_enum),
> > +	SOC_ENUM("CH34 TDM Data Select", rtq9128_ch34_tdm_data_select_enum),
> 
> Is this something that's going to be changing dynamically at runtime or
> should this be a device property that's set either by firmware or when
> we're doing the TDM setup?  This sounds like something I'd expect to be
> fixed by the board design.

I may think one case if ASoC platform support multiple data source outputs
that share the same bck/lcrk on different data pin. If it can be dynamically
adjusted for the scenarios, this will keep the flexibility for the differet
platform design.

Like as in most codecs, there could be mux design that can use to choose the 
dedicated data input. If we fixed in device property, the flexibility will be
missing. It's our original thought to have the control for the data select
mutiplexer.