Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2497026rdh; Wed, 27 Sep 2023 04:41:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbG8AcvclyvLNyYiA7TLmDsiPSOKq4bbCf6GgCM1zTJMQorf5ZHWHo53//d88sAVHmgRMe X-Received: by 2002:a05:6358:786:b0:141:1469:1f93 with SMTP id n6-20020a056358078600b0014114691f93mr1543544rwj.2.1695814866895; Wed, 27 Sep 2023 04:41:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695814866; cv=none; d=google.com; s=arc-20160816; b=aeLoFj+UF5KL9ixG1xJ1PERRG/X87IRjy0BsefreWECCkgpD7CQ7g/d9hkwPN6mbOj KG+TgKLLqk/hboWYSD9dKfb2IkTmkfdAo/R0MiVUYrCqLIHs0zhHanD1e4nR3GPJfZxN yd9pjnZVL7e8GO48HiBm8KKWIHLISNOFSEYndmS+gJncUdumfxwGYAGiZKZbYmlWWEM7 EEsx8wi80Ea+RrudkZ1fGg5A9IjU5v+C/SSFMHe+6CT7xFZrTQgVvyq0vGDtLsBUZTN6 9kCow5M4oYO8P8lpmRcjBnvhPc4be2TinuRmpMsK/5KpOaEbnuSgGqtsZVXL6Mgz6Wz3 ybTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:dkim-signature:dkim-filter; bh=VF8E0OIJeKcGGBzBeINuMrvGewchRqeLtbzc8waalJ4=; fh=iWKtNcOVhv0C+mwPQaBdC9PSooNkoSTqsH8F77EKC8Q=; b=CARCzpd2VW6gpe2/Bf0P7oLp+iD1WOYmNZEA2ETVMSX6ux8zQ4lv6bsxgMDGC+OLJT gBJtkZkRucWJ0AerHfvuumgsLepA34awoCPTXp6Kvm6NIl2+uXKagCB+sEwlcl1CPH15 xtpVPbOnAK48FJI+vCO9PX3l4A+9wJNUzr6yUiNDNkms7lyj4SHhFc+2y4Imb2bpIjm3 8YWjx2PcM8rrFv+xZ1SS6iNnlyc2m1YhGdeaASlwfX5XcJL15Te9c1aL9+tDXzh7wQPN yJvPdoKvcC0wtUSSDdSrK3RK+WX1OGg0oXGm7VmITA52tjPhI1MR88ijZb3ajbmbzR3F Jgww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zytor.com header.s=2023091101 header.b=YLdw5I1J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zytor.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id h2-20020a635302000000b0056336fb99aasi14937886pgb.850.2023.09.27.04.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 04:41:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@zytor.com header.s=2023091101 header.b=YLdw5I1J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zytor.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 75B47808E670; Wed, 27 Sep 2023 01:16:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230303AbjI0IPz (ORCPT + 99 others); Wed, 27 Sep 2023 04:15:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230220AbjI0IPg (ORCPT ); Wed, 27 Sep 2023 04:15:36 -0400 Received: from mail.zytor.com (unknown [IPv6:2607:7c80:54:3::138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B474E173F for ; Wed, 27 Sep 2023 01:12:58 -0700 (PDT) Received: from [192.168.7.187] ([76.103.185.250]) (authenticated bits=0) by mail.zytor.com (8.17.1/8.17.1) with ESMTPSA id 38R8C6tk2639899 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Wed, 27 Sep 2023 01:12:07 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 38R8C6tk2639899 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2023091101; t=1695802327; bh=VF8E0OIJeKcGGBzBeINuMrvGewchRqeLtbzc8waalJ4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YLdw5I1Jtjm7N6VRuTqdubanR/BFTq9ZM0KCfitjfkSp9diq5/r5CI8zNaLIx63rt toQFwjB/fBy/wQKLslx5fWj2PHc+Dh6w5N2yWAQ0RGDooHBDHcIn5IK9MS4dGcJOmS PLZzgqceT+TNysPe4bcPo2c29VCJFknesysE0L8G77+pLz+ETO9xxnewWIZ4qtxvVa 3zYCCBqGOdAGqdvwJdoRtkFLaA4s/PH7NW7RncGwpoJBA+J2GafYo+BkSYzDDbqmRK ZB3OP5ipX8mxkTMVfN/GzXo5ggezdsl18GEFQPj828z0xjzrA3/FxjZqhZjxxUjHgo SvttTdt7kCd9g== Message-ID: <6610548d-4b3a-49cb-83a2-b9047f96e03e@zytor.com> Date: Wed, 27 Sep 2023 01:12:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] x86/entry: remove unused argument %rsi passed to exc_nmi() To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com References: <20230926061319.1929127-1-xin@zytor.com> Content-Language: en-US From: Xin Li Autocrypt: addr=xin@zytor.com; keydata= xsDNBGUPz1cBDACS/9yOJGojBFPxFt0OfTWuMl0uSgpwk37uRrFPTTLw4BaxhlFL0bjs6q+0 2OfG34R+a0ZCuj5c9vggUMoOLdDyA7yPVAJU0OX6lqpg6z/kyQg3t4jvajG6aCgwSDx5Kzg5 Rj3AXl8k2wb0jdqRB4RvaOPFiHNGgXCs5Pkux/qr0laeFIpzMKMootGa4kfURgPhRzUaM1vy bsMsL8vpJtGUmitrSqe5dVNBH00whLtPFM7IbzKURPUOkRRiusFAsw0a1ztCgoFczq6VfAVu raTye0L/VXwZd+aGi401V2tLsAHxxckRi9p3mc0jExPc60joK+aZPy6amwSCy5kAJ/AboYtY VmKIGKx1yx8POy6m+1lZ8C0q9b8eJ8kWPAR78PgT37FQWKYS1uAroG2wLdK7FiIEpPhCD+zH wlslo2ETbdKjrLIPNehQCOWrT32k8vFNEMLP5G/mmjfNj5sEf3IOKgMTMVl9AFjsINLHcxEQ 6T8nGbX/n3msP6A36FDfdSEAEQEAAc0WWGluIExpIDx4aW5Aenl0b3IuY29tPsLBDQQTAQgA NxYhBIUq/WFSDTiOvUIqv2u9DlcdrjdRBQJlD89XBQkFo5qAAhsDBAsJCAcFFQgJCgsFFgID AQAACgkQa70OVx2uN1HUpgv/cM2fsFCQodLArMTX5nt9yqAWgA5t1srri6EgS8W3F+3Kitge tYTBKu6j5BXuXaX3vyfCm+zajDJN77JHuYnpcKKr13VcZi1Swv6Jx1u0II8DOmoDYLb1Q2ZW v83W55fOWJ2g72x/UjVJBQ0sVjAngazU3ckc0TeNQlkcpSVGa/qBIHLfZraWtdrNAQT4A1fa sWGuJrChBFhtKbYXbUCu9AoYmmbQnsx2EWoJy3h7OjtfFapJbPZql+no5AJ3Mk9eE5oWyLH+ QWqtOeJM7kKvn/dBudokFSNhDUw06e7EoVPSJyUIMbYtUO7g2+Atu44G/EPP0yV0J4lRO6EA wYRXff7+I1jIWEHpj5EFVYO6SmBg7zF2illHEW31JAPtdDLDHYcZDfS41caEKOQIPsdzQkaQ oW2hchcjcMPAfyhhRzUpVHLPxLCetP8vrVhTvnaZUo0xaVYb3+wjP+D5j/3+hwblu2agPsaE vgVbZ8Fx3TUxUPCAdr/p73DGg57oHjgezsDNBGUPz1gBDAD4Mg7hMFRQqlzotcNSxatlAQNL MadLfUTFz8wUUa21LPLrHBkUwm8RujehJrzcVbPYwPXIO0uyL/F///CogMNx7Iwo6by43KOy g89wVFhyy237EY76j1lVfLzcMYmjBoTH95fJC/lVb5Whxil6KjSN/R/y3jfG1dPXfwAuZ/4N cMoOslWkfZKJeEut5aZTRepKKF54T5r49H9F7OFLyxrC/uI9UDttWqMxcWyCkHh0v1Di8176 jjYRNTrGEfYfGxSp+3jYL3PoNceIMkqM9haXjjGl0W1B4BidK1LVYBNov0rTEzyr0a1riUrp Qk+6z/LHxCM9lFFXnqH7KWeToTOPQebD2B/Ah5CZlft41i8L6LOF/LCuDBuYlu/fI2nuCc8d m4wwtkou1Y/kIwbEsE/6RQwRXUZhzO6llfoN96Fczr/RwvPIK5SVMixqWq4QGFAyK0m/1ap4 bhIRrdCLVQcgU4glo17vqfEaRcTW5SgX+pGs4KIPPBE5J/ABD6pBnUUAEQEAAcLA/AQYAQgA JhYhBIUq/WFSDTiOvUIqv2u9DlcdrjdRBQJlD89ZBQkFo5qAAhsMAAoJEGu9DlcdrjdR4C0L /RcjolEjoZW8VsyxWtXazQPnaRvzZ4vhmGOsCPr2BPtMlSwDzTlri8BBG1/3t/DNK4JLuwEj OAIE3fkkm+UG4Kjud6aNeraDI52DRVCSx6xff3bjmJsJJMb12mWglN6LjdF6K+PE+OTJUh2F dOhslN5C2kgl0dvUuevwMgQF3IljLmi/6APKYJHjkJpu1E6luZec/lRbetHuNFtbh3xgFIJx 2RpgVDP4xB3f8r0I+y6ua+p7fgOjDLyoFjubRGed0Be45JJQEn7A3CSb6Xu7NYobnxfkwAGZ Q81a2XtvNS7Aj6NWVoOQB5KbM4yosO5+Me1V1SkX2jlnn26JPEvbV3KRFcwV5RnDxm4OQTSk PYbAkjBbm+tuJ/Sm+5Yp5T/BnKz21FoCS8uvTiziHj2H7Cuekn6F8EYhegONm+RVg3vikOpn gao85i4HwQTK9/D1wgJIQkdwWXVMZ6q/OALaBp82vQ2U9sjTyFXgDjglgh00VRAHP7u1Rcu4 l75w1xInsg== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 27 Sep 2023 01:16:06 -0700 (PDT) On 9/27/2023 1:06 AM, Ingo Molnar wrote: > > * xin@zytor.com wrote: > >> From: "Xin Li (Intel)" >> >> exc_nmi() only takes one argument of type struct pt_regs *, but >> asm_exc_nmi() calls it with 2 arguments. The second one passed >> in %rsi seems a leftover, so simply remove it. >> >> BTW, fix 2 slips in the comments. >> >> Signed-off-by: Xin Li (Intel) >> Acked-by: H. Peter Anvin (Intel) >> --- >> arch/x86/entry/entry_64.S | 10 ++++------ >> 1 file changed, 4 insertions(+), 6 deletions(-) > > I've split this into two patches, because the comment fixes > are entirely unrelated to this patch. > > [ I've propagated the SOBs and Acked-by's to the two patches, > as I presume is fine by everyone involved? ] surely no problem at all!