From: Neil Brown <neilb@suse.de>
To: "J. Bruce Fields" <bfields@citi.umich.edu>
Date: Tue, 13 Nov 2007 09:08:42 +1100
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <18232.52970.213438.902011@notabene.brown>
Cc: Linus Torvalds <torvalds@linux-foundation.org>, nfs@lists.sourceforge.net,
       linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: nfsd bugfixes
In-Reply-To: message from J. Bruce Fields on Monday November 12
References: <1194901503-23105-1-git-send-email-bfields@citi.umich.edu>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 980
Lines: 26

On Monday November 12, bfields@citi.umich.edu wrote:
> The following two patches are nfsd bugfixes that I believe are
> appropriate for 2.6.24 and 2.6.23.y.
> 
> --b.
> 

Both
  Reviewed-By: NeilBrown <neilb@suse.de>

Calling nfsd_setuser an extra time does open us up for a very tiny
possibility of an ENOMEM at an awkward time.
We could remove that entirely for NFSEXP_ALLSQUASH by allocating an
empty group_info at export time and just using a reference to that.
It would be more awkward to pre-allocate for the NFSEXP_ROOTSQUASH
case as the group_info has to be at least as big as the one in the RPC
request, and would could need a different one of each concurrent
request.... not sure if that is worth "fixing".

Thanks,
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/