Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Tue, 26 Sep 2023 20:17:29 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        <linux-coco@lists.linux.dev>
CC:     Dionna Amalie Glaze <dionnaglaze@google.com>,
        James Bottomley <James.Bottomley@hansenpartnership.com>,
        Peter Gonda <pgonda@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Samuel Ortiz <sameo@rivosinc.com>,
        Thomas Gleixner <tglx@linutronix.de>, <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v4 2/6] configfs-tsm: Introduce a shared ABI for
 attestation reports
Message-ID: <65139ec9e25ef_91c1e294aa@dwillia2-xfh.jf.intel.com.notmuch>
References: <169570181657.596431.6178773442587231200.stgit@dwillia2-xfh.jf.intel.com>
 <169570182987.596431.14062417344858914481.stgit@dwillia2-xfh.jf.intel.com>
 <c3d347a7-58d6-4830-aad4-d354b83f0704@linux.intel.com>
 <651329fed4947_124e929464@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <668e7778-e1f6-48a8-9631-0643c1ce9e4f@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <668e7778-e1f6-48a8-9631-0643c1ce9e4f@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JHt9ZOPlYjOoP8nK+tNuEi33TmuykqVVT/msjCeDe3Rscgp6aRxDLCaygldO?=
 =?us-ascii?Q?YA2VZDM0Dewc9bvUp5skqV3i6YQvokisSxIfrJpGE/kaWSS62JOa2c20iRy8?=
 =?us-ascii?Q?HDErMFCjD1BQfVGCrzU3pL2EKZLBItd0dygPiNOkEnHuTzXTF8rsQ4xyksly?=
 =?us-ascii?Q?SvFNR5ZbNKum1TyOngi8yIRxihq2mm1pE8oqd9T70CWbF69dsMCLfcl5LNd1?=
 =?us-ascii?Q?YRJkBubHRNmlhTM35IUsyDlJWFFu08QSLEQc6evkcgaQ1CFBscj5qjBZ2GAm?=
 =?us-ascii?Q?ZGe7rWszKX5rFa2arlVFmAcMZ5tCQUlm4ooCIYI4VjFMs+05GZGMD7ZgEuOT?=
 =?us-ascii?Q?ifBK6dR9XEWStGXhzcLN5Ai0FzITNm8TzrTHg8o6dcuVZr7XxEaci7j813hI?=
 =?us-ascii?Q?6u9N1b8rZduX7p/Q0nsPi3augGER1Ccrf6W3wdAgrWA23AwxvG65QuvPbp3U?=
 =?us-ascii?Q?bWOfW+gGa+/BiOidm8p8Z2VeKp35hOtASfI65Y1HZJkKt/iRgVJCrbGGQHNO?=
 =?us-ascii?Q?VHo8T7xWM6PRVt/CnBYsMu6O9m3HrAUC6rZxqxdD0N3xkxC/DcU2gme0Tu3r?=
 =?us-ascii?Q?p4vmc2RSmWvkUZIsdsSqxgxnLxO9X6CCGvRTVX0McewPX3wOVo9ATIcnN2tC?=
 =?us-ascii?Q?9LE6s94gpo2ua1YJTKu4+vVIkBgYFS0v5IFJyLd7mVsRhEOVsTRsIljzQEAr?=
 =?us-ascii?Q?Ndv72cU+cZdg3NzgXcLGAM0vuqCkXOum61EhqMkk2/c5mdP3mboBjA+sYyX1?=
 =?us-ascii?Q?bkmxHBUYHCv1OyoojlIhlqm+M9v4naEqH3B9dPpXugL0np/QDHL0rxcRTaON?=
 =?us-ascii?Q?8mnUMTU0M/+STUHaPjKcPXommEUl0TXMf7FXDNBza5f9OCaWy4N3ropKkfwL?=
 =?us-ascii?Q?0dlXu+KyPoZTKxvF+3fyaA68O56p0FDnvVDN0KF86sfbXwjpqzgtp3BA2lm4?=
 =?us-ascii?Q?bPQWTyMZd/UWHToII2UiDbEdDzBWs2uTR1bdSx1U66dLmF1OBHDAtg5938XA?=
 =?us-ascii?Q?4Y5KbxzomiR36B8IjBtFsLAzNJG80GP5+26IhCScqSRwONbalArmIcN2OfHN?=
 =?us-ascii?Q?8nQzFjEP89dJvNU2zK/3GNd3Xj3ycPRscMtUHWiHbTgeY9PWWMmFPCYPYOPP?=
 =?us-ascii?Q?3vAE91fHVbH1qXbxfU5MyE5bs70YNfnBUz6Dyf64u8AIf1lq/DcLw5mOj8qm?=
 =?us-ascii?Q?XiZkPkwo9bXSMnbLUv8DvaTz+Zs/Aj9JK7OxgNijLUeL9+SC1fRZZxI/Bi9H?=
 =?us-ascii?Q?7IZbHJV3qE5rqezhKVebEvFE8Wv+cdlPASF4FILhw8QvmbX0Isf7M0BjL9yu?=
 =?us-ascii?Q?bct0qBOMNyXclZPBp/3aW927FpfIwC+cVCcWRcBImR0JPFKTa7hQg8oVF7zF?=
 =?us-ascii?Q?t2VzNqlWrC3H8wkztYUOBvs6ZVpZfNv1MnbJIp67XVnYNPq7fK9yqW6H+10t?=
 =?us-ascii?Q?gXpjOM65H3Yuh3vWUr3AnBAnUQVV8+y8WPQMMIuuUJPd8FDgyZxXWcY3kEYE?=
 =?us-ascii?Q?6rpchoYE+5Aak30I3jfKtnycn+UuupN1aJm5cyggoZ/6q9PRisFIT7MRaDCV?=
 =?us-ascii?Q?Dsy5u7saFuHWfkU4wtE0TP1FLwiaogCqgHSnU9aPR0mzMtEoBB3XpNDqRYne?=
 =?us-ascii?Q?Uw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 80181811-366c-4488-c06b-08dbbf084a31
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 03:17:33.0230
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CM+BqwD3tJ+UJJ6goFQVcnuSNWXXZGL511o9chYlBMR6udDSj7JGqfCETh90nGG8b+uDt6pYP7GNqViSRCqHplAMcaLIGisA5O2QGtR+WsI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6469
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 26 Sep 2023 21:29:39 -0700 (PDT)

Kuppuswamy Sathyanarayanan wrote:
[..]
> >>> +/**
> >>> + * struct tsm_desc - option descriptor for generating tsm report blobs
> >>> + * @privlevel: optional privilege level to associate with @outblob
> >>> + * @inblob_len: sizeof @inblob
> >>> + * @inblob: arbitrary input data
> >>> + */
> >>> +struct tsm_desc {
> >>> +	unsigned int privlevel;
> >>> +	size_t inblob_len;
> >>> +	u8 inblob[TSM_INBLOB_MAX];
> >>> +};
> >>> +
> >>> +/**
> >>> + * struct tsm_report - track state of report generation relative to options
> >>> + * @desc: report generation options / cached report state
> >>> + * @outblob: generated evidence to provider to the attestation agent
> >>> + * @outblob_len: sizeof(outblob)
> >>
> >> I think following is incorrect. You might want to add info about certs_len
> >> and certs.
> > 
> > Yeah, missed updating this with certs addition. The outblob_len
> > definition is correct, or do you mean the kdoc is out of order with
> > respect to the struct?
> 
> No, I am talking about the write_generation, read_generation and cfg options.
> They are part of struct tsm_report_state, so why document it here?

Ah yup, will fix.