Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <b7c87a3a-32ef-fe58-0cf2-230100f377d5@ti.com>
Date:   Wed, 27 Sep 2023 13:53:55 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v5 4/7] arm64: dts: ti: k3-j784s4-main: Add the main
 domain watchdog instances
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <robh+dt@kernel.org>, <nm@ti.com>, <vigneshr@ti.com>,
        <conor+dt@kernel.org>, <kristo@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>
CC:     <u-kumar1@ti.com>, <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230926132805.6518-1-j-keerthy@ti.com>
 <20230926132805.6518-5-j-keerthy@ti.com>
 <0c709939-9867-4d80-ba7e-640b594f8d7a@linaro.org>
From:   "J, KEERTHY" <j-keerthy@ti.com>
In-Reply-To: <0c709939-9867-4d80-ba7e-640b594f8d7a@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/27/2023 1:24 PM, Krzysztof Kozlowski wrote:
> On 26/09/2023 15:28, Keerthy wrote:
>> There are totally 19 instances of watchdog module. One each for the
>> 8 A72 cores, one each for the 4 C7x cores, 1 for the GPU, 1 each
>> for the 6 R5F cores in the main domain. Keeping only the A72 instances
>> enabled and disabling the rest by default.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 182 +++++++++++++++++++++
>>   1 file changed, 182 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> index 26dc3776f911..8c3efe066803 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> @@ -1576,4 +1576,186 @@
>>   			      <695>;
>>   		bootph-pre-ram;
>>   	};
>> +
>> +	watchdog0: watchdog@2200000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x2200000 0x00 0x100>;
>> +		clocks = <&k3_clks 348 1>;
>> +		power-domains = <&k3_pds 348 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 348 0>;
>> +		assigned-clock-parents = <&k3_clks 348 4>;
>> +	};
>> +
>> +	watchdog1: watchdog@2210000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x2210000 0x00 0x100>;
>> +		clocks = <&k3_clks 349 1>;
>> +		power-domains = <&k3_pds 349 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 349 0>;
>> +		assigned-clock-parents = <&k3_clks 349 4>;
>> +	};
>> +
>> +	watchdog2: watchdog@2220000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x2220000 0x00 0x100>;
>> +		clocks = <&k3_clks 350 1>;
>> +		power-domains = <&k3_pds 350 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 350 0>;
>> +		assigned-clock-parents = <&k3_clks 350 4>;
>> +	};
>> +
>> +	watchdog3: watchdog@2230000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x2230000 0x00 0x100>;
>> +		clocks = <&k3_clks 351 1>;
>> +		power-domains = <&k3_pds 351 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 351 0>;
>> +		assigned-clock-parents = <&k3_clks 351 4>;
>> +	};
>> +
>> +	watchdog4: watchdog@2240000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x2240000 0x00 0x100>;
>> +		clocks = <&k3_clks 352 1>;
>> +		power-domains = <&k3_pds 352 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 352 0>;
>> +		assigned-clock-parents = <&k3_clks 352 4>;
>> +	};
>> +
>> +	watchdog5: watchdog@2250000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x2250000 0x00 0x100>;
>> +		clocks = <&k3_clks 353 1>;
>> +		power-domains = <&k3_pds 353 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 353 0>;
>> +		assigned-clock-parents = <&k3_clks 353 4>;
>> +	};
>> +
>> +	watchdog6: watchdog@2260000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x2260000 0x00 0x100>;
>> +		clocks = <&k3_clks 354 1>;
>> +		power-domains = <&k3_pds 354 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 354 0>;
>> +		assigned-clock-parents = <&k3_clks 354 4>;
>> +	};
>> +
>> +	watchdog7: watchdog@2270000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x2270000 0x00 0x100>;
>> +		clocks = <&k3_clks 355 1>;
>> +		power-domains = <&k3_pds 355 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 355 0>;
>> +		assigned-clock-parents = <&k3_clks 355 4>;
>> +	};
>> +
>> +	watchdog16: watchdog@2300000 {
>> +		status = "disabled";
> 
> This is a friendly reminder during the review process.
> 
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.

Apologies. I have fixed the order in v6.

> 
> Thank you.
> 
> Best regards,
> Krzysztof
>