Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2540108rdh; Wed, 27 Sep 2023 05:57:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGifrBodtXgdQK8vxj81N+N/nO3kdaZWpl9unpRkzuSpbRBr1JnNcib9b4QQovx6S3B900N X-Received: by 2002:a17:90a:f193:b0:271:9237:a07f with SMTP id bv19-20020a17090af19300b002719237a07fmr1600778pjb.32.1695819472984; Wed, 27 Sep 2023 05:57:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695819472; cv=none; d=google.com; s=arc-20160816; b=Avk1xTp44D9Psmf+tuGFvY+Z863vv75E/FLXN88+2QuLujosHP++fbZSJrDV5L2tEv EecIpZ6DSJovCZjOY1+28/I5lyEfyLFNSr826fBGozKWDR1DPgECxiVccAoTnoa5nA6I Rjt73+UnGvwV2P5kRsQ/ZEQNBQrWxubX3nfzJsafZOt+smJpZyh9ThYaXCZkQq7MZCFg V6TK+3bgrAeUAYw4oSNpJhW4aVQlShGDq8Y1GH8z4HipBvxn1HilYTiSMLPN3wvzKY8J w1s7uzL38OHlM3tvaGr10zHGRa8ywst3cQ8qsubclDupKfaCL6NqFk++UN3Ne9Hya1xF O4JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:subject:cc:to:from:message-id:date :dkim-signature; bh=7NrmC5pcFzp/76ziw8W5fSNzwvgLppzIHB7W1pRJs0A=; fh=i7DQetGfDsfWYXohCb4E5ZTXE/R/ityVAbXNGIxurAo=; b=0iir4OqNV8RHviHiC1N/FmrSCZc3iEztOLRSon6UPnJUoguQZLOd+VrA04hSkelEQX /U5PZnwxoZlR5TT5aoFpsuofR3lgVA30iwFrOuiBPSxe5tu4ax+DbZaTnQ3mz5y6tj7w eRuxjR+OhOhZCkpLCpOow5O9SPVUCnVbunF+vY62mvq7cbEcXktwgVWj1izrBMxBldvg 41QfpznZjIhcmN40NceWVtEasO9EDDxc0UYCBVxWEJpDg9R26/DW1e15RFBWiFNleXl7 VRskE6GUxArkF5ljDA6qJ/HZij7LQQ/iFeoIWFWMRdlJXwl3uUS35J+KMnROnylu3QXC aeAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZIGUe8uZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id i11-20020a17090a974b00b00271af83a25asi3850975pjw.59.2023.09.27.05.57.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 05:57:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZIGUe8uZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 05AEC82976A5; Wed, 27 Sep 2023 04:19:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231377AbjI0LTa (ORCPT + 99 others); Wed, 27 Sep 2023 07:19:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230494AbjI0LT3 (ORCPT ); Wed, 27 Sep 2023 07:19:29 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4309F3; Wed, 27 Sep 2023 04:19:28 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6c4d625da40so4985805a34.1; Wed, 27 Sep 2023 04:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695813567; x=1696418367; darn=vger.kernel.org; h=in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=7NrmC5pcFzp/76ziw8W5fSNzwvgLppzIHB7W1pRJs0A=; b=ZIGUe8uZwAkEpydsBO+KnIXGnzxGvp+YYsFbm9t1R/wdjlSa/Sip7AdEiIRC4445vs EIa+LtA/V6bq2O/KyHLAwlGURYhrYRqo6/NHRPvLTYpoTcxCyv8Z0bW9fkdNMCMxEH3K KSmWQJq7qyOAeV/oHOqJlxt6Yi5Hr64CMHsJ6TO6tlH8KMsyy4nQLXxImXotsO5T5wqv cUxmVgL4Cruoc7jUgvU2YNG67169EZOXaqRxsTc3QctQGbNQdLKJORfA5CNMbi0edXYN CyXvRuyl1r9FBUJWO01jBbAYy11263IbOIuZ4vePj2Klb6Chec92DcaUlYG30cxh2Idg Xb6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695813567; x=1696418367; h=in-reply-to:subject:cc:to:from:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7NrmC5pcFzp/76ziw8W5fSNzwvgLppzIHB7W1pRJs0A=; b=flWnEy3tjh52GCvt+NOplxuVhcTGwNsoy2P9YTwyxP45ejrPckdkE4emp/Y6DHNenF pRLT1p0U1JIsaXx1b0/FWB2W00hWVthC9yVQI8at/A3JElGslwAVgjMWw3mnB/JPHie4 k+TsOuBRIEfAKrbNlXJJ2InTFuz4G5bFxQHoFnt/bgEn+y3TNvqXLiKT03j6F1l0LyDf odUwTNRQOrDRCVMbgUXVihNCQMAnWX2rY/OlnXW4KK2VJe8yX0YVBTfDYad3THjSna/q BqLv8e+Pnvwg4rxh2f6bJCkNw+nKl/G8NlN9914gzl0WBUGepzEuBx0GrZPBN+NcNHw3 hViw== X-Gm-Message-State: AOJu0YwqjtXBAs4erJ9J5xlt5vcKZQnTd07i6N1B4EC04LrMwSYFXitD xuYc+YjPxEgmZ5wSH8Rb632n6Fej/KY= X-Received: by 2002:a9d:7f8c:0:b0:6b7:518a:1672 with SMTP id t12-20020a9d7f8c000000b006b7518a1672mr1679826otp.34.1695813567403; Wed, 27 Sep 2023 04:19:27 -0700 (PDT) Received: from dw-tp ([49.207.223.191]) by smtp.gmail.com with ESMTPSA id i13-20020aa78d8d000000b00689f8dc26c2sm11499968pfr.133.2023.09.27.04.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 04:19:26 -0700 (PDT) Date: Wed, 27 Sep 2023 16:49:23 +0530 Message-Id: <87fs2zg8xw.fsf@doe.com> From: Ritesh Harjani (IBM) To: Kemeng Shi , tytso@mit.edu, adilger.kernel@dilger.ca Cc: ojaswin@linux.ibm.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 09/12] ext4: call ext4_mb_mark_context in ext4_group_add_blocks() In-Reply-To: <20230919201532.310085-10-shikemeng@huaweicloud.com> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 27 Sep 2023 04:19:42 -0700 (PDT) Kemeng Shi writes: > Call ext4_mb_mark_context in ext4_group_add_blocks() to remove repeat code. > > Signed-off-by: Kemeng Shi > --- > fs/ext4/mballoc.c | 82 ++++++----------------------------------------- > 1 file changed, 10 insertions(+), 72 deletions(-) > Looks good to me. Please feel free to add - Reviewed-by: Ritesh Harjani (IBM)