Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <d799f653-e00c-43be-9487-381a8ef4c849@linaro.org>
Date:   Wed, 27 Sep 2023 13:03:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RESEND PATCH v6 17/17] media: qcom: camss: Comment CSID dt_id
 field
Content-Language: en-US
To:     Hans Verkuil <hverkuil@xs4all.nl>, linux-arm-msm@vger.kernel.org,
        linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
        rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org,
        andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org,
        sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org
Cc:     linux-kernel@vger.kernel.org
References: <20230925154707.837542-1-bryan.odonoghue@linaro.org>
 <20230925154707.837542-18-bryan.odonoghue@linaro.org>
 <cf7cdafb-ccd1-42ee-9c67-5e6600f752f7@xs4all.nl>
From:   Bryan O'Donoghue <bryan.odonoghue@linaro.org>
In-Reply-To: <cf7cdafb-ccd1-42ee-9c67-5e6600f752f7@xs4all.nl>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/09/2023 12:42, Hans Verkuil wrote:
>> +		/*
>> +		 * DT_ID is a two bit bitfield that is concatenated with
>> +		 * the four least significant bits of the six bit VC
>> +		 * bitfield to generate an internal CID value.
>> +		 *
>> +		 * CSID_RDI_CFG0(vc)
>> +		 * DT_ID : 28:27
>> +		 * VC    : 26:22
> This is 5 bits, not 6 bits as the comment above says. Which is right?

Yes you're right I had "DT" which is six bits in my head when I wrote 
this. The VC bitfield is five.

> 
>> +		 * DT    : 21:16
>> +		 *
>> +		 * CID   : VC 3:0 << 2 | DT_ID 1:0
>> +		 */
>>   		u8 dt_id = vc;
> So if dt_id is 2 bits, and vc can be more than 2 bits in the future,
> shouldn't this read "vc & 3"?

Hmm...

val |= dt_id << RDI_CFG0_DT_ID;

yes that would overrun otherwise.

---
bod