Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <850d1c1b6ef41cd039cec2fe0e67437d80856f14.camel@linux.intel.com>
Subject: Re: [PATCH 05/11] platform/x86:intel/pmc: Move get_low_power_modes
 function
From:   "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To:     Ilpo =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        platform-driver-x86@vger.kernel.org, rajvi.jingar@linux.intel.com
Date:   Tue, 26 Sep 2023 17:16:14 -0700
In-Reply-To: <a790e9e7-2748-5d2f-a035-20ef42ca87a2@linux.intel.com>
References: <20230922213032.1770590-1-david.e.box@linux.intel.com>
         <20230922213032.1770590-6-david.e.box@linux.intel.com>
         <a790e9e7-2748-5d2f-a035-20ef42ca87a2@linux.intel.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-09-26 at 18:56 +0300, Ilpo J=C3=A4rvinen wrote:
> On Fri, 22 Sep 2023, David E. Box wrote:
>=20
> > From: Xi Pardee <xi.pardee@intel.com>
> >=20
> > Some platforms will have a need to retrieve the low power modes as part=
 of
> > their driver initialization. As such, make the function global and call=
 it
> > from the platform specific init code.
>=20
> What is the real justification for this change, I don't think it's clearl=
y=20
> stated above?

It needs to be moved from core code to platform init code so that (in patch=
 9)
we can get the entry requirement list for the enabled modes, which won't be
known before this function is ran. I'll update the changelog.