Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <16cc3132-9d2c-04de-51b6-88e4476b4d26@redhat.com>
Date:   Wed, 27 Sep 2023 09:08:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH net-next 7/9] i40e: Move memory allocation structures to
 i40e_alloc.h
Content-Language: en-US
To:     Przemek Kitszel <przemyslaw.kitszel@intel.com>,
        netdev@vger.kernel.org
Cc:     poros@redhat.com, mschmidt@redhat.com, jesse.brandeburg@intel.com,
        anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org,
        edumazet@google.com, pabeni@redhat.com,
        intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
References: <20230926182710.2517901-1-ivecera@redhat.com>
 <20230926182710.2517901-8-ivecera@redhat.com>
 <f17ed43b-7329-5566-a75e-befebd20d032@intel.com>
From:   Ivan Vecera <ivecera@redhat.com>
In-Reply-To: <f17ed43b-7329-5566-a75e-befebd20d032@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 26. 09. 23 21:57, Przemek Kitszel wrote:
> On 9/26/23 20:27, Ivan Vecera wrote:
>> Structures i40e_dma_mem & i40e_virt_mem are defined i40e_osdep.h while
>> memory allocation functions that use them are declared in i40e_alloc.h
>> Move them to i40e_alloc.h and remove this header file dependency on
>> i40e_osdep.h header.
>>
>> Due to removal of this dependency we have to include i40e_osdep.h in 
>> files
>> that requires it.
>>
>> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>> ---
>>   drivers/net/ethernet/intel/i40e/i40e_adminq.c |  1 +
>>   drivers/net/ethernet/intel/i40e/i40e_adminq.h |  2 +-
>>   drivers/net/ethernet/intel/i40e/i40e_alloc.h  | 21 ++++++++++++++++++-
>>   drivers/net/ethernet/intel/i40e/i40e_common.c |  1 +
>>   drivers/net/ethernet/intel/i40e/i40e_dcb.c    |  1 +
>>   drivers/net/ethernet/intel/i40e/i40e_diag.c   |  1 +
>>   drivers/net/ethernet/intel/i40e/i40e_hmc.c    |  1 +
>>   drivers/net/ethernet/intel/i40e/i40e_hmc.h    |  2 +-
>>   .../net/ethernet/intel/i40e/i40e_lan_hmc.c    |  1 +
>>   drivers/net/ethernet/intel/i40e/i40e_nvm.c    |  1 +
>>   drivers/net/ethernet/intel/i40e/i40e_osdep.h  | 19 -----------------
>>   11 files changed, 29 insertions(+), 22 deletions(-)
> 
> I very much like this series, but extending i40e_osdep.h usage asks for 
> comment ???? - please try to reorder patches to have less dependency on it 
> first, and afterwards do split
> (IOW first remove&reduce, then split what's left)
> 
> (disclaimer: I have not double checked if that's possible)

I will move the patch 5 after i40e_osdep split and memory allocation 
clean-up patches. This should simplify the changes.

Thanks for comment...

Ivan