Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
References: <20230927072544.764285-1-Rong.Chen@amlogic.com>
 <202309271651027503622@amlogic.com>
User-agent: mu4e 1.8.13; emacs 29.1
From:   Jerome Brunet <jbrunet@baylibre.com>
To:     "Rong.Chen@amlogic.com" <Rong.Chen@amlogic.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     linux-mmc <linux-mmc@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-amlogic <linux-amlogic@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: meson-gx: Remove setting of CMD_CFG_ERROR
Date:   Wed, 27 Sep 2023 11:30:37 +0200
In-reply-to: <202309271651027503622@amlogic.com>
Message-ID: <1jil7wkl39.fsf@starbuckisacylon.baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On Wed 27 Sep 2023 at 16:51, "Rong.Chen@amlogic.com" <Rong.Chen@amlogic.com=
> wrote:

> Hi Jerome,
>
> Socs containing previous controllers are gxl, gxm, gxbb=EF=BC=8Cg12b=EF=
=BC=8Cg12a=EF=BC=8Csm1=EF=BC=8Caxg, a1=EF=BC=8Cs4 and t7.

That is mostly all the SoC we know of in mainline ... This why the way
you explained is confusing.

And below, you say 'on latest controllers', okay but which ones ?

> The bit CMD_CFG_ERROR is used for selecting SG LINK of data address on la=
test controllers=EF=BC=8Cbut
> data address don't use SG LINK at present=EF=BC=8Cso it will cause an IRQ=
 and stop working on latest controllers.
> Therefore, remove this setting.

Not totally sure what SG LINK but okay.

While the change itself is fine you really need reformulate the description.
Based on your explanation, something like:
---
For the t7 and older SoC families, the CMD_CFG_ERROR has no effect.
Starting from SoC family XYZ, it will select SG LINK on error but this
is causing a problem with the data address ... blablabla
---

Please expand a bit on this, try to make it clearer.
Also, please insert the proper fixes tag

Last, make sure tp reply with plain text emails, otherwise lists will
drop your reply and please do not top post.

Thx

>
> Thanks.
> -------------------------------------------------------------------------=
------------------------------------------------
> Rong.Chen@amlogic.com
>
>=20=20=20
>  From: Jerome Brunet
>  Date: 2023-09-27 15:43
>  To: Rong.Chen; Ulf Hansson; Neil Armstrong; Kevin Hilman; Martin Blumens=
tingl
>  CC: linux-mmc; linux-arm-kernel; linux-amlogic; linux-kernel
>  Subject: Re: [PATCH] mmc: meson-gx: Remove setting of CMD_CFG_ERROR
>  [You don't often get email from jbrunet@baylibre.com. Learn why this is =
important at
>  https://aka.ms/LearnAboutSenderIdentification ]
>=20=20=20
>  [ EXTERNAL EMAIL ]
>=20=20=20
>  s
>  On Wed 27 Sep 2023 at 15:25, "Rong.Chen" <Rong.Chen@amlogic.com> wrote:
>=20=20=20
>  > From: Rong Chen <rong.chen@amlogic.com>
>  >
>  > Setting bit CMD_CFG_ERROR has non effects on previous controllers.
>=20=20=20
>  Which previous controllers ? v2, v3 ? Can you list the SoCs please ?
>=20=20=20
>  > However, it will cause an IRQ and stop working on latest controllers,
>=20=20=20
>  Isn't it desirable to stop on error ? seems like a sane thing to do.
>=20=20=20
>  > This bit is used for selecting SG LINK of data address.
>  > Don't set the bit CMD_CFG_ERROR anymore to resolve this issuse.
>=20=20=20
>  I'm not sure I understand the actual issue being resolved.
>  Could you provide more details please ?
>=20=20=20
>  >
>  > Therefore, remove this setting.
>  >
>  > Signed-off-by: Rong Chen <rong.chen@amlogic.com>
>  > ---
>  >  drivers/mmc/host/meson-gx-mmc.c | 1 -
>  >  1 file changed, 1 deletion(-)
>  >
>  > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-=
gx-mmc.c
>  > index 9837dab096e6..c7c067b9415a 100644
>  > --- a/drivers/mmc/host/meson-gx-mmc.c
>  > +++ b/drivers/mmc/host/meson-gx-mmc.c
>  > @@ -801,7 +801,6 @@ static void meson_mmc_start_cmd(struct mmc_host *m=
mc, struct mmc_command *cmd)
>  >
>  >       cmd_cfg |=3D FIELD_PREP(CMD_CFG_CMD_INDEX_MASK, cmd->opcode);
>  >       cmd_cfg |=3D CMD_CFG_OWNER;  /* owned by CPU */
>  > -     cmd_cfg |=3D CMD_CFG_ERROR; /* stop in case of error */
>  >
>  >       meson_mmc_set_response_bits(cmd, &cmd_cfg);