Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Wed, 27 Sep 2023 14:02:19 +0300
From:   kirill.shutemov@linux.intel.com
To:     Binbin Wu <binbin.wu@linux.intel.com>
Cc:     dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org,
        shuah@kernel.org, linux-kselftest@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, weihong.zhang@intel.com
Subject: Re: [PATCH] selftests/x86/lam: Zero out buffer for readlink()
Message-ID: <20230927110219.b5n3fbbwrxtcwtzp@box.shutemov.name>
References: <20230923233346.12726-1-binbin.wu@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230923233346.12726-1-binbin.wu@linux.intel.com>
Precedence: bulk

On Sun, Sep 24, 2023 at 07:33:46AM +0800, Binbin Wu wrote:
> Zero out the buffer for readlink() since readlink() does not append a
> terminating null byte to the buffer.
> 
> Fixes: 833c12ce0f430 ("selftests/x86/lam: Add inherit test cases for linear-address masking")
> 
> Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com>
> ---
>  tools/testing/selftests/x86/lam.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/x86/lam.c
> index eb0e46905bf9..9f06942a8e25 100644
> --- a/tools/testing/selftests/x86/lam.c
> +++ b/tools/testing/selftests/x86/lam.c
> @@ -680,7 +680,7 @@ static int handle_execve(struct testcases *test)
>  		perror("Fork failed.");
>  		ret = 1;
>  	} else if (pid == 0) {
> -		char path[PATH_MAX];
> +		char path[PATH_MAX] = {0};

Shouldn't it be PATH_MAX+1 to handle the case when readlink(2) stores
exactly PATH_MAX bytes into the buffer?

>  
>  		/* Set LAM mode in parent process */
>  		if (set_lam(lam) != 0)
> 
> base-commit: ce9ecca0238b140b88f43859b211c9fdfd8e5b70
> -- 
> 2.25.1
> 

-- 
  Kiryl Shutsemau / Kirill A. Shutemov