Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Wed, 27 Sep 2023 08:44:46 +0200
From:   Herve Codina <herve.codina@bootlin.com>
To:     Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,
        linuxppc-dev@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH 06/40] soc/fsl: cpm: qmc: Convert to platform remove
 callback returning void
Message-ID: <20230927084446.66affc74@bootlin.com>
In-Reply-To: <20230925095532.1984344-7-u.kleine-koenig@pengutronix.de>
References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de>
        <20230925095532.1984344-7-u.kleine-koenig@pengutronix.de>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 25 Sep 2023 11:54:57 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/soc/fsl/qe/qmc.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index b3c292c9a14e..92ec76c03965 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -1415,7 +1415,7 @@ static int qmc_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> -static int qmc_remove(struct platform_device *pdev)
> +static void qmc_remove(struct platform_device *pdev)
>  {
>  	struct qmc *qmc = platform_get_drvdata(pdev);
>  
> @@ -1427,8 +1427,6 @@ static int qmc_remove(struct platform_device *pdev)
>  
>  	/* Disconnect the serial from TSA */
>  	tsa_serial_disconnect(qmc->tsa_serial);
> -
> -	return 0;
>  }
>  
>  static const struct of_device_id qmc_id_table[] = {
> @@ -1443,7 +1441,7 @@ static struct platform_driver qmc_driver = {
>  		.of_match_table = of_match_ptr(qmc_id_table),
>  	},
>  	.probe = qmc_probe,
> -	.remove = qmc_remove,
> +	.remove_new = qmc_remove,
>  };
>  module_platform_driver(qmc_driver);
>  

Acked-by: Herve Codina <herve.codina@bootlin.com>

Best regards,
Hervé