Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <36e02c1f-fecf-f6c0-3baa-96fa15e6327d@intel.com>
Date:   Tue, 26 Sep 2023 14:39:49 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v2 3/6] selftests/resctrl: Move _GNU_SOURCE define into
 Makefile
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        <linux-kselftest@vger.kernel.org>,
        =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        <stable@vger.kernel.org>
References: <20230915154438.82931-1-ilpo.jarvinen@linux.intel.com>
 <20230915154438.82931-4-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230915154438.82931-4-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkRTU1piekFueTZKbVorOTNYT2V6U0NBczBxY2gzRWtRSTVVQkhJNGorUnd0?=
 =?utf-8?B?MU8wWjhwN1I0dkJJU092MmMxa29XZlF2eUFDZ28zeE90blM0R1Q5RnNCdklH?=
 =?utf-8?B?QjFNZUNVY2tFVTVwV2lFNkZodHppNklCa25FVENaT3IweU00dzJqSTdTaUlk?=
 =?utf-8?B?RTAzS2VJdk13eGQ2OW5uajJkVWs3T3RsWmpXUUgvdXVSZ3g2ekZnRnZCSmdr?=
 =?utf-8?B?QnRXMm96RDdzdXVWeU16Yno1eXM1L1Ztc1RvY1RRcFU1SkRWV3pyeEpuTFpi?=
 =?utf-8?B?Qk9CRXVhRTQ5Q0R2Rmh6VlBHRkhWZ0NEQnVVNHZHbmFuNTlpWjJvdDk2TzVr?=
 =?utf-8?B?ZG5xWkZCTEVKQjA4UWRHUDhOUVF1ZlhkN3B1TkJTcmZya0xLWW9vVktSZ09M?=
 =?utf-8?B?M1psVG1IbTVLU0tKbHErZUFZYU1MMU1tUTU4NnFHNTQ2bGk1NUpnRWtEZW0v?=
 =?utf-8?B?VTRXM2dCTzV2RzV2VW5CdEMzV1VTaDJpSEo3aC9jb09TbFJXUC9vZU5RTE80?=
 =?utf-8?B?TjFYb016ZVE2UWMxY3dObkU4MFJSNlBkazU0QzcyeUtpbnFMWU5yd3Jsd0Fl?=
 =?utf-8?B?eDQ3cWFQUVNJOThFcmdmREJOZTlPT1RJUWIwVlptZmxGVHYzN1BXd0ZVNHpl?=
 =?utf-8?B?b3J5Mi9iVjgzTUZCRzh2TXpFZWdHSE5JTktkQW5peG9abkE1WjV5b3JKR1dz?=
 =?utf-8?B?b0ZUOTdZdnJkWUZVSkJrd0tvcStyakxwc2FIUzUyMldSalNEUFpJZWg1d1V1?=
 =?utf-8?B?bk1hSWxTdENZVEhZR0JCa2JLUUpRNThpNjNMUWJKb1VreFNRa3hBakMyRWtw?=
 =?utf-8?B?V1V5Q3AzNCtFMGVqbzE0djhhdnUwVEUwa01wdXpmdlphaGVxWCtnZXZhV1li?=
 =?utf-8?B?bzQ5RytkLzhuSC9ac2FkVi8zNS9sRFhMZTZqWFpkdnIvb0FPTmtpWlBCT3RP?=
 =?utf-8?B?MC9FV2x6dUVocmN1NG1DQzlxd0lpNEEybTdodDJabmVFVXh5V1NBZERyZXM2?=
 =?utf-8?B?THBzQ3VPYWRMZkgzNUV6UWVTMk4rMlNqNW1pSThSN3Rrb3hWNVNhR1dmblI0?=
 =?utf-8?B?T2s5SnI4VU81U1pEaWpoODN6MFRZMi8zb2RyVVd2Q0ZQbmZxME1oMzFiVDRE?=
 =?utf-8?B?MGlCZzJSNjhDM3drQWJKcmtZcEFleUhrSS9iTDR6QkhQTlhFZ1ExOVJuNmx3?=
 =?utf-8?B?NDN0SkNWa1JnTkw1WWR5dlVnZE14bWpNUEw4NHF5ZVNLTitRaFp4N1ZSRks2?=
 =?utf-8?B?d0RWd0dMWk5mVGpPdmZHdXhZOHhxUEtzM2RodFVHSC9NL0E5TWhJNFhmUE5Q?=
 =?utf-8?B?anZJTXFoRGlpZlZVNW9EQ1UySkZHRGpNRFprTG9IOVdqRzM2eHJra0FSQUFU?=
 =?utf-8?B?YVcrbnRVbzVTYXNUZ3pQbFB2bnZFbm9ScERQL01sNnExTHRGdHE5dkx0bW1D?=
 =?utf-8?B?UDB6eVpkMXVYaHdaQ0lPTFNHOGdDWnBJcnhVWS9uNkoyNWZLYzhmWVBCNGo5?=
 =?utf-8?B?N0xEWjFTb21tcHVFcHhqQmRrTjNkTU9rZjdvK3dJanloK3RxazVIYXNFdFA0?=
 =?utf-8?B?akluVE5QM2JhTXkwL1llOXdMQ0lPR1BTQUQ4eWFyZVRmc1dmRXdvV01XZXMv?=
 =?utf-8?B?L1VpSVlWSTBoREE4d25qMHlzQkhlTEhxWTc5Smx0RUNBR2p6dVJ2OGdmY29X?=
 =?utf-8?B?T2ZGZHZaeXZ3bkx0aHNnSE9QQk1BSE9pQkhVU3dTOUV1aTMxWG81VVZsMCtl?=
 =?utf-8?B?V0hhT213TmxCRnErNUp2cWJqWUoxSnNmZWdjbWRtZlFWU0kwT2NMaW13VVpD?=
 =?utf-8?B?UlVreHlKMGNzMEIxYTBHTkdBMHQwbGtkM0tYTWprV2gwN1hqTE9UQlR5OFEy?=
 =?utf-8?B?YW9BZ2djYk1NaVJpVlFEa1lRdFdFSFZKbDZ5NU9uZjV2MXFIQnBLc0FxeThE?=
 =?utf-8?B?UkJnTVh2MjNBUy9rYkVTS1d4MWk5VlhoOEtLSjRlWXlxdjJmZ1YrNjJxWlNK?=
 =?utf-8?B?RVA4aWJYOG5qQlV2cHc4V0pJMmFoeVZ0WnhJQVpzTFErOStZNllxMFFCUGVW?=
 =?utf-8?B?d3hDVU1YMkd3bnI5Z091dDNxMTloY0dlK0VpU0ExM0pxT2Fqc21lU2phS0hy?=
 =?utf-8?B?by9oZnVRcE1ZZEVaVW5keU1FZFRYL2hDVTMyMDNYSVpMb3l3cmU1M2pmR3c5?=
 =?utf-8?B?N3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f4bea5b1-18d3-42b8-277f-08dbbed91dff
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 21:39:52.4536
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PVraXTbQSCEyDDoE+V0m/B7jR9u1YZ9C/Y7iaKjBlE7584hwleyIzGTlpA+ofBjfaAnkbg3T66AgRtWzgBvtLx80DBcomE6DPiz9AiyX5Gc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5131
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 26 Sep 2023 22:32:47 -0700 (PDT)

Hi Ilpo,

On 9/15/2023 8:44 AM, Ilpo Järvinen wrote:
> Currently, _GNU_SOURCE is defined in resctrl.h. Defining _GNU_SOURCE

nitpick: If you do submit a new version, could you please drop the
"Currently".

> has a large impact on what gets defined when including headers either
> before or after it. This can result in compile failures if .c file
> decides to include a standard header file before resctrl.h.
> 
> It is safer to define _GNU_SOURCE in Makefile so it is always defined
> regardless of in which order includes are done.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Cc: <stable@vger.kernel.org>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette