Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <b4b96520-2d23-9102-09c0-802cedaa70fb@intel.com>
Date:   Wed, 27 Sep 2023 08:22:38 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v5 3/8] x86/resctrl: Split the rdt_domain structure
Content-Language: en-US
To:     "Luck, Tony" <tony.luck@intel.com>
CC:     "Yu, Fenghua" <fenghua.yu@intel.com>,
        Peter Newman <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>,
        "x86@kernel.org" <x86@kernel.org>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
References: <20230722190740.326190-1-tony.luck@intel.com>
 <20230829234426.64421-1-tony.luck@intel.com>
 <20230829234426.64421-4-tony.luck@intel.com>
 <5f1256d3-737e-a447-abbe-f541767b2c8f@intel.com>
 <ZRMnCFWzcxa6Qa4E@agluck-desk3>
 <5b2fd31e-3cef-3c35-7d17-411cea27502a@intel.com>
 <SJ1PR11MB6083D9AA22033235210BD847FCC3A@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <595d6062-fece-83c0-5d5d-2f9405f6b842@intel.com>
 <SJ1PR11MB6083210E470189053CCD1F70FCC2A@SJ1PR11MB6083.namprd11.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <SJ1PR11MB6083210E470189053CCD1F70FCC2A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTBSK3pjSWlaNEVGRC9HbDQvclliRnJzMXJ6dWRNQzk5NlhOekxzMEd4OC9E?=
 =?utf-8?B?SVR1ZVc5K0FaWWxMOHlqOG02MEFzRFZYUFhrYldnbHk3Nkw4a3dxRlRVZnBJ?=
 =?utf-8?B?TmZMekM0ZCtCSWhuc0NRN2tIYWRzd0lHbHVwT3lUVWFNaE1SRUswTlZob3Bw?=
 =?utf-8?B?UmpyejZJZmNSSGJzSXhMdWViYklTV0psWFJrVWg1OFM0RVYyZXROUGdFMHp0?=
 =?utf-8?B?SXRJRjVBV1R3eHNPYllpYllVMlhSQUwwbEs0eGIzZ28wdVhLbUEwa2V1anB2?=
 =?utf-8?B?SitWVEZIelFTWFgzenFwVGFCWHU0UzNQUzZkc25admxrZFc4TloxOXNYRUhr?=
 =?utf-8?B?NlFHS3pQZ3ZUYXNrR0RTNEM3LzZ1a245cWdqRGFhQ2I5Z1BDTjhZbXlKU1Jp?=
 =?utf-8?B?S3FzTy9aYW4wRG5JQTVsVksydHo3MGo1b3kxL3c2djdBY0Z1UC9kNHFGZnQ3?=
 =?utf-8?B?dm9qV1dDRG01Vkl0RGpIT2dZTENuenFFSnZzcGtSVjFodjMwSkNXdzRYYTVV?=
 =?utf-8?B?YW1hajhTTXpSVjhZdW9GSWl5ckJ1WXhDRWdPRDhxWm5TQ3Q0dTdlRk43VXhO?=
 =?utf-8?B?NGNCNGFQZU8xQk9vYWp4MDE5bm9nRWRwMHN4ek9lNHVuekRreHlWY3RBci9j?=
 =?utf-8?B?WHVMMm9MUEFjTnhyb3E2N1FZcDR5RWxGMEQxNmNWc2lsZWw5dmJabnpBTnpN?=
 =?utf-8?B?eC9IY2xkRXFJOUVxMDdpTzBmV2ticG9PY0loOGcxZHptK29KbXNvZ1NPVUpZ?=
 =?utf-8?B?QVZsMjR2N1I3WUFoZmN5N3FnZjBrTE5EM1EydTNnRmYyckdOL0pRSmIxYlZH?=
 =?utf-8?B?RTZzNlJiRG1rVlF6T0x0SUJsYWx2bzZPTHRLbGliakhIK2J5cWo3QWwrWFJh?=
 =?utf-8?B?RUVEL3oxOWpRN1NxbHdrY3M3a0RXUkx2amxLVWJjNHBEUXFxU3BCTkg4Wm92?=
 =?utf-8?B?VjZ1d0tIZE1UakJIRjQvOC92czdvYWlNY0lsU3BZR0MzaURMOVFyd0VZK3JI?=
 =?utf-8?B?dWZKNGtZZUxuU29YVTlMd0FBbW84RERFTWVhSk1YVCsvMW1lZkZhdUtZdmFp?=
 =?utf-8?B?OUhsOXZpRG9CR2RuR2R6R0tVUHdYNU1Hb21mcDkwZHRwd3l6VjRlSXR0NC9V?=
 =?utf-8?B?WnRrK2ZPdzlIdnZ0SUJuVFJyMVRwN3dVeVg5RkgrMkErZThwTW9uL3JnTGg0?=
 =?utf-8?B?WThzeitlM05Rei9kbUN0YmlXbE40YlJTVnowb0RuSGFDNXJXS1hvZWhiNGxh?=
 =?utf-8?B?QXlkdjUvN2xPY3gzakdlOWpPTDNvZ0I0T09ValRSNEU4UkFIRWFJYW9NMlNr?=
 =?utf-8?B?eHlkdTVuTHlsZ1NGYkY0dUdyWm5LaVMxUGJ0OXhrbndQRlpHVjllM3F5eGpC?=
 =?utf-8?B?amx6TzBJQUVLY3M0d2w2R2VhT0xrUERISXY1dVV0RGJObUdnU3lTTXAzcnVm?=
 =?utf-8?B?b3hTR2ZBMEJuWjRQQmxoQ25sTFFUWGtEMjRiWU9ZSkZ2QzRKOVdaK1VtRnFH?=
 =?utf-8?B?SlpoMEI0S2RpbGJjUDNpb05NUUdVRmVyYXI5OG1iaE1QeThDbjgyMklvbXRm?=
 =?utf-8?B?L01NUE9xaGNKMjlCMjN6Z0gwSnMwRUh6Z3V0dU5Va2QvMlFtTEhGOEI3ZC9X?=
 =?utf-8?B?TWt6ajBXOUI5aElwbzI2TzRDdEQzWHo0bU5DZmsxcUY2SnFGeVJMMStJZjRT?=
 =?utf-8?B?Z1B5d0tnU3NxT0dhUUNzdXRDS1diNzRqZ01LT0dRQnQxOUIvcU92eEFyL3RS?=
 =?utf-8?B?THVkSGNrZlQ1ZHhmMEFycURwTkVURUVHQjRVaWxWZXNHL2xXNCtrT1pRQlNn?=
 =?utf-8?B?TVZPdEREbzU1a0VhNEpJM0xDbTdVcTZiUzUzSXlUNFVibmlrYlh4OWNvZ05z?=
 =?utf-8?B?b3FXcWVpQkJKV3JlN0Fhd1FhdW9UNWNhMnI3VXl3RmRYUXJYZVYyUXk4MjRm?=
 =?utf-8?B?SVJhaEc5SXpRd3lkbG9GeGp1VGlSK0R2UHVHMHQwZmVvUEU4Qm9XK3B3bU1I?=
 =?utf-8?B?Ny9rczlUNU5RdzRoSnNpTkNVRFZldlh6T2xrU2lnQ0w1TDRWamtJVnh5bXhy?=
 =?utf-8?B?bTFSU0lZQ2FOS1VpWGt6c3JTRkkvTGpEUjIzQ24zT3hNQ0RjbHorS3VsL3E1?=
 =?utf-8?B?VlM1Nkd2RHlwc1lYR250SU1ObklqK0JNdEMydUhJK250UUthZlE3YWhIZEdX?=
 =?utf-8?B?bUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 76415c17-2e0f-4e21-f5f2-08dbbf6d9786
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 15:22:41.9085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PkXbPtZSyrAVSFAlV/nmgbNRtMjje+QgESXBC4lOYhjG1cIOeMgud41avI/f7GJ3SvNL1enqxRmHu+VUbi4/QpUeyfkzI719hX72TNB5H5M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6742
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 27 Sep 2023 08:22:56 -0700 (PDT)

Hi Tony,

On 9/26/2023 5:00 PM, Luck, Tony wrote:
>> I expect you are right and your proposal makes the code cleaner.
>> Could the list_entry() call within rdt_find_domain() instead
>> extract a pointer to a struct rdt_domain_hdr? To me that would make
>> it most generic and avoid using wrong type for a pointer. I do think that
>> may have been what you intended by moving id in there though ...
> 
> Reinette,
> 
> Exactly my thoughts! The function currently looks like this
> (though I expect my mail client may mess up the formatting):
> 
> struct rdt_domain_hdr *rdt_find_domain(struct list_head *h, int id,
>                                        struct list_head **pos)
> {
>         struct rdt_domain_hdr *d;
>         struct list_head *l;
> 
>         if (id < 0)
>                 return ERR_PTR(-ENODEV);
> 
>         list_for_each(l, h) {
>                 d = list_entry(l, struct rdt_domain_hdr, list);
>                 /* When id is found, return its domain. */
>                 if (id == d->id)
>                         return d;
>                 /* Stop searching when finding id's position in sorted list. */
>                 if (id < d->id)
>                         break;
>         }
> 
>         if (pos)
>                 *pos = l;
> 
>         return NULL;
> }
> 
> and a typical caller does this:
> 
>         struct rdt_domain_hdr *hdr;
>         struct rdt_mon_domain *d;
> 
> 
> 
> 
>         hdr = rdt_find_domain(&r->mon_domains, id, &add_pos);
>         if (IS_ERR(hdr)) {
>                 pr_warn("Couldn't find monitor scope id=%d for CPU %d\n", id, cpu);
>                 return;
>         }
>         d = container_of(hdr, struct rdt_mon_domain, hdr);
> 

This looks very good to me. Thank you very much for creating a
solution that integrates well.

Reinette