Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Wed, 27 Sep 2023 16:13:30 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Sebastian Reichel <sre@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: power/supply: sbs-manager: Add missing
 unevaluatedProperties on child node schemas
Message-ID: <20230927-swimming-gender-3579e2771ffa@spud>
References: <20230926164446.101327-1-robh@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="vLhAzWIRrewJs9du"
Content-Disposition: inline
In-Reply-To: <20230926164446.101327-1-robh@kernel.org>
Precedence: bulk


--vLhAzWIRrewJs9du
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 26, 2023 at 11:44:42AM -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>=20
> Add unevaluatedProperties as needed, and then add any missing properties
> flagged by the addition.
>=20
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  .../devicetree/bindings/power/supply/sbs,sbs-manager.yaml   | 6 ++++++
>  1 file changed, 6 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/power/supply/sbs,sbs-manag=
er.yaml b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.ya=
ml
> index f255f3858d08..2e21846463ba 100644
> --- a/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml
> @@ -47,6 +47,12 @@ patternProperties:
>    "^i2c@[1-4]$":
>      type: object
>      $ref: /schemas/i2c/i2c-controller.yaml#
> +    unevaluatedProperties: false
> +
> +    properties:
> +      reg:
> +        minimum: 1
> +        maximum: 4
> =20
>  examples:
>    - |
> --=20
> 2.40.1
>=20

--vLhAzWIRrewJs9du
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZRRGmgAKCRB4tDGHoIJi
0gypAP0dN5ITkZ+G3bk0n/yF3+Z1vTnBZrJIUo0Jps5Tg7OMigD/adydJeyXH7Cf
C7uGu5/5p/xMHpKf7cDEplM8NlAJuQI=
=e37f
-----END PGP SIGNATURE-----

--vLhAzWIRrewJs9du--