Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   "Rong.Chen" <Rong.Chen@amlogic.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        Rong Chen <rong.chen@amlogic.com>
Subject: [PATCH] mmc: meson-gx: Remove setting of CMD_CFG_ERROR
Date:   Wed, 27 Sep 2023 15:25:44 +0800
Message-ID: <20230927072544.764285-1-Rong.Chen@amlogic.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NpAi/SeEKbM9mabdh6kMFyWnovR0DtZbU1uakkWufYXpCeOellVlmfqJJ8cR?=
 =?us-ascii?Q?6ZBnbpE6hyIe25KEkvvOQlZ1iCz3Y7GyVJFn4Kt/IzckOpih+cNwkAT+KHLQ?=
 =?us-ascii?Q?LXcJWK6heqv6EnMyp/yVNHv05aAvHWAVrH0ftF5lPCcM2VDKmFIHkE5s9C5D?=
 =?us-ascii?Q?E9WwcfPKorQPXLMQcmIDhYDkijuJS7j3YT5rgeHsf/sAr/yDx5zzkhNkOYjZ?=
 =?us-ascii?Q?Ler593t2Fod1LBhcyJjF4u8X3hJHwYsDL6ms67gwwC1wifeNj/WKYyxI99Jp?=
 =?us-ascii?Q?hRyk2WyHl1QjAOUeMjkDZtC0I/Zr9g89NWC26M2phI5cAYfH10FQ2/szrBWf?=
 =?us-ascii?Q?GcATj2XodVdQRQvFOLZtWST4XBcdB49WsnwX51xrXaPtpO9YNk3w+fLNKMDL?=
 =?us-ascii?Q?j784rBXHtAq/5gawhNlOGwdAvxYerT7kb++IyqYZzimn5L8DlQMl334Mf07a?=
 =?us-ascii?Q?juuCW1zViOyoalIO2nj6M7rLx1rtzwSF6QJp/AddLoFB4lUiO//ZgTLadL1N?=
 =?us-ascii?Q?jMGvsZ1jRvJqdBh8UnE5WZ3sD4iD7Cn57M1X6OiejWjXmMm0TzBbEwdQPgTi?=
 =?us-ascii?Q?N3xScVtSbgGeBuZSQ7Vid56btXWiLaHk48CBvJ1satbahA+rlnO6Z8bSrCPu?=
 =?us-ascii?Q?KbFMX8Bd9oCTRdjsb7XhNZ6g+Ueg4MAPbIRbxlhVdzbXjc/GZ/BozD+fO/ky?=
 =?us-ascii?Q?XSfsDz0wC45D0PUsMMGWJXg3K3Bgf4DGW2Pe0kPtCc0amH+hkImKGxes0/qv?=
 =?us-ascii?Q?jHPTieTuY4NjJ+iijU6RNlsDP40hiiogOVl0KDvDfW4wRZ54aulZcm+bWZSl?=
 =?us-ascii?Q?cwxcwiYVlgYQ76lP1OrAdcqjF48jfhDbKIVzib9f7UFyKYLxkolHz5JuVT3t?=
 =?us-ascii?Q?9yg6jk+W/mg4//eUuXxRyv6AYB25K2lpEpooYn7jlm9xXeGQd3Zm7p7HnoaI?=
 =?us-ascii?Q?OgaOX4w9r4xGT5v436xbICh9YzK87ftoqZifPnQ9ubrbqaS5Mwy3cWW/iLiu?=
 =?us-ascii?Q?S3dAesgPiSKNqOhOXZj4/fyVGGee6+ZpsvveevkggEz9hQRmFD295V3lh9RE?=
 =?us-ascii?Q?4h13l6jyzkyoTWM5WAHWtrdhyttotcT/KcUf5gKMp0a42TNIQvAvqfBEMUAC?=
 =?us-ascii?Q?kOFim3tf5Ph3GyRIq/9hXspRP2bCJNhCii2S/FO6fGlDnoPzuVwcQtfeBBRk?=
 =?us-ascii?Q?BnNaPyvwulgHwuOR75+4yS06gFQhekckrlwp+t8e5+mi99JUHWEiRdrKxv7q?=
 =?us-ascii?Q?hSXyYCzPO4EgRzydmmYLCsdAeSTVBWzh6YkzDBgaOt3F190Bj+peFoUG/6dz?=
 =?us-ascii?Q?HYgL/oIrmHOE46WWMsxY5/wu8MjQFfP+V760CI3S2+LaRfcNWeCrnF89XIHl?=
 =?us-ascii?Q?aEfIqQIywEXDw+Zdd4U0nXQB6FDWH9z/YRHeBcvA7ier0Ob9DCi2HYlFExbW?=
 =?us-ascii?Q?yShbKsV/7WMXlIb5nLQ82bQKsrH100tvOrov3Q5slS9Thc5v8WjqGNoOq5tz?=
 =?us-ascii?Q?m2LhxLpASxGsP6ZBQwf4lfcs5AjxnD4kcJ1pdfuBxeMBTBFFsUcnuvQv0F4H?=
 =?us-ascii?Q?Esbxta3LfpFe4LKOLVSGuLWdeYXvwwGDvjy3Adzm?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7e97300-c08b-483d-ef0d-08dbbf2b001d
X-MS-Exchange-CrossTenant-AuthSource: SI2PR03MB5943.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 07:26:01.1839
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: upaKkhx0dnXsproctZ2sEdjnpiUNiyR9EmzEbAutbbi9kJRKhoPBMWKcMszGynAfGromgP5GdRHihu/VRgGCpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR03MB7285
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 27 Sep 2023 00:27:07 -0700 (PDT)

From: Rong Chen <rong.chen@amlogic.com>

Setting bit CMD_CFG_ERROR has non effects on previous controllers.
However, it will cause an IRQ and stop working on latest controllers,
This bit is used for selecting SG LINK of data address.
Don't set the bit CMD_CFG_ERROR anymore to resolve this issuse.

Therefore, remove this setting.

Signed-off-by: Rong Chen <rong.chen@amlogic.com>
---
 drivers/mmc/host/meson-gx-mmc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 9837dab096e6..c7c067b9415a 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -801,7 +801,6 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd)
 
 	cmd_cfg |= FIELD_PREP(CMD_CFG_CMD_INDEX_MASK, cmd->opcode);
 	cmd_cfg |= CMD_CFG_OWNER;  /* owned by CPU */
-	cmd_cfg |= CMD_CFG_ERROR; /* stop in case of error */
 
 	meson_mmc_set_response_bits(cmd, &cmd_cfg);
 
-- 
2.42.0