Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-957-ga1ccdb4cff-fm-20230919.001-ga1ccdb4c
MIME-Version: 1.0
Message-Id: <9065720e-5a5c-428a-a28d-a3337ac31f85@app.fastmail.com>
In-Reply-To: <31585f93157c5c4487b53e3bcb6aac9e92e62f92.camel@linux.ibm.com>
References: <20230927072223.2555698-1-arnd@kernel.org>
 <31585f93157c5c4487b53e3bcb6aac9e92e62f92.camel@linux.ibm.com>
Date:   Wed, 27 Sep 2023 13:12:49 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Mimi Zohar" <zohar@linux.ibm.com>,
        "Arnd Bergmann" <arnd@kernel.org>,
        "Dmitry Kasatkin" <dmitry.kasatkin@gmail.com>
Cc:     "Paul Moore" <paul@paul-moore.com>,
        "James Morris" <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        "Jarkko Sakkinen" <jarkko@kernel.org>,
        "Nayna Jain" <nayna@linux.ibm.com>,
        "Eric Snowberg" <eric.snowberg@oracle.com>,
        "Tianjia Zhang" <tianjia.zhang@linux.alibaba.com>,
        "Randy Dunlap" <rdunlap@infradead.org>,
        "Oleksandr Tymoshenko" <ovt@google.com>,
        linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ima: rework CONFIG_IMA dependency block
Content-Type: text/plain
Precedence: bulk

On Wed, Sep 27, 2023, at 12:52, Mimi Zohar wrote:
> On Wed, 2023-09-27 at 09:22 +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> Changing the direct dependencies of IMA_BLACKLIST_KEYRING and
>> IMA_LOAD_X509 caused them to no longer depend on IMA, but a
>> a configuration without IMA results in link failures:
>> 
>> arm-linux-gnueabi-ld: security/integrity/iint.o: in function `integrity_load_keys':
>> iint.c:(.init.text+0xd8): undefined reference to `ima_load_x509'
>> 
>> aarch64-linux-ld: security/integrity/digsig_asymmetric.o: in function `asymmetric_verify':
>> digsig_asymmetric.c:(.text+0x104): undefined reference to `ima_blacklist_keyring'
>> 
>> Adding explicit dependencies on IMA would fix this, but a more reliable
>> way to do this is to enclose the entire Kconfig file in an 'if IMA' block.
>> This also allows removing the existing direct dependencies.
>> 
>> Fixes: be210c6d3597f ("ima: Finish deprecation of IMA_TRUSTED_KEYRING Kconfig")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Oleksandr Tymoshenko's patch to address this, made it into linux-next
> today.
>
> Commit be210c6d3597 ("ima: Finish deprecation of IMA_TRUSTED_KEYRING
> Kconfig") made it last night into linux-next.

No, that is the patch that caused the regression for me, since it
is missing the IMA dependencies.

    Arnd