Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <f6c4a6d8-0c3f-dbb1-17ca-3a594b456103@intel.com>
Date:   Wed, 27 Sep 2023 10:53:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH net-next v2 0/9] i40e: House-keeping and clean-up
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     <poros@redhat.com>, <mschmidt@redhat.com>,
        <jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
        <davem@davemloft.net>, <kuba@kernel.org>, <edumazet@google.com>,
        <pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,
        <linux-kernel@vger.kernel.org>
References: <20230927083135.3237206-1-ivecera@redhat.com>
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20230927083135.3237206-1-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0l6WVRlaEU3dTdLSFF1MG1TM2Y1WUlPU2dSNGZHcjkvb0tsT21xTWtsMllN?=
 =?utf-8?B?K20vT3IxMi9YL3FxV3cxU3BGZVQ5eFVKK3NpcVVEK3RxMnRMQTdGWEZta0Jn?=
 =?utf-8?B?dlBLVGFXcjFGVkpucUh2ZWorV0F1Y1I2eXpVYzNVN0lyR3p4NVVlQ0RBWmY1?=
 =?utf-8?B?R2FMV2s1YjM3MU5jbEpidlNnWGNhRHd5L2JUVmEwZVZDS05panNIcnpqSFM1?=
 =?utf-8?B?dXd5SkdoMldreEtReUpndnp1UUJXMlpBRDBZNGFhdmsycURFTmtQUmFOSFN2?=
 =?utf-8?B?Z0k1eVRvNW0yZ1Z3NkFjVG9nY2p3elA4a0toVHJVc1pidGpudzJacnIrdzVT?=
 =?utf-8?B?UlFDQnlHNWtPM0s4TytTTDU0NVo3ZktvVjFvK21rb0J0c3kwdlNoa0lEWElU?=
 =?utf-8?B?OVNjY3NQeFVVVndRSElOdDdKVTJNSE8rRzZuQ3dNK1IzbW5YMEVmaTNscThB?=
 =?utf-8?B?bms2bVBPUjNiQmpYR20yNzl4RE11L3BIVlVpRktJR045WjBubk1PVTRqUE13?=
 =?utf-8?B?RDN5OUdaVHFoRldqUFdzc0lEcnBBc0RGYnNnWWxuemgyVkpzc0tTOEE2alo4?=
 =?utf-8?B?b1FiYUZ1K2RUOWlLNW5MM3YrUmRMQzRKZWRGWGI4Y25SdmlZRkQ3dlpOaU5V?=
 =?utf-8?B?aXU4cXBIbzc2OVdmZHR5VUNVTXNVOVpiNWNrZ004bHRQK1FIQlI4MlArblJH?=
 =?utf-8?B?QjF3dlRITUFqTlFLODBoeDRtRmlzaUlhSHdneGUybVk4Qnl1Y25lOUZ4RTE0?=
 =?utf-8?B?UGdXK2xwUTJrdVhsM2s5QjJITEVZcGxDd002cmhGdmVMMk1ienA0QjRWUXpR?=
 =?utf-8?B?OGk2Z01MWXhlQ2wwaW9abFV3QnRBSVBKNHhSVHhWd1hVNVYyYVpvSEt2eVVt?=
 =?utf-8?B?M2x5SVhjOUVsZU1GU2kwazFQU25kOTBNVnd6TUM0eUhEK0VkaWxVdGJnaHFT?=
 =?utf-8?B?dmFYQnJqVEZFS2lhWkN5bW5JRmhxLzVIS0JIaDhPWlp5a0ErdUVIQ1VUYWVr?=
 =?utf-8?B?UzA3QXUyRmlvSVczQmNzL0dURUoxTktGQ2JBcFlVdldRODd1TGVBUzJLZzNC?=
 =?utf-8?B?eXpVSE5SVVdzQ2ZUTmpMOUZlOXRTd1ZmdHRML0l5WHQrMCsya2I2MWRNRzdZ?=
 =?utf-8?B?U29tV0cvbkhEc3FxR2tRcnVOUTFLaG81SXBpODhwRHJkVHdPTUp0eHBnK3N4?=
 =?utf-8?B?cGFPRjFZOU5pUjFITnNIdFNjaUg2aHIzTG9FbXRRcWJoK09xQ2h1SUpRMHlm?=
 =?utf-8?B?ek9TOENmT2oydWg1RnF4UkYzZWdPOSsxNDRvdlRsMTVtUXdWU1dicXRrWmxt?=
 =?utf-8?B?RDhvdnZQd2xjM3VzaUxEN1lQM29vVkFEaVRnRnlMT3FWUC9GVW1qalNRNnB4?=
 =?utf-8?B?RitpazJ2NmdwWHM1bU9jOTdzbUpDN1dZVzNxRG40RTlHcHFOUmVUWHdGMVor?=
 =?utf-8?B?SnF2aE1DaXJLSFowU3g5eWZjREsvMk9iMm5EUkZpY21reFdiY0UxYk4raVFS?=
 =?utf-8?B?Qll4QmhTUEwwWWMrL0haVXo4VGZTcTJxY0I3eXNWRzk2K1htZm1MVnh3UWtL?=
 =?utf-8?B?Z29QQTNvSTN6SlNISWNUSnpxcWxmRmZOZVBzd1BpYUVseVoxTzBQb0p5ckVn?=
 =?utf-8?B?OHdFNVhqMDd0UFJPZ1czd2RyVlc5eE1OZVBrYzRpMXVRSlVralZHbGpkdWMr?=
 =?utf-8?B?WVk5NlpDOHRsY054Ujd3ZWdsYks5WGovc05DV1BreSs5Y1d6am5JdnphbytP?=
 =?utf-8?B?RGRzbklPQ2JWS3ZnUVFEeFdMYytHZ1NpQXkxcEdxRGNadFBtbng4czM2c1BG?=
 =?utf-8?B?Qm4zSUNySjFPb2xSR3lPOSt6UlRSOWM0QXVmV1gvVzh1c1FMNmVQVUwwa0pT?=
 =?utf-8?B?c2lWcG9nMWZmK2FIcXorMGJ3UXJWNGpFcUdBVHNkM0pnZjhUR0xQOTFid1BK?=
 =?utf-8?B?ZmhzeUpIN0syMUZUR1E1SzFJTGhaT09HSm9lNFdZRWF2aFh3NkpXcktYR01i?=
 =?utf-8?B?aGdOUTlZT29XMWRsWTAyZmUzTWJSRlNvalF3a29sQ2pxTmRhT0FZWncvVEdh?=
 =?utf-8?B?WkIvWUFncVZHaVdXbmRaVGQ1TG80WUF4UXZzVmVpZllicU1pbDNaV1BGb2FJ?=
 =?utf-8?B?MDVoNVRPckJCaXdrVGZEOUl3QkNoMVBUNkRLbzdOYUx0L2VlUVAvMng4L2JO?=
 =?utf-8?B?alE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c8ca9af6-b8b0-442b-db29-08dbbf37374c
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 08:53:27.5995
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3SA8489Noglzc/1rLtUx9xDujOZVwLOEdn4l1g451sDmbBe9xXTYT5dNaczUZ+o8sqxYOb3XQMTzoTysNxdMBGrCfpOdbjj22kB8isLtXYg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7580
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 27 Sep 2023 01:56:02 -0700 (PDT)

On 9/27/23 10:31, Ivan Vecera wrote:
> The series makes some house-keeping tasks on i40e driver:
> 
> Patch 1: Removes unnecessary back pointer from i40e_hw
> Patch 2: Moves I40E_MASK macro to i40e_register.h where is used
> Patch 3: Refactors I40E_MDIO_CLAUSE* to use the common macro
> Patch 4: Add header dependencies to <linux/avf/virtchnl.h>
> Patch 5: Simplifies memory alloction functions
> Patch 6: Moves mem alloc structures to i40e_alloc.h
> Patch 7: Splits i40e_osdep.h to i40e_debug.h and i40e_io.h
> Patch 8: Removes circular header deps, fixes and cleans headers
> Patch 9: Moves DDP specific macros and structs to i40e_ddp.c
> 
> Changes:
> v2 - Fixed kdoc comment for i40e_hw_to_pf()
>     - Reordered patches 5 and 7-9 to make them simplier
> 
>   drivers/net/ethernet/intel/i40e/i40e.h        | 76 +++++--------------
>   drivers/net/ethernet/intel/i40e/i40e_adminq.c |  8 +-
>   drivers/net/ethernet/intel/i40e/i40e_adminq.h |  3 +-
>   .../net/ethernet/intel/i40e/i40e_adminq_cmd.h |  2 +
>   drivers/net/ethernet/intel/i40e/i40e_alloc.h  | 24 +++---
>   drivers/net/ethernet/intel/i40e/i40e_client.c |  1 -
>   drivers/net/ethernet/intel/i40e/i40e_common.c | 11 ++-
>   drivers/net/ethernet/intel/i40e/i40e_dcb.c    |  4 +-
>   drivers/net/ethernet/intel/i40e/i40e_dcb_nl.c |  2 +-
>   drivers/net/ethernet/intel/i40e/i40e_ddp.c    | 24 +++++-
>   drivers/net/ethernet/intel/i40e/i40e_debug.h  | 47 ++++++++++++
>   .../net/ethernet/intel/i40e/i40e_debugfs.c    |  3 +-
>   drivers/net/ethernet/intel/i40e/i40e_diag.h   |  5 +-
>   .../net/ethernet/intel/i40e/i40e_ethtool.c    |  3 +-
>   drivers/net/ethernet/intel/i40e/i40e_hmc.c    | 16 ++--
>   drivers/net/ethernet/intel/i40e/i40e_hmc.h    |  4 +
>   drivers/net/ethernet/intel/i40e/i40e_io.h     | 16 ++++
>   .../net/ethernet/intel/i40e/i40e_lan_hmc.c    |  9 +--
>   .../net/ethernet/intel/i40e/i40e_lan_hmc.h    |  2 +
>   drivers/net/ethernet/intel/i40e/i40e_main.c   | 57 ++++++++------
>   drivers/net/ethernet/intel/i40e/i40e_nvm.c    |  2 +
>   drivers/net/ethernet/intel/i40e/i40e_osdep.h  | 59 --------------
>   .../net/ethernet/intel/i40e/i40e_prototype.h  |  9 ++-
>   drivers/net/ethernet/intel/i40e/i40e_ptp.c    |  3 +-
>   .../net/ethernet/intel/i40e/i40e_register.h   |  5 ++
>   drivers/net/ethernet/intel/i40e/i40e_txrx.c   |  7 +-
>   drivers/net/ethernet/intel/i40e/i40e_txrx.h   |  1 +
>   .../ethernet/intel/i40e/i40e_txrx_common.h    |  2 +
>   drivers/net/ethernet/intel/i40e/i40e_type.h   | 59 +++-----------
>   .../ethernet/intel/i40e/i40e_virtchnl_pf.c    |  2 +
>   .../ethernet/intel/i40e/i40e_virtchnl_pf.h    |  4 +-
>   drivers/net/ethernet/intel/i40e/i40e_xsk.c    |  4 -
>   drivers/net/ethernet/intel/i40e/i40e_xsk.h    |  4 +
>   include/linux/avf/virtchnl.h                  |  4 +
>   34 files changed, 231 insertions(+), 251 deletions(-)
>   create mode 100644 drivers/net/ethernet/intel/i40e/i40e_debug.h
>   create mode 100644 drivers/net/ethernet/intel/i40e/i40e_io.h
>   delete mode 100644 drivers/net/ethernet/intel/i40e/i40e_osdep.h
> 

Thank you!
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>