Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <031ef099-a7d2-37ce-eb97-c4f7d76a12c4@intel.com>
Date:   Wed, 27 Sep 2023 11:34:45 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v10 09/10] x86/resctrl: Add support for the files for MON
 groups only
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20230915224227.1336967-1-babu.moger@amd.com>
 <20230915224227.1336967-10-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230915224227.1336967-10-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWNpTEVvSzBrL2Q1SWlRQWplT3MxUUhYbG9kbU5SMzY3aEV5TERZRVEveDRP?=
 =?utf-8?B?M1AyeXo5TXRURkVhdjc0L2kxTHM2YlNEak4zcXVkTWdKN0xodHBlSW9EOE5E?=
 =?utf-8?B?MjhFdGNSaEE5RzByRXFVK2s4OWhDREwyUmttLzB6RDVpdlVzT0dGSUZqaEQ0?=
 =?utf-8?B?c2VMWVE2NDgxK1h6cm9HSjJLczFYWTV6RE9tdkZEMk5aWUo0ekt2aHB1cW5K?=
 =?utf-8?B?ZEVzQUsvMzJsUlJveEgveXZzT01tQlJ5Um0rbkNBOXN1cllnbi9aUFdrSDly?=
 =?utf-8?B?Qlp1dXk3cEc3cy9NZmdvRzRaVkZOVFAxZ28xVGVMM1QwQmVVNXo5QWFicWV6?=
 =?utf-8?B?Yk9iVU5nNGtLQ1BZMDF0SU9SYlYvd1VLbXQxSENTZ2RmNG0wYW9uQWsyL3l1?=
 =?utf-8?B?T0M5eU9lVWxRSzRPb3hDNkxQZGxLbzQ0Wkc2ZmtiR3VBVmdNeWZqdWwvNk1t?=
 =?utf-8?B?M29yekdSa3loRExsZjFwemZlZjhKN2VXVU9XN1VYc3hNbWhEa1U4cUo0VjF6?=
 =?utf-8?B?QXpKSG9DUlBONWNUMVFWN0R0c2ovK0FJWTBaYXVWK0Z0NEd2YXRyZG1Xb2VF?=
 =?utf-8?B?QmJmaXU1WGtYS0hNbmRMR3RSdnZyajJNNE5ocHpldTRrMG1JdUdhZUpFWlpr?=
 =?utf-8?B?anZseGErZzd5YkZBbzJQOW1OaWVyb29RK1hWOWVFMVkxdGh5UHgwWENkNlFk?=
 =?utf-8?B?MWNnMEc4cnBpd0l0d2tJMTlBTnh3TmNPUGx5TDVXM0VsNDNiMTBjN3pHanAy?=
 =?utf-8?B?MmV1RWRVRGN4eG8rVExvZGxkU3lXQU1ibGJRalp1Vm1CQ2hydWtEWnBoVWYw?=
 =?utf-8?B?U3NyRlYzU0NUcWlrd2JaS2xZcGdXZEc3TmlqdXFLSEQzZUJkbmdJZUhHQ3dj?=
 =?utf-8?B?ZW04elplaEk4Slo0clRoWldURWhoRkNLQzZtc3ZTK0VjUi9MejZKemRsZEhR?=
 =?utf-8?B?b09TdU1NSUJOVC9TOW1pblVhRk1QaCt5T0xEemU5OFFYbStySmMrckVibHI2?=
 =?utf-8?B?MGR4VndwOENLeW1KZW4rYmhtdStIK1JrdC8zaGdlUiswQllGRnAwSi9DU3lH?=
 =?utf-8?B?aHROZ2RHUEF5RElBQjhkeVk0a3M5VjhOSVVnWko3ZXRsWERaeE9ITk8wNXZp?=
 =?utf-8?B?RmZEOU1aYWZSd09rQlVsc0pwb0lhTDZUc0hXSjhJVHhwajBkelZVK1FRa29z?=
 =?utf-8?B?OVpTMUl4Ky9rMjhEbVZ1czhvZGkrNGZEOEI1dWdMK05XRVVTaGRMTFlKZGI2?=
 =?utf-8?B?LzhPRUIvTC8wNUlac3BuZE1kZ2FrNWdnU0g5ZVg2QVJjM1AvekgzZTQ5ekhV?=
 =?utf-8?B?T25wTXNYWEx4Y3ZqbFp6ak1nSE1TQW1lam1MQ3BDKzZSWlJxWUFPQ1RDTkQ3?=
 =?utf-8?B?M1lvcWJ1cWtYUjlBWGRvTE5DSGZOaGZiQ0hSYjF2ZVBIL1IzNk50UXMvMThi?=
 =?utf-8?B?MWM0ZXhLZWJtNnY4MHBGbXVyZXV0Lzl0SVpPVWZpcytzVEVnRXRiOUEzTVcx?=
 =?utf-8?B?OWFsZSs1VVo0b09aVC9FS3JCSFd6Sm5mTVo0SEk5MjAwb2U2aEtuemJzcWFv?=
 =?utf-8?B?WUdqRGo5R1lDQmhvWHhSN3hobnlOU3o3T3pRWlBMcW5jbmJNMXJGOGFncW52?=
 =?utf-8?B?NERLU2RSWXVyeG5FbnVQZ2pTK2NZYzFBK1hUM3kyMGxyaDN3K2lheUNtNk5Q?=
 =?utf-8?B?ZHJpYWUzKyt1NUpKTmpocmc4YjZ1UmVHdFFnVllEUFdqa3B2aVJZeG9aYmJG?=
 =?utf-8?B?TDk5Zm5oeUZRU2lRYmJsd2N3VHpZK21BS1JQTEgwSTI0L1V0eGEvYi9OSS9N?=
 =?utf-8?B?T2VOaTEyUTgzMUNua1pQaGlMc2M1L3g2VjJQQzNkUjF0MmsrRUtFelQrWGZy?=
 =?utf-8?B?aGphWXNUdExPNUtNNW03dXo1ZlB0V2xhRnZyaDdzcC96cFZyYUcvNHNOOGtr?=
 =?utf-8?B?T0FnWVhVRFVqQ1JpSmFUZGZsY2tVQURwZHFrbEFJQjRVaEFwTmhieUxURTRh?=
 =?utf-8?B?Y1BRYUZtS3l5NXVNVVdITVU1RXN4MWhrMWgwUThUcEk1R1BjcDVPNHVld2gr?=
 =?utf-8?B?d0ttS0doYkJOcHJ5RVA3Z2ZDSHo2UVhPMWsrc09YNlFVNFBrcEJnVWMyaGU2?=
 =?utf-8?B?Zkl1dE0xNGF2NWFpRUg2cUl4dUV6dk5rYktUNW11Z2RuQzlFdUpNS2FzTlNi?=
 =?utf-8?B?cnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c14c00b3-a115-4fe8-1c90-08dbbf886e18
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 18:34:48.8159
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qPmLahtsamS5P3Yq/qLnWa7oFpKYKhP/GDNhWp5j9phqYxVVmbw3IHB411VOPWjeOgcsnH8fJFJ8UPQCIywEWs6Dik+j2wMwzMOdMiAZ1n0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8375
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 27 Sep 2023 11:35:42 -0700 (PDT)

Hi Babu,

On 9/15/2023 3:42 PM, Babu Moger wrote:
> There are 3 types resctrl root files.

Considering patch #4, should this be "base"?

> 1. RFTYPE_BASE : Files common for both MON and CTRL groups
> 2. RFTYPE_BASE | RFTYPE_CTRL : Files only for CTRL groups

If (1) is accurate then I cannot see how (2) can be accurate.

> 3. RFTYPE_BASE | RFTYPE_MON : Files only for MON groups

Same here.

> 
> Files only for the MON groups are not supported now. Add the
> support to create these files.

This is not accurate. Files "only for the MON groups" are
actually the only monitor files that *are* supported. The
problem being fixed here is that monitor files are
not supported for CTRL_MON groups.

I made an attempt at rewriting this commit message but I am
doing it quite quickly so please do improve it:

	Files unique to monitoring groups have the
	RFTYPE_MON flag. When a new monitoring group is created
	the resctrl files with flags RFTYPE_BASE (files common
	to all resource groups) and RFTYPE_MON (files unique
	to monitoring groups) are created to support interacting with
	the new monitoring group.

	A resource group can support both monitoring and control,
	also termed a CTRL_MON resource group. CTRL_MON groups should
	get both monitoring and control resctrl files but that
	is not the case. Only the RFTYPE_BASE and RFTYPE_CTRL files
	are created for	CTRL_MON groups. This is not a problem
	because there are no monitoring specific files with the
	RFTYPE_MON flag associated with resource groups. 

	A later patch introduces the first RFTYPE_MON file for
	resource groups so fix resctrl file creation for CTRL_MON
	groups to ensure that monitoring files,	those with the
	RFTYPE_MON flag, are also created.
 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---

I only have feedback about the changelog. The patch looks good to me.

Reinette