Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <c13cf5f2-d768-ffd2-96ed-b395d48dd7c0@amd.com>
Date:   Wed, 27 Sep 2023 21:55:13 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 0/1] drm/amdkfd: Fix unaligned doorbell absolute offset
 for gfx8
To:     Arvind Yadav <Arvind.Yadav@amd.com>, Christian.Koenig@amd.com,
        alexander.deucher@amd.com, shashank.sharma@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        Felix.Kuehling@amd.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230927161616.3335-1-Arvind.Yadav@amd.com>
Content-Language: en-US
From:   "Yadav, Arvind" <arvyadav@amd.com>
In-Reply-To: <20230927161616.3335-1-Arvind.Yadav@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHNPR2lKaSt0UFFoZkEzbDVVK1ZUNmNiYm8weGQ4T1BHcXdXSGxoZGg4RzVN?=
 =?utf-8?B?NlNIM2pvMTA1LysreUFNRXdianppbEY0V2YwWGJZT09od09uV2UxaDhxNC8w?=
 =?utf-8?B?K3B0RnBDaTlnUXpPTTZFc0psKzJZT0FNbGx6NXNxRHVBNHhUN3Q2dXBsY0gy?=
 =?utf-8?B?cjhKQU8zWHdtY3Y4ZktYakVVclZoekw5WE1YTkhmUmR4MjVMSThyU0tibnZ1?=
 =?utf-8?B?aFlWUDU1OXBNM2JmQ29xVDV1Nis4TEN1WVR2dGNpNjhyakJNOEFKWGdhN2Za?=
 =?utf-8?B?YzNVaHU4cGQrRC9WR3psc3RrOVVSK1gwM0RpSnpteW5mcFlmZU8vMzI1ZkFn?=
 =?utf-8?B?SkZDSVVoTnRNSUhuais3Wlg0NW55ZWN2VTBTR1R2R3k2YWgwMGlsYXMrSTZW?=
 =?utf-8?B?WjFlbngxVmFkclpwbzZGa3lSUytuVFZIUDA5cnRoOHR6aHdTZ0pzSk96S2Y5?=
 =?utf-8?B?eStsb2duS0dGcVY4Y1JsZ3hRbkdCZmZBRUJZdnFveC9OdmZuWWtETWRxUzJu?=
 =?utf-8?B?MzNjSDFjR21QbXNiUUgyaUY2YWM1Z0JoN2VidzNRQVREczBwVXR3SkNHbFJm?=
 =?utf-8?B?RUhHMmRhcXhoWXdxMjFvUndZR3RBVzBIUXlwNGNxaituWHN6dFllSmtIQlBn?=
 =?utf-8?B?R2U3VThVa2YyTmlLOGtibEVQR1FYTXVJcWU3TDJRcW10L2oyTGV6dlRkZzJm?=
 =?utf-8?B?MkduZnVhVlFNanhmQmRyZC9OMDBzUkpuWE1TTXMyN3JKOUVBc1IvSzNMbkhC?=
 =?utf-8?B?MnJPbXFxc3RLNld5TTY3a3BwbGU1dE8yZDRId3NmS1VqeXZLSy91R3NpMVJq?=
 =?utf-8?B?Vit3a1JGL1FaaWVnbW9XbkpkZGx2TXEzVytNeTF4bUdEZHp4V2NrWE1WRmxC?=
 =?utf-8?B?cTYxT2lvS2Z6dFh5YzBYMU5LbGNvaFNvUGViNVZoYVpXbXhyOTFpenA2amlU?=
 =?utf-8?B?ZlRlbmdOVWQwWnhyaFUzTVIwZmlyd0Q1NWo5bjAxYnBZQ2NsK0VrS3ZrNHF0?=
 =?utf-8?B?OVU5UXdOSFY3Q04wbjN4T2RXcUhUeVVpSEo1aFRYTllJeWt3V2Rtck5ZWjZv?=
 =?utf-8?B?emJTQlg3WDF3WW42MDFidzUwRmlCV1h6ZVFycldJcEVQSW9CN21SVHMzMjFw?=
 =?utf-8?B?NTlFWEZWVzl6RlI2ZGU0alBsMzNHQUJMWjhCL09NaStvZ0JsZUUxQlUvSEgr?=
 =?utf-8?B?cVZmNE5OUWNISllOTkxYY0crUlo2V3hjcDJqMGZXa1owQ3hya0VpU2IvY044?=
 =?utf-8?B?R2drc0FNTmxsaFRrSmF5ZVI1a29pUVRhdVNqMDQ2d0JFTjQybHI3M1hNa0R1?=
 =?utf-8?B?aEhXQmJtSjM4dHhPVXUyQTZPc1hjTGZkWVF5Q0QwZzdsWjRFb1RDaXI3SGtp?=
 =?utf-8?B?RHp2NzJwQU9tSkNpUmRFbVBNWXcra3hrY3RmbkxWLys0alNaZnBld1lLTzh6?=
 =?utf-8?B?cTZKL1RHNTRyN2dlQkYyRzhxL2VhbHo4RFQwaFVuMy9NTEJJRzg1aFhwUTd2?=
 =?utf-8?B?N2w5OXNoUWlFU0VTUlRrYWRLbGYxamFFM3E2aElXZXphVXlIQkhXeUIwbWNn?=
 =?utf-8?B?dllISS91bG1yQzB5SU1NTkw2bHNYZU5BbWxEMllKaExFQ011a2VWbkY2ekNq?=
 =?utf-8?B?dzRnRGIyOWpYYkErRGRzd3hvb3REUmJ3aWpFdUQxK0YwWFpZMm01OStBN1hp?=
 =?utf-8?B?QlpZS2RkMUU5eFpKS0J1TDJCdmcvWmlrNXZlMU1uNzFBdXJuZXlDckY1Ukt5?=
 =?utf-8?B?WTBFVEVDTFVXaVFBUmlkZjI1Z0JtQ1lSbkQzY3FWTnoydG5kSFVFV3JYY1pu?=
 =?utf-8?B?czdaWFBwc3pWcGdFWlZiRXVpdFQrTnVJR2tNN2NseVJzQWMrSnJXTnN6MU9Y?=
 =?utf-8?B?S2FHNytsN3ZiVTRYNzIzWTFkNUFJWWYrS0t1bXJtT25SSlk4TSsxY1R6V1Nr?=
 =?utf-8?B?MlhmMXhrWWduL29jWVFBUzMzaDZkeUNyeE1kSnVxbGg3YTNGNjdsWHVPdStB?=
 =?utf-8?B?Q1FuZlM0NnU4REQ2NU9yUU1GZVp5cnVHWkc5eCt4TnJmLzV4SUZrK2lVMEdT?=
 =?utf-8?B?R2JPRElPc2xxc1NzYUJ2Z1lSWjh6eGdUT0Y4S2JETWFDNEJCZVJCVmczbXFR?=
 =?utf-8?Q?ruOiSLEYey/6O7VEUAErMqz/s?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75efb534-231d-4664-2e20-08dbbf765b82
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6000.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 16:25:26.9259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 056HHw8OGEmdaJWmVVRJDdwCoQT2zGpIfckn/nRtZQKnntYlGXbJGq1GXr3q0t5vmCDtXgMQQzoSL+Z6ZU8dLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7457
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 27 Sep 2023 09:26:02 -0700 (PDT)

Adding Felix.Kuehling@amd.com for review.

Thanks
~Arvind

On 9/27/2023 9:46 PM, Arvind Yadav wrote:
> On older chips, the absolute doorbell offset within
> the doorbell page is based on the queue ID.
> KFD is using queue ID and doorbell size to get an
> absolute doorbell offset in userspace.
>
> This patch is to adjust the absolute doorbell offset
> against the doorbell id considering the doorbell
> size of 32/64 bit.
>
> Arvind Yadav (1):
>    drm/amdkfd: Fix unaligned doorbell absolute offset for gfx8
>
>   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
>