Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Wed, 27 Sep 2023 12:44:39 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Peter Newman <peternewman@google.com>
CC:     <bp@alien8.de>, <dave.hansen@linux.intel.com>,
        <fenghua.yu@intel.com>, <hpa@zytor.com>,
        <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
        <reinette.chatre@intel.com>, <tglx@linutronix.de>,
        <eranian@google.com>, <x86@kernel.org>
Subject: Re: [PATCH v2 1/4] x86/resctrl: Enable non-contiguous bits in Intel
 CAT
Message-ID: <xn63zx7zfjszkp2nvpiemrxnva54dse3wed7apvadgibr23fqq@jodz2loxarsu>
References: <918e147601697b1d4b8f8589f5751e05d6ceccdf.1695371055.git.maciej.wieczor-retman@intel.com>
 <20230922141441.3353077-1-peternewman@google.com>
 <xnjmmsj5pjskbqeynor2ztha5dmkhxa44j764ohtjhtywy7idb@soobjiql4liy>
 <CALPaoCgm8ed0p3Nw53d=Hgs0WnunkRUwAriyuKqu6+5Ty-QVTw@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CALPaoCgm8ed0p3Nw53d=Hgs0WnunkRUwAriyuKqu6+5Ty-QVTw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFNKV3A1R0VEaTUzZWJ6ZEdzYUVhbmZkbXlFeVppZlQrM28zMWVmR2tIeFJP?=
 =?utf-8?B?QTM1UHRwUEQydmlzbVhzME82TDJDR2hMMXlhbXhiaWs2VW5QOTVEcDdqRjZO?=
 =?utf-8?B?S1BIU3VFRjgyMWdiZE5aUEl6N29oQ0pPVlR6WHo1UzBJUDFtTTV0Y3YzM2hw?=
 =?utf-8?B?K3hGWkp2V0RrcVB2WDBXakRONU5YZ2h6ZDJrc1V3bGlsc1ZZNmtjTktEOWdi?=
 =?utf-8?B?cFg0WU1keUJvaCtZSzc0K3Y1WEFQYzl3R0VLcXlHTkcxQTRYa3lndG8raVhH?=
 =?utf-8?B?QXl1Zy95NU5xcHJ1N2thUGR0ajhQMlJ3dUZLdDAvTHZaLzQ3Z3d2SGh3alZv?=
 =?utf-8?B?MERYY254bEJudWk3UE40NkpOTUo5TmdZYTN6MEVlMGxTZzV0cTcwYWJIcnY1?=
 =?utf-8?B?dEc3dmwxc0JHNnVBditmRlJldjhTNmFLdWRFZVBZcDNwRWdLYkNhSTI2N0Z1?=
 =?utf-8?B?VmV6cFZ2NGE5OFlWaGtvNklRb05TNmNXR21Obkd1eEpXZDVBMFVaUDMyQjQ1?=
 =?utf-8?B?Rm9WOGhXMnluTFBPR245cmRvSzNBY29zM2JmbVY0ZzFvRWRDejFVQ0RnbkpI?=
 =?utf-8?B?NTNncDNyS0JVVDlWRnB5em03aXNpam5EYkdoSStVY2dqa3QyOFRMZjdlcHov?=
 =?utf-8?B?QUFwWFpSa1lrd0hLb0ZnQTk5a2hwVFYzWmNjeEYraEFUbGRiTzB2ekhmVGxq?=
 =?utf-8?B?bEZObmhtNUpYVDJsaG9oQkZUODUzTVNSWlJTM3RVYzFOR2VZd3F1a0dnbzJ5?=
 =?utf-8?B?Zm5uSmZYRHVOdzFzUytuTVBlZWNjNlBxajk2L00xa1hVRnptd3lOcEJHWExQ?=
 =?utf-8?B?NlFycFhCZXN1MjZwOEYzT2swMTdBOE1GdFFieVhQaERXWkZIcFl0MmV5eHJl?=
 =?utf-8?B?Y3JYME9XOHl4VTk4Q0QxYlpNdjZ5ZGNVVjBKMTFab0NqR1NaVFRDUTNnT0xJ?=
 =?utf-8?B?YW9KN3k4dlF2TFllY3BCMjgya3B5U3Vuc0ppbklMRnBLRTlvLzBoeVAvZ05x?=
 =?utf-8?B?OGw5VGxObzJSUHlRajFQV2szblhQd2RlWWxVUURXanRrd1gvZ2JsSGdhUExO?=
 =?utf-8?B?NFh4amhvNDBuV0V1YVZDMk1YbGxZQXl3TUxwVW9kenJ6K1c0RlAxMk9uM1dM?=
 =?utf-8?B?SFhKTlJJYVlTQi9mOUQ4WkpMb1RoMDBMM3Vwd2FVRm1NUU9xMHBjMmhFQmUr?=
 =?utf-8?B?cmp1cW41cFI1Q2Jvd0hjZHVEZGpXV1FmS25VR3l6a1Q0eG1raGQxcjBScFVZ?=
 =?utf-8?B?K25teTZxcFY5YjBwcGFPTitmRXRvdElJVjdLWFJPYlBjN3hsYmUxNDlCaXRw?=
 =?utf-8?B?SithcG8yOTJJTHZEOWFCN3hpd29aSWdHN3FESVVpMU1yRDdRZk1HTEdnQWFU?=
 =?utf-8?B?MmJKRWwzbFJGUjdlb0lFQ3VlbVR5aCttYXRCOGtVYTNlM3k2TTlhakd1WWFn?=
 =?utf-8?B?RmlWY2IzTVlUZCt1UUFtdnZyU01IRkd4UHNTSDF3dXYweDdGOUtCOE5ZT2E1?=
 =?utf-8?B?QzVQOENZdStFTG5MbFZuRjlRenY5d2RyQU5xNTVScTg5WFNQczlmQ2pnZHV0?=
 =?utf-8?B?R1krbnNwdTNjVzNNQmVUNHJ3QmMzYk5hcjlzTk16ZFdMWGhmZmZZQytJempR?=
 =?utf-8?B?YTVNYS9ONGY5VzdsaWtJU3ErVEQ2UE1zbTRzUzFIT29zS2hrTlFVZXJHV0N4?=
 =?utf-8?B?T2grdjBsSHYxRzBwaFkxT2QrSGtNMWZCNS9LaVZrRWhGd1FLaTlMc0tHak00?=
 =?utf-8?B?TTR2M2Q5QkpHelg4YjZXa2V6dEpCajdYcWJOeCtKMzFwQlV6ZDRUWEdJdlZ6?=
 =?utf-8?B?NjR2NjZGaGptdWlDL1NXbHVpeHhWcE8rVWRPSDFQSllRcFhlSUNyYUhUWHFF?=
 =?utf-8?B?ZFI3dWZ5NFpYdStkRGZSTFFKRzUyVGRWSnp5OXZLZmpqNG02YytzV3RiRFdK?=
 =?utf-8?B?VnlPWHZ5RXpxQXkxTEFtVExLc1MxdEVNVzhXT0dpVmJCeDdvVFh5QVhLMENO?=
 =?utf-8?B?Rm9nUHdNQ2J0QzRNZkgxRHhtWVBMVVRXTng2VVQycmlZRmg5ZHVKTlNSemll?=
 =?utf-8?B?aXk4NXZwekt2NDJiNDltakcwbzR0VUdEZkhvaWVsOEc4MWw2bjltN0F3Z0sv?=
 =?utf-8?B?QVg1QWtQWE9EYlV6ZElobHFkWFdVWmdmd2ZGOFc1eS93QWVXTHpsOEhvNU45?=
 =?utf-8?Q?jgGABPw2sr++QJ6B67yafTw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a0f4f6bd-53fe-419a-b5c6-08dbbf46c4f3
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 10:44:47.8103
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uTJQRpf8lCM+WstarHwK/B3Pw2pMe2RtmDqM/NxPZqnk6L+KDx04gfWK5G+77xBKbM0rJmH5on+cDTv4tcbqO8goT4THIRghxNm3MWPS4QU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7941
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 27 Sep 2023 03:45:32 -0700 (PDT)

On 2023-09-27 at 12:08:33 +0200, Peter Newman wrote:
>On Wed, Sep 27, 2023 at 11:20 AM Maciej Wieczór-Retman
><maciej.wieczor-retman@intel.com> wrote:
>> On 2023-09-22 at 16:14:41 +0200, Peter Newman wrote:
>> >On Fri, Sep 22, 2023 at 10:48:23AM +0200, Maciej Wieczor-Retman wrote:
>> >> -    cpuid_count(0x00000010, idx, &eax.full, &ebx, &ecx, &edx.full);
>> >> +    cpuid_count(0x00000010, idx, &eax.full, &ebx, &ecx.full, &edx.full);
>> >>      hw_res->num_closid = edx.split.cos_max + 1;
>> >>      r->cache.cbm_len = eax.split.cbm_len + 1;
>> >>      r->default_ctrl = BIT_MASK(eax.split.cbm_len + 1) - 1;
>> >>      r->cache.shareable_bits = ebx & r->default_ctrl;
>> >>      r->data_width = (r->cache.cbm_len + 3) / 4;
>> >> +    if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)
>> >> +            r->cache.arch_has_sparse_bitmaps = ecx.split.noncont;
>> >
>> >This seems to be called after the clearing of arch_has_sparse_bitmaps in
>> >cache_alloc_hsw_probe(). If we can't make use of the CPUID bit on Haswell,
>> >is it safe to use its value here?
>>
>> I believe the calls go like this for a haswell system:
>> resctrl_late_init() -> check_quirks() -> __check_quirks_intel() ->
>> -> cache_alloc_hsw_probe()
>>
>> There this line is executed:
>>         rdt_alloc_capable = true;
>> where rdt_alloc_capable is global in the file scope.
>>
>> Then later in:
>> resctrl_late_init() -> get_rdt_resources() -> get_rdt_alloc_resources()
>>
>> this is executed at the function beginning:
>>         if (rdt_alloc_capable)
>>                 return true;
>>
>> So the rest of the get_rdt_alloc_resources() is skipped and calls to
>> rdt_get_cache_alloc_cfg() never get executed.
>
>Yuck. But it works I guess.
>
>The series looks fine to me.
>
>Reviewed-by: Peter Newman <peternewman@google.com>
>
>I applied the series and was able to confirm the behavior was still
>correct for contiguous-bitmap Intel hardware and that sprase_bitmaps
>is true on AMD and continues to work as expected.
>
>Tested-by: Peter Newman <peternewman@google.com>
>
>I'm not sure if I have access to any Intel hardware with
>non-contiguous bitmaps right now. Are you able to say where that would
>be implemented?

Thanks for testing!

Writing non-contiguous bitmasks is supported starting from the upcoming
GNR microarchitecture forward.

That's also why the new CPUID bit meaning is in the ISA pdf and not in
the SDM one currently.

-- 
Kind regards
Maciej Wieczór-Retman