Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <2ada40ae-f11b-9ac5-a493-6ae2383fac2a@gmail.com>
Date:   Wed, 27 Sep 2023 20:08:13 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration
 by adding identifier name
Content-Language: en-US
To:     Daniel Lezcano <daniel.lezcano@linaro.org>, rafael@kernel.org,
        rui.zhang@intel.com, amitk@kernel.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com
Cc:     linux-imx@nxp.com, linux-pm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230917083443.3220-1-bragathemanick0908@gmail.com>
 <786d197a-a2b5-2507-f5d7-24e8224a3922@gmail.com>
 <883b0780-1f89-40a4-fbd0-a3d4845c2826@linaro.org>
From:   Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
In-Reply-To: <883b0780-1f89-40a4-fbd0-a3d4845c2826@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 25/09/23 13:17, Daniel Lezcano wrote:
> On 22/09/2023 11:31, Bragatheswaran Manickavel wrote:
>>
>> On 17/09/23 14:04, Bragatheswaran Manickavel wrote:
>>> Added identifier names to respective definitions for fix
>>> warnings reported by checkpatch.pl
>>>
>>> WARNING: function definition argument 'void *' should also have an 
>>> identifier name
>>> WARNING: function definition argument 'int *' should also have an 
>>> identifier name
>>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
>>> ---
>>>   drivers/thermal/imx8mm_thermal.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/thermal/imx8mm_thermal.c 
>>> b/drivers/thermal/imx8mm_thermal.c
>>> index 14111ccf6e4c..5dc6c18f12df 100644
>>> --- a/drivers/thermal/imx8mm_thermal.c
>>> +++ b/drivers/thermal/imx8mm_thermal.c
>>> @@ -78,7 +78,7 @@
>>>   struct thermal_soc_data {
>>>       u32 num_sensors;
>>>       u32 version;
>>> -    int (*get_temp)(void *, int *);
>>> +    int (*get_temp)(void *data, int *temp);
>>>   };
>>>   struct tmu_sensor {
>>
>> Hi Team, Could someone help in reviewing it.
>
> Please no more "gentle reminder"
>
> Read:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/tree/Documentation/process/submitting-patches.rst 
>
>
> Especially, the section _9_
>
> Thanks
>
>    -- Daniel
>

Hi Daniel,

Understood. Will wait for this to get reviewed.

Thanks,
Bragathe