Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <741b7bed-919b-41c3-bd57-85e1cdfd6e48@sdfg.com.ar>
Date:   Wed, 27 Sep 2023 21:41:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] tools/nolibc: Add workarounds for centos-7
To:     =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc:     Willy Tarreau <w@1wt.eu>, linux-kernel@vger.kernel.org
References: <20230926133647.467179-1-rodrigo@sdfg.com.ar>
 <20230926133647.467179-2-rodrigo@sdfg.com.ar>
 <e8ed17e6-8eb3-404d-9669-5e5b413904ed@t-8ch.de>
 <c658a72a-b3f6-4504-a940-7ff946c81559@sdfg.com.ar>
 <5d4d14f5-b90d-4fd7-865e-0d64b8520c0e@t-8ch.de>
Content-Language: en-US
From:   Rodrigo Campos <rodrigo@sdfg.com.ar>
In-Reply-To: <5d4d14f5-b90d-4fd7-865e-0d64b8520c0e@t-8ch.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/27/23 20:23, Thomas Weißschuh wrote:
> On 2023-09-27 15:06:03+0200, Rodrigo Campos wrote:
>> On 9/27/23 01:30, Thomas Weißschuh wrote:
>>> On 2023-09-26 15:36:47+0200, Rodrigo Campos wrote:
>> We can definitely remove that struct statx bits in our vendoring. It will
>> simplify updating if we don't have to patch it, so if we can't include a fix
>> in nolibc, I think we will continue doing the hack ourselves and that is
>> all. It is not too bad :)
> 
> How often are you planning on updating your vendoring?
> In the timeframe before you are dropping centos-7 support?

We will probably update if other MIPS variants are added, or other 
arches supported by golang. Other than that, I don't see that happening.

> The "nice" thing about the breakage is that it will break loudly during
> compilation so it will be easy to notice and fix it up.
> 
>> I don't think it is worth for nolibc, at least for this use case, to
>> reintroduce compatibility for stat() without statx().
> 
> It wouldn't even be full compatibility. The code would compile but be
> unusuable for stat()/statx(). And I don't think any application expects
> stat() to return -ENOSYS.

Right, it would not be fully compatible but it will be possible to 
compile and use the rest of the syscalls, just not stat().

It's really up to you to decide if that is worth or not. That happens to 
be what we need :)

> It's a bit ugly code to support a kernel that has been EOL upstream for
> six years for a fairly specific usecase.
> But who knows, maybe Willy has a soft spot for the 3.10 kernel :-)
> Let's wait for his input.

I can't agree more, that is why I was unsure supporting centos-7 was 
something we want to do in the first place.

Let's wait for Willy, but I will be slow to answer in the coming weeks, 
I'll be with limited internet connectivity.


Best,
Rodrigo