Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2798236rdh; Wed, 27 Sep 2023 13:03:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjlAv6LZ5iFRkJfRopjeRbKthFew1CPUGY3VqPPm1fgXnzfKv3+8uGk6+UETAGC4Z5bjIB X-Received: by 2002:a17:902:d50e:b0:1c5:59dc:6e93 with SMTP id b14-20020a170902d50e00b001c559dc6e93mr5279553plg.3.1695844988579; Wed, 27 Sep 2023 13:03:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695844988; cv=none; d=google.com; s=arc-20160816; b=03iYPceTxWOJ8AcdXIyyrrY1lDXgxcTTDc22kYXGVblsQ3nHdHKsrrIkk31f/PASfz KaAIfkSyt1GUz54K7vPP8jZ6sZTNLg2A1KClw9wKTtV1L1Pd+5sd5hAw2OZVYoE5SMjH +Y0mi/rO2xOIHtuyyHQSvoo3P1/Op0+yss6A7akOhyZnVt27lHN5TetqFmdx2WkH1wzS sldbJ9IPY9gRMgZIhCRzvR8aHGUZjPGgZvW9uKZzZKkrH1MaRfwt2b3GeAuEOZdGdv7F b8u6p2gIScJv1VGd5KBS2ClWUO5gFFkbiOaGEbEuY/JpgTl/bahLCvs/+AuVvqVGeURB sUXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:subject:cc:to:from:message-id:date :dkim-signature; bh=MTO5YKzNZHo5vmVl48tEQLfQbpC8a1F4p23QGGnmvtw=; fh=i7DQetGfDsfWYXohCb4E5ZTXE/R/ityVAbXNGIxurAo=; b=eVMRH3ysUuguyKtiFlxQNW6J2iryAeZ79xMFHipnZz8rBUgCBYoqOvtvB2VCQMgaAM iSZ1GQy3jnZUohUPsrKmUaOcyjdz/tUMtFM+wkcBj5CT0llNDIsOaB0+cQgHO8x7xxZ4 EPuo599hYq8R1po1PIWNxRvMmVfSBU0PYznI1YgDLRYva82n8H+mOPI3TvPwtD0y0zrq CwQlAPkleUFwzyDMRkl+8sKiWML3KXpvwvDMs+48JrZSY1LLsL+G8ZnKY7FRCCwPpGfh 4OoM3l+A0fIXKE87gdy63h0OX1SmzCUwB9hdhs46oNz+p2dTZ/xFpnSRwS6F+SYEDLka he0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=H6imsNiH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id z18-20020a170903019200b001b8a70d11e4si18078191plg.529.2023.09.27.13.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 13:03:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=H6imsNiH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id B0F968047560; Wed, 27 Sep 2023 04:14:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231339AbjI0LO3 (ORCPT + 99 others); Wed, 27 Sep 2023 07:14:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231211AbjI0LO1 (ORCPT ); Wed, 27 Sep 2023 07:14:27 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A85FF3; Wed, 27 Sep 2023 04:14:26 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1c47309a8ccso88941535ad.1; Wed, 27 Sep 2023 04:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695813265; x=1696418065; darn=vger.kernel.org; h=in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=MTO5YKzNZHo5vmVl48tEQLfQbpC8a1F4p23QGGnmvtw=; b=H6imsNiHW5QsM7E7sh1Isl/LAcgWVPerN1aKZdnDfOuKmVSy+gxyb+6fVIf6teNLg6 hP9a1CRHzb3N5BPZiFgZbb2nLj3OX+mp6tftNUQ9x9Hs2ldXHrRyT9GMAck0rKgC9Eea GvEgRSvuwbjtqmkmyQbX1DxUQBisVwkDj5yQ+0Tkw8b6pHnWfLrgEW+PdtU/EMr2SuF8 nWVPNsgnD4Mr1/LyBpP0TYZrmT2GXYq5nhjCalWKwiL6BAdLoPAqtCnSuqCfFDHe2P3A edbYbC6maPmgWuRhgh4MHEVZlSABgXvjEjNqBeCFBorTs8Ow6Rwfo8AYhVlPwB2MALUv ZvDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695813265; x=1696418065; h=in-reply-to:subject:cc:to:from:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MTO5YKzNZHo5vmVl48tEQLfQbpC8a1F4p23QGGnmvtw=; b=ZFygn0uw2xeeq5o6kS5HNwgz7cjdapv26Ma9/A780UPj0CYro7WvfqqDYzSeYjYwJS WCpAfWF5XIWGfVh1FqnS8hM4kFD3nd1cF8hUuoJCCs+uM5/yb/XFTwDKaG3w/FknuXxA /QYrBLHyUQ6P6G32SkPAjPRqn/b99PGazZanIn0xVOQgerYuHdGs9x5dDoDwvjaMVqMF 9qGKDl8SGIdEeESIn6Qy3HQZVhiit6nQrLON/FEZrnelypCsimaePjamDLxmV3zGEqmW UuoRKTHJnR2ej+4/ji5ZXTKKqvZsc/G2J1CtSMh/M+W/kJBOgZst69yj1SbSpiqlXgUO YFGw== X-Gm-Message-State: AOJu0YwHR7Uu3VDRSAWbyowwEGc82YiWHNGfhmuqS5DsKtTmT2/QtjGl VHNU7fl5h6kie2PSnNrsqRPuzuWfjLw= X-Received: by 2002:a17:903:244d:b0:1bc:3908:14d with SMTP id l13-20020a170903244d00b001bc3908014dmr9847214pls.2.1695813264907; Wed, 27 Sep 2023 04:14:24 -0700 (PDT) Received: from dw-tp ([49.207.223.191]) by smtp.gmail.com with ESMTPSA id jk21-20020a170903331500b001b9be3b94d3sm7547060plb.140.2023.09.27.04.14.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 04:14:24 -0700 (PDT) Date: Wed, 27 Sep 2023 16:44:20 +0530 Message-Id: <87lecrg96b.fsf@doe.com> From: Ritesh Harjani (IBM) To: Kemeng Shi , tytso@mit.edu, adilger.kernel@dilger.ca Cc: ojaswin@linux.ibm.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 07/12] ext4: call ext4_mb_mark_context in ext4_mb_clear_bb In-Reply-To: <20230919201532.310085-8-shikemeng@huaweicloud.com> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 27 Sep 2023 04:14:38 -0700 (PDT) Kemeng Shi writes: > Call ext4_mb_mark_context in ext4_mb_clear_bb to remove repeat code. > > Signed-off-by: Kemeng Shi > --- > fs/ext4/mballoc.c | 69 +++++++---------------------------------------- > 1 file changed, 10 insertions(+), 59 deletions(-) Looks good to me. Please feel free to add - Reviewed-by: Ritesh Harjani (IBM)