Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <c0d93be1-4343-b48f-3474-cd1f2f5cfe9a@amlogic.com>
Date:   Wed, 27 Sep 2023 13:59:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH V2 2/2] arm64: dts: Add watchdog node for Amlogic C3 SoCs
To:     Conor Dooley <conor@kernel.org>
Cc:     wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        neil.armstrong@linaro.org, khilman@baylibre.com,
        jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
        linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230926055512.2355390-1-huqiang.qin@amlogic.com>
 <20230926055512.2355390-3-huqiang.qin@amlogic.com>
 <20230926-output-musket-a43dd5abd0b5@spud>
Content-Language: en-US
From:   Huqiang Qin <huqiang.qin@amlogic.com>
In-Reply-To: <20230926-output-musket-a43dd5abd0b5@spud>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEkrYlJ5VWRqVGk3SHM2M2ZIdXJzeXloUlFPRTdxQ21UQ1FaWFZ0cklZT25B?=
 =?utf-8?B?c2F6SXp0VGFuZ01XUWhzUHFwNURhRStsU1p2bFFGRmE5aG1acXBpU1Z0MDJP?=
 =?utf-8?B?dVl4SzdOOUo1ZGF3Rm4wZFJweDFpak5vcVNYMXM1cUFkK1VidXh5dWkzR1pT?=
 =?utf-8?B?LzdVT3M2WDBMMzFONlRxQXhLUWFoQmxlVm9WeXlhbWNpYXA1QWpJOXpPQ1hW?=
 =?utf-8?B?VUdOMmYwQlhKWnR6MlA4SnZLaXR4UVcwS1JMUjZ2a1QvQnpjWW10SW45OERq?=
 =?utf-8?B?S0JZWHZHODF6MFlNeTFMc1J1NTh3d2dBUitRNkRnWi9iQlBIMEt4aG9HVXkr?=
 =?utf-8?B?UDZmWnBqSy9OcGpxZXVqNGpkaVNjRmpsK29FVjFFeCswUnBVNkhFVGxWSzZo?=
 =?utf-8?B?VHVNSExqYkZRSmY0VWp2aW9ZRTZvTFNEdERyWHBVR0kwSnRZQjFTRDdQdjUw?=
 =?utf-8?B?VzNSVjNwUW5teGdBL1Znd2NJYUtnMUdYV1NMeForTDFLS3hyYXZJZzJ0OVFW?=
 =?utf-8?B?SEczRUJTZGw2QWJzeS9NcHZYZDRvbDBuZFlNVUtRTVJka3JZUjFENyt4aUQ4?=
 =?utf-8?B?VFhML0Z5OEdWbE1yeDZieEhhRDRQLzRoam9WUkErcnM3WDNHakhMV3FWWmtQ?=
 =?utf-8?B?a0ZNQzFTcUdPbi9IdndmcGM1MGYrYURoV0hNVVdkOWwycUFjSGd5OXZsaTR5?=
 =?utf-8?B?RTlxWitBWVZKQTY1enJnV2w2TitzNDZzMHdSQk9uOUg4cWQxZWU2eUVMV1pt?=
 =?utf-8?B?dWh1SFUzYSt4K2JYOS9FckRFc3lzL1JLcDRIWDc5T1h2eFZoOXc0WEFRcWVo?=
 =?utf-8?B?WktRTGxpSy8ySFV3b05pOUIrQkkvbFlSTzBUdnkreExBV3NCSTlTNmp1SXEv?=
 =?utf-8?B?Vk85bW9mTEJRby80VFkxZ1dEa3lZMlJXMm1tcURXUmlZMFYzYlBzTVl5bGxj?=
 =?utf-8?B?WFNkd2Vpc2YxV2hiNUJmYnBFL2lxRGNFUTdOMVVPMjArRE9TbDZjd1FnYWZs?=
 =?utf-8?B?b3RFVkpIVE9GSlgrR1B0b0dNV2pwS2xvVnR2MlpGUUpBM1VZVVVUemZzd3pX?=
 =?utf-8?B?NFdDVmxBQ1BPamh2SmZrS3k1YnFjS0R1TjR2dVcxV3FFbHZSMUt2NFdwemFS?=
 =?utf-8?B?bU12S0U2Q3lYSHBUQUhNcXJRU3BJMzczL2daSTA3NmtOOFF1cDJRYnprTDhN?=
 =?utf-8?B?WER6UEN2T2ZtSTIvMEp5cnNQNmNLbnJHS3Q2SGhXUmJWMCthekJ4c1RGSUs3?=
 =?utf-8?B?U09yODBoUlBXS3h2NkxpcUduaURZc3JMaHpNS2tpU3ZZOHlTT0NuOFk3eXd2?=
 =?utf-8?B?bGNXMk9xd3h0MWF1emZZSlF2TjN6TjhEN08ySzdyamVEcTJ2MENCdGduK01L?=
 =?utf-8?B?QnhiRGZOazVKL09VdzZEdittQVVhR05GSmNFVWVubnlMSE5iaG56RW1SRW50?=
 =?utf-8?B?cXZTb0w2OSt6TGFzMkp4N09KVmdvM1VJUzUxMXFFaGNDc3Z5MFRTWktvY3Ja?=
 =?utf-8?B?b0R1RjlVMkdHRG85STdvck96dnJydW83Vnp0YWFGVzk4M1l4QWhBYi8rVjJP?=
 =?utf-8?B?RWFpWjNOMHdQamFQdldzZGhzelJrVUo4Y1JsSndkNXQ1L3VwNWprTW9OaFZQ?=
 =?utf-8?B?S0ZTd2NacklkUHRDeVlUbTRZWU41VURtM3VOc3ZrVnpmUmhJbXpWbXZyTTcx?=
 =?utf-8?B?bUVMc3BVTXg1R2tsMzNTWGQ0ZkQ0UjBpZUhEd3JSblA3QkJpZE1jdkZhRG10?=
 =?utf-8?B?eDNIVWdabFVBNGNDYkJ2a2pmQ0s3WEVrR0V3K25rbElxblNvbFYrbTl5MXRT?=
 =?utf-8?B?Q0pQakcxOFYzVGZXNXFBZXRTOFpBak9SWGFzcVZKNm9BV0E1YVB6YUVpOURX?=
 =?utf-8?B?YkplQjZXMEtHcU8xams0N0V0dlhYUXNFWDlKSTh3YlJ0YktZYUV6RWRiOXEr?=
 =?utf-8?B?YkhxVTZHdHo2KzUzVnJuK1VHUk1IcWFHcitLelVBZ0p5UDJzaUxWS2FseXFO?=
 =?utf-8?B?b3E0WFI5U2hHY05GVzVXamZkK3VIdWd3UG44ZEt4cUpZdE02TGorWFBEd1ph?=
 =?utf-8?B?alpVeExocm9Kem9udkl3VENuSDhoOC9NTHE3UXJRSlFlMFViM2trR2J0ejNs?=
 =?utf-8?B?M3BJOG1NcWZYM2NVNEZoWk1FNENTdVhKN3ZMZzZTSWtMMXl3M1Ewa0w1WG9W?=
 =?utf-8?B?MEE9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81ec15e8-b558-4301-b9df-08dbbf1eeb90
X-MS-Exchange-CrossTenant-AuthSource: SEZPR03MB7220.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 05:59:32.7329
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4lsHkssNyFcc3DqmNIBHqscVh6L35wYcmsqh29G95S0Ej+WiWFFZ6iTMrAdbpwCjbNEBfMEUtw2n3H03UWu9zQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR03MB6637
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 26 Sep 2023 23:01:02 -0700 (PDT)


On 2023/9/26 16:03, Conor Dooley wrote:
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>> @@ -81,6 +81,12 @@ apb4: bus@fe000000 {
>>  			#size-cells = <2>;
>>  			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
>>  
>> +			watchdog@2100 {
>> +				compatible = "amlogic,c3-wdt", "amlogic,t7-wdt";
> Does this pass dtbs_check?
> The binding patch doesn't seem to permit this combo..
> 

Ah... I ran dtbs_check again, and there is indeed
`watchdog@2100: compatible: ['amlogic,c3-wdt', 'amlogic,t7-wdt'] is too long`
in the output.

I'll correct it in the next version, thanks for pointing it out.


Best regards,
Huqiang Qin