Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <fd40809d-bb6a-dfc6-6619-eb467a68c9bf@amd.com>
Date:   Wed, 27 Sep 2023 21:55:57 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/1] drm/amdkfd: Fix unaligned doorbell absolute offset
 for gfx8
Content-Language: en-US
To:     Arvind Yadav <Arvind.Yadav@amd.com>, Christian.Koenig@amd.com,
        alexander.deucher@amd.com, shashank.sharma@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        Felix.Kuehling@amd.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230927161616.3335-1-Arvind.Yadav@amd.com>
 <20230927161616.3335-2-Arvind.Yadav@amd.com>
From:   "Yadav, Arvind" <arvyadav@amd.com>
In-Reply-To: <20230927161616.3335-2-Arvind.Yadav@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnBIWkRUVDJMVnVNdXlvTVlxLzgrYVhwTm5Cb1MrU2tQeXFKRnBWZHdtM2Rm?=
 =?utf-8?B?Z2x5ek53OWlQTmlxVG5oZDJhTjI5c3F4MHVhcUo3Z0pRbGQyUVBnQXdhQlll?=
 =?utf-8?B?V0JGT2JNWlNUMnBZNGdvK0Qra1pGY3lUTXdIbExkZnFkUzloU0c3NmhQaldJ?=
 =?utf-8?B?RDdzVE5HNENxTXhhMVoyVHBaNXZhNHFYUnBFQnBka2Vvdmp0bEhLQTRtQ3oz?=
 =?utf-8?B?RUtnS3EyTkxVZmgraWlNZWVoRWgwWjJHUkV5TklYemIyZEFONjhTYkhUSGhW?=
 =?utf-8?B?NWUwVVM1S2xqMy9lWXFMNVZZc1lnZk9TcUhLdkVoMnYrZnpsZGpKYjZXMzht?=
 =?utf-8?B?cEMxRDhYcmFQSmZIcE12cmFEdFFPcEUvK3ZabGhoVkVMYWx3RVdTWmZTdkhI?=
 =?utf-8?B?WVhDZE9YOTBkUm1RQXE2SWRGTUNiOER5dHQzL3J5UE80OVdGTkk3QnI0V1lX?=
 =?utf-8?B?cEFsOWIwQUNkUjRqcyt3eGVHZzRvY2MvdE1mQk1sbHdNOVZkanBhc3F4TEpu?=
 =?utf-8?B?Z1djZUlFRXB1L2NMRlJlRGpaOU0zNVExSU10bW5yME1oTklKUEw1Y3luSWJH?=
 =?utf-8?B?UE9iczNtbG14THdla09vbHpvYzdBWG1CNGo3SmJpbERiS3VoUGxrVW4yVitC?=
 =?utf-8?B?alMzVmlYL3Ira2E0OFdTNEpOQ0VxZlhpVnhZaWQ5TFVjVTNnMGJkQmlFUk4w?=
 =?utf-8?B?aWU4R0gzVjI4b2dNczU0dUdIYzZCbEFNRnlKZDY2d0dJTUhzb0xaN3NVY2xn?=
 =?utf-8?B?Ykh2eUFBL3J1UzRxQU9YVkFEaklidi9LOFlOUW1nMVNQVmJ1aXFwOVVNMjlC?=
 =?utf-8?B?cGJDOW9UTjl4YUxadGxQWkVscy9xZXppc1JqZXFtT3dDSStPM3AwVnI3dElo?=
 =?utf-8?B?Ui9ZUHJjTHI2ekFlTXd6dkd6ZGdpUktPeGQxeEJ4SkdUTURFTkNvU3dpRzZC?=
 =?utf-8?B?eVMyNWd2bVpMTHRRR3lzbUxBU3pMcWVqVlVGMVp2OVhCdTBzekQ4eTdyRHlT?=
 =?utf-8?B?dGhMKzR2dmF5MzlOcGtvay9RUUJ5MlRTVGlrS0RBQUo4NHJGMTB2aEVrTk1x?=
 =?utf-8?B?aG1rbUg2Mm44WXZCSU9WVXAwdDdnbm1wSnR0Ukt4ZVIxcSs3UmhiWnc0Q3hR?=
 =?utf-8?B?eGJMdXRmOXBodGZVeFBoTkJjM0lEMmZQSUNoamZTOXFPaGZQWEtWTkYyNkla?=
 =?utf-8?B?TlEydHFyVTVuVm1rUEZhZVU5UnBITDZJVU1sUmtXWWhtZkJzNUdBVUtXalBT?=
 =?utf-8?B?RnZ0RzNqZ2N6TTduT0JWdTVYT0VGOFRjdUg3djIzWHRreCs5OWNEQ3UvaGJB?=
 =?utf-8?B?VVBaQlg0UU9VTkd0dVRPZm05NGZhejEzb1lKMVVqREVUaXRPSUNsQjZOL296?=
 =?utf-8?B?bmJqNHZhL3VLamhoUkNRbzkwN0NibzhWa0p5azBnOXBWMVdPeUxwVGFmOUFI?=
 =?utf-8?B?WUhlcWV4T2l5ZnovMTNWRUc4TmJTWnZlMUNlV1N0YWxkdS8rVmVEOUVtMGcv?=
 =?utf-8?B?MTdURm5DbG9idHczQkJLR2IvMFg4eUxVZ0VvTVhRTytEUWVrNVNvSGpwU29P?=
 =?utf-8?B?ZnBMZmcwalVkazlIKzR3amI4VnVKbTFXcGlzWnFpVUxJN2RaWXptTXB6QW9Z?=
 =?utf-8?B?UjNYSGZCRjNpWHF0djQ4bkNycWNhbXE0ZDJoZ1pMUGVaNmhRODhvVEQ0RTBM?=
 =?utf-8?B?QjFSeGZ1dVRaQmNBMzVtV3hLU0JEZHZQU0h4WW5mYlNsdmpYYmdkSXFIN2ZI?=
 =?utf-8?B?L1A5T3RFQ29DZTNrNExwK1lOcTQ2QWpSS2ZCV1VNeGVFRUhJYmthSjhLMHI2?=
 =?utf-8?B?QUM3Rk5NL2NmbzZjRHVpMWp2clpOWXhWaVprT3pLeGdhSmUybFBwNnZ2WVBF?=
 =?utf-8?B?WlFnbklva241YzFuY1BhSjM3ODRWZWd3U2tseFhtQUNSVWV6MGRCR01hZVQy?=
 =?utf-8?B?MFBEUU9pc3VLWmxWc0VlQ2NKc0JrVGVQN2U0NVlXRE9pYjRocWhjNS9RMHV4?=
 =?utf-8?B?OUhLYng2blpzN2lidjk5L0o3QTFUeGVINXFxTUI4cS80aFRKYWNzMW8xMjkr?=
 =?utf-8?B?WXNSaVpEOFZWT00xblJ0cTh1cTNubUlOOUdXdDM1TDR6blZraWRhZFE3eEdl?=
 =?utf-8?Q?74SQUU2iaKEOb8IHFaF26LgYw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: debe37fe-314b-4b72-e02e-08dbbf767570
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6000.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 16:26:10.3592
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5Es78U/vQmSgGye+gsFIhq9pjpT+FSMVEyxNB3hfx5e+mOAnKKeIxPUKCMvDz0PxYQEI4r1+97AISOfZPiYKHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7457
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 27 Sep 2023 09:26:23 -0700 (PDT)

Adding Felix.Kuehling@amd.com for review.

Thanks
~Arvind

On 9/27/2023 9:46 PM, Arvind Yadav wrote:
> This patch is to adjust the absolute doorbell offset
> against the doorbell id considering the doorbell
> size of 32/64 bit.
>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Shashank Sharma <shashank.sharma@amd.com>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 0d3d538b64eb..c327f7f604d7 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -407,7 +407,16 @@ static int allocate_doorbell(struct qcm_process_device *qpd,
>   
>   	q->properties.doorbell_off = amdgpu_doorbell_index_on_bar(dev->adev,
>   								  qpd->proc_doorbells,
> -								  q->doorbell_id);
> +								  0);
> +
> +	/* Adjust the absolute doorbell offset against the doorbell id considering
> +	 * the doorbell size of 32/64 bit.
> +	 */
> +	if (!KFD_IS_SOC15(dev))
> +		q->properties.doorbell_off += q->doorbell_id;
> +	else
> +		q->properties.doorbell_off += q->doorbell_id * 2;
> +
>   	return 0;
>   }
>