Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
To:     Kees Cook <keescook@chromium.org>
Cc:     Bodo Stroesser <bostroesser@gmail.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: target: tcmu: Annotate struct tcmu_tmr with
 __counted_by
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq15y3v1vox.fsf@ca-mkp.ca.oracle.com>
References: <20230922175300.work.148-kees@kernel.org>
Date:   Wed, 27 Sep 2023 11:29:26 -0400
In-Reply-To: <20230922175300.work.148-kees@kernel.org> (Kees Cook's message of
        "Fri, 22 Sep 2023 10:53:01 -0700")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qJA3R9pCV7WBVsHwRyMF3J3xFWVSZih+pMP06bWsdPqPzHph+1brpp9jeWO1?=
 =?us-ascii?Q?mkvm9sSfDG9gYvtIJ9uTKrunTK8nCjpD1yxHM5I1UpIlHeaRcoADbryiorS+?=
 =?us-ascii?Q?w79K9bqaD2sscJ+jq18WySLLGYKsIvueoSOkBaVRWwYs5WLCNkKPDzcGkWJP?=
 =?us-ascii?Q?L2d4l0km/tLh9/PamkcYW1XjuvTNfqMD0lJ22cMOO5L4nN6FSSt+BkH807/L?=
 =?us-ascii?Q?4krApLf5qPmqNGdzxk/GibI+kcx9dsli46r2V/UtfAMaLg+yd10/snMoJxfI?=
 =?us-ascii?Q?P3vo8zw4CfGeXBtfn1+8Ew4lI/XGOAMPAyQqgsqmHLDFbfN1TJUZQqZAh+fq?=
 =?us-ascii?Q?ekJNXj1LIfzmwHjbk2LBQsnel8EiLZU6/88MN5GgYFrqc//TEwansvwvLdoh?=
 =?us-ascii?Q?ycvZoyO/hrhEWEFSsGtKRtjJigtk4StOrQloiIsNO9+IMiEhGygwtHk9Vfma?=
 =?us-ascii?Q?xUwSt6Fjo+kSkoYlJGTPM9UV3J6eFb2MlQpTxKO2YPjg98NqS5BzTOOOk2CF?=
 =?us-ascii?Q?Pl/7A46QZ0fTCHutZyQC0FD58O4Dghv6pN269K/c1XzDK5LAdPyqW75fS3mt?=
 =?us-ascii?Q?ndEyZsXX3b80WdjqESE8N7+mxIvRRlVniRjkhAYTcH4AvoW8SGsD1IRULpfF?=
 =?us-ascii?Q?4CRdcQaVFYWifSzc/6dRduecLm7H1PG9hW+kjqtbCck9IBMmPM6ikMYUFArF?=
 =?us-ascii?Q?OUl9WI/uPzl+qqJHrdV8WdUmuTIhTST2mlp3rvISlyfLj1UmPUke+42Qdn6R?=
 =?us-ascii?Q?xTbJPj5y9v8M9nxGXYS67qzUy0mXnSSVGm3XbUH3iruxDmbuFKjn8HAfANN5?=
 =?us-ascii?Q?//E3JS3gzGN8Q1+pp81FIWho8LedR2fxME3evDQPFy6kczOUfUPMrttb8uZS?=
 =?us-ascii?Q?WVhJ9Y/c+0YzLj+TzclV5gzZiEKXlYsnswUyvH22f01alQaG9LaJaXJgbozK?=
 =?us-ascii?Q?w2nip3kHXAKjwrugoPw0pj/cGu1wn8y8juJBCSV+Oh7DuhD/ygta+k6Zf35i?=
 =?us-ascii?Q?u0Lh93lfbcFA4CmG9hRHFvbD7x3KlGFLE7bKVi22TfriPlhTbLNOmBH79lO+?=
 =?us-ascii?Q?QoCBkkkqO4ZeNcHz2Cy7EURxz0PrmnYnUa4S0F8gH8D621nHqwRC71xipC3M?=
 =?us-ascii?Q?k0oKk5fN4SXxvhs5rD5XRv7bcQ+mCxgwh/DGcMxG5fJHwSBjVUT+YqhJ0qxQ?=
 =?us-ascii?Q?lsOw8K7Hz3yQsXgtBV841MNd+IxSC405D+hFAdpkH3g+C8a5WfjdJIAHpne8?=
 =?us-ascii?Q?JyTymEdHEXgnISg5HkZO5UVi92uor7hq3bt7o3NNKll7PR/JLAQQbrmn11r6?=
 =?us-ascii?Q?vSdt3uprDauh2P9xGYnkPwQ6lfLh9MtX2G/X9Y2C2W2YvAsMrqHHg5xB+1Li?=
 =?us-ascii?Q?mJ0IyeaeC3KJ+hmaWlA/NUpJfR/yGZ7SmfXYigCVGBr4Y9Ih3d98AssnYg4z?=
 =?us-ascii?Q?BFYa94xDGEIWBvOFGoG8CWrrWXoUIAHmykeKsghutd/78/o1Pj3p23fwA+JW?=
 =?us-ascii?Q?BYqAN13axRqrTyDwG+6Sks8cJY/Qoj8ufKx+nXjZpEA10Fh93GhthNyBhzR9?=
 =?us-ascii?Q?WS4lSerNajEF2qqiHUldZC33ibabw+qDtCy8fLu+v2BrTg0EqZdq6R3YMQZZ?=
 =?us-ascii?Q?1Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?dFzAMbh53vgO2gAuAiggLw15Ld4CM8BtOdnvDkYaFSaWGcQT84QhKTS2c35y?=
 =?us-ascii?Q?88Eya6UV9s3W5d9HRiIUdco3Rj3Gpt9TTgOowFUV8nFiqdAcqcwxLa3K53D7?=
 =?us-ascii?Q?L3ohBKVPbs1tIt+8/vxFFKTm/wBVxLY5Onpd4UEG2u8JcYPGCAQ4OIOcVAzW?=
 =?us-ascii?Q?/sz95gr9O/4RCFMK8tbrmHmT/LyTN4BnOqsu/xP3GSui4w22zHrJTMZeK7Gi?=
 =?us-ascii?Q?mGgMkjpRlvA/ky8UBZ+jWxlt3vWiIjYrHd1By85cUTMMFxtaxRy5F8z4SFNj?=
 =?us-ascii?Q?rcDJoC+jz1E8vKh5DgTfyXV3IX7CGhfQM2W82JwdqZocfolzt3hJZJV+lWbj?=
 =?us-ascii?Q?/+VGQCyWXVUn8VLzlHO03PxyLVORJNutubKsNqb+IgOeDt2bqZ8eyeKF/RvT?=
 =?us-ascii?Q?w84h6LQLAvaJkBQggB0m3VxyZadcC16ijbdAdEAdESxHKiuHUpmGJ2sQPhCX?=
 =?us-ascii?Q?/HZxxwCpvD6TPJvywjY/zGM0Iko6xUxc8t9eeRYYjYLhExv41pxZO9kLo0iz?=
 =?us-ascii?Q?QxYRWT7L+1cEsZxBzsgQgRyaeXgEBT1VMEjvbGe6U0G9zG9R3qZuScjZk4JX?=
 =?us-ascii?Q?f733dcYGSRMLcUQsNAkFeOl0ju4rqQGD/Xb+aIpnqbSNlQDDJtUIygNIRWxD?=
 =?us-ascii?Q?feRv85VJi6hFT0mGXlHMma4QkgIaa44XU0l4XsqWAbbzLL6A49SmIkd9mXL3?=
 =?us-ascii?Q?IFaYEgM5FbmlPaHRxdMB8m7e02RPqq5EZWQGkdg/ZrxqaYDGnTNjYKstovf0?=
 =?us-ascii?Q?eB3AMQqeA1tJzOsMrif4hFH70CXQRVioRJT6lsu69bV3lbRhkpbEyyDqYiO+?=
 =?us-ascii?Q?lilM+qOtrDz0Us0zVrM8McqwrHAIwVvxZKUtKJ/FijJOP7ut1E5RNboTzR/a?=
 =?us-ascii?Q?ynsXslF4iJaUzesyJ3puWgGGMCe0RRKdw5VKoHW2vFOprsDpk6Q07fj1ksup?=
 =?us-ascii?Q?SMO+zEY8UHekj8d/XJ9uhA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb3c16a5-9c32-416a-41e0-08dbbf6e8a6e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 15:29:29.4124
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V2Okdp+hbTYAJotxqYCKqjinahqceYlySVDlp4InPL3B87y6x2+5mSUJEN6qsW9JypF4EFfh7yqo5jE3/83LocK1zt9g5dLlbk+2rHHiGq0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7322
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-09-27_09,2023-09-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=691 bulkscore=0
 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2309180000 definitions=main-2309270131
X-Proofpoint-ORIG-GUID: phiokkigPzPwUW3rPKwJrVnipScr7Qvd
X-Proofpoint-GUID: phiokkigPzPwUW3rPKwJrVnipScr7Qvd
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 27 Sep 2023 08:30:10 -0700 (PDT)


Kees,

> Prepare for the coming implementation by GCC and Clang of the
> __counted_by attribute. Flexible array members annotated with
> __counted_by can have their accesses bounds-checked at run-time
> checking via CONFIG_UBSAN_BOUNDS (for array indexing) and
> CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).

Applied to 6.7/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering