Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <49c10592-5e95-30cf-7bfa-7105a16bc315@intel.com>
Date:   Wed, 27 Sep 2023 11:31:49 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v10 03/10] x86/resctrl: Rename rftype flags for
 consistency
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20230915224227.1336967-1-babu.moger@amd.com>
 <20230915224227.1336967-4-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230915224227.1336967-4-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkMwNGJWU3c2SStnY3owRjRLTzRCdThyQTVKR2cvSnRRSXpsM2ZQbW1POUlI?=
 =?utf-8?B?ajJwOEhpSWtPQ2ltTmkzY09KVGhweDhlam8xZHV6OTZqSnErSzNYTDZ4WXBz?=
 =?utf-8?B?TjJzS01rRGdzN1Ezc1IwTlNVS1o0UjAwNDd1by9UdGtLUm9KM2lxbi8ydW8r?=
 =?utf-8?B?emZoYW10dDdkc0NkS2pLb1M3eTVyNXR4R2g4ejZrc3gyNUtRdC9JWHo3d2dQ?=
 =?utf-8?B?OWNaZlpWYjlFd0xQbk9pclBsQ0dFMVBZNWxRMVpMcEtEc2Z6MC9KelNIRGFI?=
 =?utf-8?B?d3pwaEJMRUtLb1JvMlZFbWJFSmxQaFl4WlpCb2Y4bUxvMVZzdUpZa0NncnNF?=
 =?utf-8?B?OTI2dnA4ZTcxWGhtcUdTa0tjeHV5R3ZVOHd3QTZsN1FiUFFXT2tiYkNnZ2VR?=
 =?utf-8?B?RkxwVi8rb1hUdzUxWUVCQ0VWdTVLOVdiUnVJMG14dW9ZRCtwM3E3Zmtadkht?=
 =?utf-8?B?M2M0UjNLeDRSajRxNHRaVFcvUVhtVnJSRVd1NTA4dWpoaUJIUTdaMjNoNmdI?=
 =?utf-8?B?b3dHcklkZzJBTkhuNStzbTBhcTVvMkRtOEJ6bWY3cU9ITDIvUkFkaXk4VFpP?=
 =?utf-8?B?NDJBemJwcDdnR0R5bExWaUtMckNoQVRERTB1WjlWZWJwakptc1NYUk4rZTI5?=
 =?utf-8?B?dWViT1VidmUzQk1TK29IeldtM0lBT1d1dWJDcFpWbkpqSW9oQWQ2ZkdDQUZh?=
 =?utf-8?B?YlZhNk8zS1dxSVpIV1QzeE1aWWlidG5wZHFEYWxhaTdlOWgzUW0wRFVjOERG?=
 =?utf-8?B?TU1GK20rUmdrUDlyakgrT3hzWEN2RUJaOGFzSlFCNWtKbFh6dkNuRnFqSzhY?=
 =?utf-8?B?bnhaaVc5NitOZXd3Z01ya3BsaGNEb0JYZkNDMnZFRGxJM0ZybEo2MUxTTmlC?=
 =?utf-8?B?T2g5SFRHclRNVk0xUFhiMDluaklncXFxd1Vab09NanVyVWdsMnkrcUFCUFhI?=
 =?utf-8?B?SDRXZTNhSG5KUWFQZEU0c2tFWDdLUmZ4ZUlBSnhTTWxxTUhZdlBnTmFEUmhH?=
 =?utf-8?B?enFkUGZHY0hSb05UUUViUTF0cnR0enFsYlhxSGd0R0FxOTZyU0JYMU54cFFK?=
 =?utf-8?B?d2wwemFsMmJwL1ljZ1hnNHFjOFhKaDRsOFpVd0d3TzhGWlNvZ1V0VXc1Yldu?=
 =?utf-8?B?NWRWczlDYWM2T0VsUU5TM1ZubmxPSlBCNlN0dzI2aUdRTldranBVT0llanpF?=
 =?utf-8?B?YTFsbE5pUzB4NVJnM3EvaFR5Q3E3YXdzY3d2cHNDMjEybTNMRTNWeWE4VTBX?=
 =?utf-8?B?QTFlUzA2SkI2UEpOMG52NzJDMDB2N2gvRFUyMDdWNGR1MGtEUmtTby84RUFs?=
 =?utf-8?B?OTRqZXBEVS9raWRtNTlpU0gyOWpxZERncExJUEdBc2FVNGJ5UHFOQkNNSDVG?=
 =?utf-8?B?Ty9zUDBZZ0RzK21mRmlpK0NvK1dyL0VKa2ovazVrTTNYMUdXL1BrQmlNVk5n?=
 =?utf-8?B?eG9wZjFUZWpRVHo2ZWZuWm95T1pwaE01QkNIV3owaXlBWFZDV1c1OEVFNk1v?=
 =?utf-8?B?TkhpTDV4VzdRUTY3L1ZoQXVQNTNSWWpnbzZRMDdkczU0UDlpS3MyOTgrVWht?=
 =?utf-8?B?SUJ6ZzdmVytNbkRpYlJTcEtSZmtYdW5HQVhJaFV0TlJhdU1lMG1FRnJPdlN6?=
 =?utf-8?B?N1haWXdWYlYwZDNzbWtlWUNUN2IrRGxVS1VDd2JPKzR3OXdOTi8rM2lzOXJp?=
 =?utf-8?B?UUQxelA0eVZxRHFqOWFxYXJXZmJxNjZWcEhNR1ZPWUkzc1dweUowR2lKYXNp?=
 =?utf-8?B?MUFEcVJzYXVQZ28rTVBkNWFNVnE0NGdNdVRuOHlLUFNTZytKKzZZOFc0SmZC?=
 =?utf-8?B?OVFlTVh0cXh5NWlIN1VHM1F0elppZ1B0SFFtbEdwUm1BaGw1ZmZUY3M1VGFt?=
 =?utf-8?B?L1lmejhLY3Iwd29xTDgzN29FMjY0Qm40UjZlYlJjd05UZ2x5Y0ZqT2FmM3hn?=
 =?utf-8?B?emdOWldyN1ZsUDY3YkROUjJVZFZaVmh1ckdyTWt3Y2V1cllGNllHNDg0VDFL?=
 =?utf-8?B?OHU3MmpMdDU2b2ZwQkx0WVY4ZnFFTForQTJiaitDTnFicW5MdER3a2VyQVRP?=
 =?utf-8?B?cTF4VFQwM09EYm0rYnVKSVlKRDdRVVZZRXB4OXRlQTJpRG1uSitaeXFEdmdE?=
 =?utf-8?B?aGZzMGVZZmp1SmNSSTVmdkczSXdKYWNraEx5N3ZxdEE3c0FGV3dOUjlNdmRj?=
 =?utf-8?B?V1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f3e8ee1-e28f-4e3c-2bfc-08dbbf88056a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 18:31:53.2230
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k3amSk0dYU4zGr1XNfHZOpc6F/BJFYeXSjit1cT23IRQQbwo3f1Ymrdu89Rgl0jx1ebIylo0wd5LITwVYab4Niql9ZAV0sHAJvZDSpY/w1o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4927
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 27 Sep 2023 11:32:18 -0700 (PDT)

Hi Babu,

On 9/15/2023 3:42 PM, Babu Moger wrote:
> resctrl associates rftype flags with its files so that files can be chosen
> based on the resource, whether it is info or base, and if it is control
> or monitor type file. These flags use the RF_ as well as RFTYPE_ prefixes.
> 
> Change the prefix to RFTYPE_ for all these flags to be consistent.
> 
> Also add the flag RFTYPE_MON_BASE, which contains the files required for
> MON group only.

This appears to be appending an unexpected (because it introduces an unused flag)
change without motivation as an afterthought.

How about:
	Add RFTYPE_MON_BASE that will be used in a later patch. RFTYPE_MON_BASE
	complements existing RFTYPE_CTRL_BASE and represents files
	belonging to monitoring groups.

Feel free to improve.

> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---

The patch looks good. With the changelog cleared up:

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette