Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2822350rdh; Wed, 27 Sep 2023 13:57:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGclCBpn2vWEpPB0AuXQNqpj5lo9reVQByVRXlys8eqRs2SIyEEDUFtRyjVDs1vCJQgkhpI X-Received: by 2002:a81:548a:0:b0:5a1:635e:e68 with SMTP id i132-20020a81548a000000b005a1635e0e68mr3032540ywb.46.1695848270683; Wed, 27 Sep 2023 13:57:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695848270; cv=none; d=google.com; s=arc-20160816; b=lvnjU2ZwXqmUdFsEU51xvqMIEnjaN26CRL+GqCk8wQ1KvKWx440aqD7XBsCdmqaJ9q gBBpaYUUAgj5L0PuqEFsMvH1s32eWsQavKKpVmcW8QEausd8PS3UTlYIckNRBIShp9zK PX7G2QrLKs7ADWDyAaNQeI6MMTqUthdN1O0xLCl64ZIfnRqwvGsVLmdlInFd9vTaQk/W co3nDZR1c+bFTGx9WfEI5X+GqhTd8GYxvkSVrKuKWhMyEknGNsGEU23tKKn385YXnXto EEIESqK8mP5IyI5ewWf6NWUdWD4LJO/NQ+gLZn6y8D4m05L2CuVTgmxNJLaTv0JtIxPR gj2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5/Withjkp7BxI9AgxCuFLL2xAgHIN8igANqjSkzu3Q4=; fh=agG6rX2uji+4rYhMeJW0AYFU0kqs8bgZflhvxJQ/FhY=; b=hJt22SeGx61/Iry/dHYxsD5hirwdfWuxg9lS6qjTPZ4bnsxEFoDhutQ6EzwMDPr/20 GVmpjtqGCeooKWh5lLNT3W+rsCF6UINtmkvaZfBGppigISaDFjJ4ynEWccRzSi5hEvFR VEF9s/LJ2/FqVhjWw7/XwPCS/w42NcKVStWNsGUjd8EqzHQxs1NQ/OFFK660A5G6qHTS I5sUQWRDx3WDaxoDfLtsVdXuPIZZrjB3GQHAcuHRBpaCjBKvn/tB8I2EQz0zdXOoCakJ 96DUSbGN80OEJWonfzyUCbDyqFO8nZ7CmQgYEQ8VEKQ/Gw1wF5nOnVY0a1dBx8gOZhtT 7ryw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=jUlw4V3m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id g24-20020a633758000000b00573fbbf187dsi16924995pgn.216.2023.09.27.13.57.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 13:57:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=jUlw4V3m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id B15FC8242989; Wed, 27 Sep 2023 12:35:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229772AbjI0Tea (ORCPT + 99 others); Wed, 27 Sep 2023 15:34:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229595AbjI0Te0 (ORCPT ); Wed, 27 Sep 2023 15:34:26 -0400 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEB351B2; Wed, 27 Sep 2023 12:34:19 -0700 (PDT) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38RIx6RT007876; Wed, 27 Sep 2023 19:34:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-03-30; bh=5/Withjkp7BxI9AgxCuFLL2xAgHIN8igANqjSkzu3Q4=; b=jUlw4V3mup3Csoqfqd8xQpMCoGbhvcsd8QlLpf6GQBiA5FUNGzMp8+ksstEksKGHtkxc 4VFEGI7m/LOg8cboVqYZJ+02SroYSWz4gAeEH2XEX4hkCU/nTRZZooPqkh4G58naVTWB K5R7qE3eWBtDPsfkjr7zJI8vUvrxLm/DTbUvJ4u81nuGLZMAICvuIHS90sYCUXmtOiSJ hJGMHvnkkiKoa4dexQsgMwR1i01ceQKclHdBp0ufnUO6Jr0JkS+TZdyzN5YZO76GUso+ mbz6NqDiCKsq1hc4CLaeZww59debUUaQwTPh+arQ8aXlY2GVSHcSOOwwMW2LzZYlHxpY cQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3t9rjujf30-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Sep 2023 19:34:10 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 38RI0MGv030591; Wed, 27 Sep 2023 19:34:10 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3t9pf8cueh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Sep 2023 19:34:10 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 38RJY90l008431; Wed, 27 Sep 2023 19:34:09 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3t9pf8cub4-1; Wed, 27 Sep 2023 19:34:08 +0000 From: "Martin K. Petersen" To: Dinghao Liu Cc: "Martin K . Petersen" , linux-scsi@vger.kernel.org, Steffen Maier , Benjamin Block , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Christof Schmitt , James Bottomley , Swen Schillig , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v3] scsi: zfcp: Fix a double put in zfcp_port_enqueue Date: Wed, 27 Sep 2023 15:34:00 -0400 Message-Id: <169584315413.1272983.1280092821984155852.b4-ty@oracle.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230923103723.10320-1-dinghao.liu@zju.edu.cn> References: <20230923103723.10320-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-27_12,2023-09-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 mlxscore=0 malwarescore=0 mlxlogscore=956 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309270166 X-Proofpoint-ORIG-GUID: v71FJI6HIYe9Cxeax3MQtVJ-uf3-PIqe X-Proofpoint-GUID: v71FJI6HIYe9Cxeax3MQtVJ-uf3-PIqe X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 27 Sep 2023 12:35:09 -0700 (PDT) On Sat, 23 Sep 2023 18:37:23 +0800, Dinghao Liu wrote: > When device_register() fails, zfcp_port_release() will be called > after put_device(). As a result, zfcp_ccw_adapter_put() will be > called twice: one in zfcp_port_release() and one in the error path > after device_register(). So the reference on the adapter object is > doubly put, which may lead to a premature free. Fix this by adjusting > the error tag after device_register(). > > [...] Applied to 6.6/scsi-fixes, thanks! [1/1] scsi: zfcp: Fix a double put in zfcp_port_enqueue https://git.kernel.org/mkp/scsi/c/b481f644d917 -- Martin K. Petersen Oracle Linux Engineering