Date: Mon, 12 Nov 2007 17:11:56 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
       "Rafael J. Wysocki" <rjw@sisk.pl>, LKML <linux-kernel@vger.kernel.org>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       "Thomas Lindroth" <thomas.lindroth@gmail.com>
Subject: Re: 2.6.24-rc2: Reported regressions from 2.6.23 (updated)
Message-Id: <20071112171156.da6352bd.akpm@linux-foundation.org>
In-Reply-To: <20071111224643.312f8279@the-village.bc.nu>
References: <200711112058.28043.rjw@sisk.pl>
	<20071111200935.1384c24d@the-village.bc.nu>
	<200711112322.15537.bzolnier@gmail.com>
	<20071111224643.312f8279@the-village.bc.nu>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1122
Lines: 28

On Sun, 11 Nov 2007 22:46:43 +0000 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> > [PATCH] pata_amd/pata_via: de-couple programming of PIO/MWDMA and UDMA timings
> > 
> > * Don't program UDMA timings when programming PIO or MWDMA modes.
> > 
> >   This has also a nice side-effect of fixing regression added by commit
> >   681c80b5d96076f447e8101ac4325c82d8dce508 ("libata: correct handling of
> >   SRST reset sequences") (->set_piomode method for PIO0 is called before
> >   ->cable_detect method which checks UDMA timings to get the cable type).
> 
> I'm not sure this helps as if the ACPI _GTF method is looking at the
> flags and stuff but it has to be worth a try.
> 
> 
> Works for me as a 2.6.24 band aid

I'm looking at that "Untested, please don't merge until it is confirmed to
fix the problem." comment..

Thomas, can you please give it a try, let us know?

Thanks
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/