Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
To:     Douglas Gilbert <dgilbert@interlog.com>
Cc:     Wenchao Hao <haowenchao2@huawei.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        <open-iscsi@googlegroups.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <louhongxiang@huawei.com>
Subject: Re: [PATCH v5 00/10] scsi:scsi_debug: Add error injection for
 single device
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1ttrfzkz5.fsf@ca-mkp.ca.oracle.com>
References: <20230922092906.2645265-1-haowenchao2@huawei.com>
Date:   Wed, 27 Sep 2023 11:38:08 -0400
In-Reply-To: <20230922092906.2645265-1-haowenchao2@huawei.com> (Wenchao Hao's
        message of "Fri, 22 Sep 2023 17:28:56 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y7svNWbei4AjmKVYkGtWZjBdv7AL67kBurmWOeC7ARCe/9C7VibjH4YkYlHc?=
 =?us-ascii?Q?5Yc1UBeWC6tFPjHCwvYoxq0u4L5JJXDRxte/L118p+Aga3G7V1Wdb6eYQp4m?=
 =?us-ascii?Q?2Zl42eZzwJaNnogebEte1C98V22mgdU1QbDzPQRpzD0EU3JiRfsO7Oe6Wy23?=
 =?us-ascii?Q?3L4hW8aUatAONKozTOA0uQ3551zroZZEws+jr1cbl88sIjioKIAT/BDjf1yQ?=
 =?us-ascii?Q?4zVKaZSsMEdQdHbXEpa+sL3W4rkbzCjQRFngA8c+lzuLyRFUTc0DFaPDfu50?=
 =?us-ascii?Q?c5HluhPX3MIyFR6W7jSEPF9uKSTjsjjeD5ChbQ0tUdotNkUQmlJIVARQkGXT?=
 =?us-ascii?Q?Q6sjdUM40LJl6lovCQ85r8jQx6VNnSQFff5AhdZyxXmzFzDTTafvdCI8RKLT?=
 =?us-ascii?Q?CJAYJz8Gff9+WUrIaZlUpEfZOOgKpqVyALfDpaD/jtIFcOWX/k7U/DfghmPy?=
 =?us-ascii?Q?Q02vwZidkjgcUmWKtRIPaP8JJfQUUkaAqo8k+ugbG2J4vWcpAMWNhNIJre3+?=
 =?us-ascii?Q?TNLE57pP3YgmUvwizTwnqojUflgOsr3Smf3WPppQYPu8zm+UyNkJbi05VZ8F?=
 =?us-ascii?Q?+wWT24G/86eCVRUn9ZkYPr6Gx8ImyN5wrQy8XQwX6kgqvs/sbTt8FfqiQtqe?=
 =?us-ascii?Q?mlfhQQCn7rgU0jzZGAs737/+eGSLLNGD6obKvXjoU+ahmceFfLI3YsjuA9No?=
 =?us-ascii?Q?g6I9UiYQUjPvEiDjRNx+Oy8kIvnszpc7/LUPiR5Phdqk4DLbC0skI6zMaFLM?=
 =?us-ascii?Q?YzSOMreespWBVfuS24TondbWpsKDwxt64jyb3c3Akd5bRQ8+cdayJXixq7+m?=
 =?us-ascii?Q?Agim9eT2cfcG94leNPv01P77ahghbw/9lZIRFaRwn9m9niT1mymDW89km+/7?=
 =?us-ascii?Q?NepAv9GvIcBua5p/ta5cb9doW/eQzeRqh4+kuPucd4iRBtLcs4ukiMkSFWv7?=
 =?us-ascii?Q?tPp147kgqPYD6+8Gp8bD2WAcmuaWM8fZpqaUgX9YF827SNRlQcd/nBU16bHs?=
 =?us-ascii?Q?jSy/w1uiDq6O0gUf3MSSC/Ao1YVOdXIPKR2Ntt1a0cwrp+sH7n8sJPKb8gLa?=
 =?us-ascii?Q?4oRqc62MmmzzCbS0Lz+Ls2vVzOQ3usLXN3sYUgjbXLoIlVTQd8EYVRPJw6SA?=
 =?us-ascii?Q?7Ty0JxWIFgbManl+8mEGM/C2pT2YsiR9VMUHKLjUBpW+Mhlrq7eCePZjPSen?=
 =?us-ascii?Q?yAt7AK2WJUGZUFaYo3ohyBlq27fzbkVf1e3bpUS9E69GC7Sz/Hi5xPCkL5n0?=
 =?us-ascii?Q?ykhS8t4HXFA8UWpFlen1tyruDpxKdFG4VP99ElwAQz26MD847Bhh2NU8thHv?=
 =?us-ascii?Q?EPMxEMYPlny62bl5wYFou/AVuXEglv8VrE1opv8ajUph7VI0Q2vWG5HA5h2V?=
 =?us-ascii?Q?0NGItpqCy8ZRp2NqULvvgbgPiqiW2hau8ep8bt4AHS9RXMfbuhJYQYpvMIZC?=
 =?us-ascii?Q?J+6I3MGikFrX+3yVa7fiRjWUICKHHgYymHDbraMue4+IXrEoKYz3p3Y0nF9M?=
 =?us-ascii?Q?C7hSUQw+k9P7GL6j63dZbIsbuU0r8nZG4N9zR+m5BDiof44laVFNN9lRbfYx?=
 =?us-ascii?Q?/pBnRqwj/5MsPCFonaT7SpvA0kM74JLYOPlMy2lAmrvukgobxxkXo5Jx9Yqw?=
 =?us-ascii?Q?gA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2XVGZXrIuzZaQDyFN2yDmPe0KL5d2DER5ceBNjPpYp+8kG57RCTf9xIWmeOtdG2lQGDwEV//cfnVhX7P02ledyZvatEkJPTLJO6GF40IXYDOYcNfGydygk5QCkV3v2rAS3/BnaXb96AM9HKiIJofHBpUkL3wj6BfEQwe86uPpiWoRfpc8GKaFzdKEOJGGkBTeyaYpL6//lR0VpweGEEYMwX0ABzW0ZSl5NAWjbU+Ic9XlnYNoWOAkkaQBFJMkRdO4Pkk3dhrWeGzkBvQ7eYa8JuzFgyS9SwdLkKBq5N91xZVov0flugvkMzWj33jzTK03h/sqsiO/IpkiomMC6XY1FLn9nzWY2AXwdMYeCvaqobSFu/pKkiGiRm4oocL9mavQjQHXU0anneOI2FGs5M8v3YOvHVyVJIw/M3NNGhYMfZ0G90l7E6A+nGQaZCioPYqDAzQwlW3z/IPcpeYrnaNaNeGXyZ0Px7pXsfCTyuSbyi61bvC5nSLmhz1x6LTNsfcoEBd2kZGefKuj/69zmqsb5TxamottC572bxLvqT3Jbe2piVMiEiQsHl6lqpeDkt9eVUVCkEeNHPZASGdJYN/+3AxiqPb5zZEOXmr04xn4tOLU4QFF87DOLvs+lfgW9FSUd+iIHTp1doByxiuvIveyFGNqvGBViLai6bDK679GTjD02bVtCsrcUEicjXUI0T9VtIrS8ddG0BBHHfjO/40WyQNqQlRVjX5hwKtLZ2rA5Ry7irvmjLntfM9sW9AqG+vdclOwoWARIgBRs2kpaWDYiw0gUNtBTGf3G37yXk/fK+RkuSiQSZlbc6zebGhACrovJv9RTufuZzy4pQRDUQ9ohfJ8rnRRonVWoAZuZm762BNLn3Mxa8vzoQojU5d154L34ajs/yigQpI3IEWjXALTQ==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 244d9ff5-73de-42ed-0aed-08dbbf6fca21
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 15:38:25.7681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7PAU3ECQhUUdS5J8a3cvRgz4hJSOr0MnMw467NCaQmxcZPtM1lnRGCSd7+C2hmM6cGXfZuX2oWFZ/GTGfNiDnuVDqSyQZH79fK8ybUlmX6Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7347
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-09-27_10,2023-09-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 mlxscore=0
 spamscore=0 mlxlogscore=899 bulkscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2309270133
X-Proofpoint-GUID: nJTObV3WQU8LXk4Bic0V9BdhUiNHUWVk
X-Proofpoint-ORIG-GUID: nJTObV3WQU8LXk4Bic0V9BdhUiNHUWVk
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 27 Sep 2023 08:51:45 -0700 (PDT)


Doug,

> The original error injection mechanism was based on scsi_host which
> could not inject fault for a single SCSI device.
>
> This patchset provides the ability to inject errors for a single SCSI
> device. Now we supports inject timeout errors, queuecommand errors,
> and hostbyte, driverbyte, statusbyte, and sense data for specific SCSI
> Command. Two new error injection is defined to make abort command or
> reset LUN failed.

Please review patches 7 through 10. Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering