Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <8d16c0fa-a328-4985-378e-05c7486c0aa5@intel.com>
Date:   Wed, 27 Sep 2023 11:32:10 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v10 08/10] x86/resctrl: Display CLOSID for resource group
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20230915224227.1336967-1-babu.moger@amd.com>
 <20230915224227.1336967-9-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230915224227.1336967-9-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2Nxbm0yWTNqVzcyazZ0aVVyNmRTdUdiVDdDb1d1eU4rKy9Ma3JRZTQvNXdW?=
 =?utf-8?B?WWluVHlXZG9SdjNlaG5kM2NCTkMvUkhTS0Fwd2taOU9KR3kvQWQwd1RDdVds?=
 =?utf-8?B?bFk3aExML1pmSXZJcVo2T1cxRjBXYTFrRWgxOHR4L3M2bXhpMkd0d2M3L2kr?=
 =?utf-8?B?amY4d1FzTTlwQWxMZ0tPN3cyd3FSNHhXaE1VNUZtdjZrOFF3RHlUdlJJczdL?=
 =?utf-8?B?TSs0eHZDbERBMXNXVXRnTkRTMkFWbXRwM0RLT2Q0QktLajdDZWZMWWVyTzFB?=
 =?utf-8?B?R3MrT1RhL0JGTHRDYWw5RUNxblhtWUJrY2F6dmd3eTNJQWdvYUQ2bVNFVGRt?=
 =?utf-8?B?cE5pLzlQUElqS0R2V2trZEpHVVF6anMxZHdSdDVMdldwdXl2VXY0dGxEcEN4?=
 =?utf-8?B?cmwrYVM3Wk81U3lWclYwQUlLa0RNQnJrbWhOZ2xCem1uaFhpSkltYjBWOE9O?=
 =?utf-8?B?VXJraDhPQkUvY3MvYitqbjg4MVlFcm5sWDBzQmFwbGNEQVBQc0NTck1ZSThL?=
 =?utf-8?B?T2dZTkV4c0VUUFRjTUtaLzRkbDFzYWZsYXRVcmtkNGtJODA3djlRRFRoTXVk?=
 =?utf-8?B?a0hHUXVrbFQ0elZRZDQreDhaQlk1RDcvaGRuSXNnK2pvK2ZpNFIyTkV0b01n?=
 =?utf-8?B?WGFhNVpqQ2FYSlZiVXpnTWM1RWRUN3YvT2RPa3BqdFZxMXRNMWxCNC9mcHdN?=
 =?utf-8?B?L0ZWTmVmNXBLSTdieGpsMVRNNi9zMWlpaU54ZDYydytyc2UxNnhpWXIwL0JU?=
 =?utf-8?B?ZVFZd29XVU0wZ1BLNndJRFlwRmowQ2t0ZGhxZGVDTWF4QW9KekZnaklUbEJ1?=
 =?utf-8?B?M2FVNWNjb0R5bkVIMEtjakY4SXpEbGdVMW9wTVk5YUZtSnNSYlg0alpnNEJO?=
 =?utf-8?B?anEwS0JvWUpPMCtCKy9jQzRGM1VjaFpzcXdJTmdRUkVnZmxxUWJsTnhGMFh1?=
 =?utf-8?B?MXdVRGY0TnlSaWNMaFhjMVlrd21KL3Noa3lSbDRBcUdtLzZOOTFQWC95eXEv?=
 =?utf-8?B?c1FUa0xPRnFlV0xzR1NnTGROaENkc1FhVjMwdWhTbEI0YjJXL3BmR2lIbWpH?=
 =?utf-8?B?eHZweVB1Mk9lVGwwMFYycEREUW1QVm41b1lYRFJnRHVyQTVRWmh6S1N5b091?=
 =?utf-8?B?OHZJc083M08wR25zckhCRll4QjF5RFJTODNJY3J1TmN6aWdZZjNNWWtMMFpV?=
 =?utf-8?B?Z0YzWnlrdDhKdEdsSERXMTB3eXNlQmY2Znp0NlBtOVJiOVFRL2h2TjR4RDEv?=
 =?utf-8?B?UnY1K1BRZnQwbC81NVRmK3BQZEFBMUhFc1laSjJva1BEZ3dIcG5SSXVTSklG?=
 =?utf-8?B?QmR1eWFBczhLcERSb2FGeGFSc0F5RklaSkVvUE9XeVNsdW1nZlNIdG5tZXhq?=
 =?utf-8?B?U0ozZCtteHZFNmM3N3ZRY1FTOHBneDA3dDU0ZjdVWGM2bWJaVXZ0U3BqaDhw?=
 =?utf-8?B?ZTJ2OWU1dzlJcnhyUUVyOCtYaEFBNnBBdE5zbFRnZVVQYmNHTVVPN2g4TklL?=
 =?utf-8?B?dnhyUmszbFNLdnRmcGJLZEc1RmpOb1FRdEl2Rlh0ekZQd2FlN3BPelVwN2ZD?=
 =?utf-8?B?MmoyM09HRkJRb2hHczlrajJZZXVQMzFISUdxTGQwbUZ1S1VPOWtIOUJ4ZGNG?=
 =?utf-8?B?MUw0bER1d3lTay9ydVlSRGFSNlFqWHFhd056eWNNeVpxajZ5YzlyN3JsQlNL?=
 =?utf-8?B?VmRZQmJpSllZZVk1Z250VEJ1QXl4LzRJQTZBOEhESHM0TE1tV1k1Y2dMUFVD?=
 =?utf-8?B?SFJtYm1DZFZtZ3BJamJCWUJZM3kzYkdhanBYcHFsUnl4bWdqeHpKK2JGbG1m?=
 =?utf-8?B?bjZlSkNPcWtSRDhLa3R5bDlxc1RrbkRhYXJkZCtMdzYvbDh5ZGsxKzBoRklG?=
 =?utf-8?B?WGcwSXlLT2VTdlAvVHNqVHpHVlY3Q0NHaDR1djZEbnEzUTB6ZU9VVDAzbWpJ?=
 =?utf-8?B?dUtiQjJhTGFzUHMybUkzaG9NYXMvUGl6eC9MRFA0R3JGNDlUQ3B1eGNzMll1?=
 =?utf-8?B?QWgrZFpzK3lhVDJpTXlMQi9UcEJyVzFqZk1sRTNiampURjZwMlFWVUxQOG9j?=
 =?utf-8?B?WHZOMkJ3Y0lJTFcvVGpBTmFRVFVDZGp6ZWtCdEtKOWk1d3NHdFN0cXYyREt0?=
 =?utf-8?B?dTl4T3hlUTVEdEFQZEhjOHVzL3VKQTZwQ3JTYmFtM0JNaG41dWN4eGZRWVBv?=
 =?utf-8?B?OEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 10ccf7b3-a14f-4222-bf52-08dbbf881205
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 18:32:14.3396
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gUcIWxLDf0vZoFIZAAVjSzOXGoko0ZS4UT7O/vaYvDnXoqo3BkDGuLc2H0hWYXH8rCQHpasG5zvW/OzpBCqunDNZRBgL6FXrr7dnvbXHRU4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4927
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 27 Sep 2023 11:33:57 -0700 (PDT)

Hi Babu,

On 9/15/2023 3:42 PM, Babu Moger wrote:
> In x86, hardware uses CLOSID to identify a control group. When a user
> creates a control group this information is not visible to the user.
> It can help resctrl debugging.
> 
> Add CLOSID(ctrl_hw_id) to the control groups display in resctrl
> interface. Users can see this detail when resctrl is mounted with
> "-o debug" option.
> 
> Other architectures do not use "CLOSID". Use the names ctrl_hw_id
> to refer to "CLOSID" in an effort to keep the naming generic.
> 
> For example:
>  $cat /sys/fs/resctrl/ctrl_grp1/ctrl_hw_id
>  1
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette