Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2872430rdh; Wed, 27 Sep 2023 15:54:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBHfmUaCwAALFqJI0lxEI8lQnIb5v5rCuhbaZF6km2E/BHD3Ww9driZRI0mIMiiWJygs82 X-Received: by 2002:a17:907:2712:b0:9a2:1e03:1572 with SMTP id w18-20020a170907271200b009a21e031572mr2809312ejk.19.1695855293867; Wed, 27 Sep 2023 15:54:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695855293; cv=none; d=google.com; s=arc-20160816; b=RYZJrW1qUBI9q41dKY+/2gfffOgEFNLIslgLU8V+/clq/pkEEHR9+5Sdw5pJ+H8Tzm Qf/FYXii7bPSPKupQCDlvgHvz0zDdCnfZHLPM2fL7fVobmZ7UNDWXbG4Yes6t0NXS/Ww INqvFNUe2e3/mDQrm8cK2gaCYQgDJWzJYMlzMuGRmPJkGYBIEYdBJnILdKRfwKFBTxHO A50uFr4v2WDtik6uhefvTonShiKs/EPQozXKL+xMNIEVcehtTr5dxTnhdmsGj2XLT82L ILGxhz0hJV4TIT8MgqxQo8vdkZY65gmZ3ZwIVz+kD8+m1VP2eP5V9M4OMTJ01OKZZ5pW 3qPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Zg50glGvDdtglLFeZM0bVA5Rp7XkwmC5KIuofPJt15E=; fh=IcZh33b/OgNXaD/Q30Iq2ESKOAypns+wLFyW8VqaCNk=; b=Q/egIu/nWcKS1AmT0DOpgPIhKnaJERBLXhqEhGPT78aavMRDY9XYFMevGRqw/G/TCf x0DzaxANWsxlgRTLsMXjJungtbk9sBUxNZyAJZdTc0d0mN68SylpgS++0mYRBdvvYGJ8 3zls5V1n5S8GngvGLEvcgCrug5oh0bqQgRiK8RNl2lJwkA+c4JsBfdaOlXuwmYTh2mBH mmqIqpkbdMmcOoTeyv6vgT926lIFoI3/FOldemQUPupuK+0At5tgBxO2rlSVfwxU303Z 7nZnM//sWcYipiGYQP/aRwowp1W7PoWSHlI9HKpJRkKJE3UXrRXsza1++qp0O1ebX+Ju MC3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=lUZuSpIb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id s26-20020a170906c31a00b0099331401bdcsi15351789ejz.694.2023.09.27.15.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 15:54:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=lUZuSpIb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 3ABAE8060516; Wed, 27 Sep 2023 10:30:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229552AbjI0RaR (ORCPT + 99 others); Wed, 27 Sep 2023 13:30:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjI0RaQ (ORCPT ); Wed, 27 Sep 2023 13:30:16 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDEC4A1 for ; Wed, 27 Sep 2023 10:30:15 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D3FAC433C8; Wed, 27 Sep 2023 17:30:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695835815; bh=Zg50glGvDdtglLFeZM0bVA5Rp7XkwmC5KIuofPJt15E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lUZuSpIbYG7fm1DmDBwneBunRiwwnO9n1D97Mot1zBcW074CD3Q87G6K4PT4+IM5/ fFAso1btjJGuIqO5h0/Igolm70aJ45buEC5xNZW9JNUvGOstyFW+h5gZLnXhYJkae0 1QpdlQithxVcio0X7UpkSGZZ+okn1dzuXX2RGIfA= Date: Wed, 27 Sep 2023 10:30:14 -0700 From: Andrew Morton To: David Laight Cc: "linux-kernel@vger.kernel.org" , Linus Torvalds , 'Andy Shevchenko' , "'Matthew Wilcox (Oracle)'" , 'Christoph Hellwig' , "'Jason A. Donenfeld'" Subject: Re: [PATCH next v4 0/5] minmax: Relax type checks in min() and max(). Message-Id: <20230927103014.683e41b855cb2cd4ea163fa5@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 27 Sep 2023 10:30:34 -0700 (PDT) On Mon, 18 Sep 2023 08:14:40 +0000 David Laight wrote: > A quick grep shows 5734 min() and 4597 min_t(). > Having the casts on almost half of the calls shows that something > is clearly wrong. My preferred approach to fixing min() warnings is "the types are wrong". But often getting the types better is hard. Is there a plan afoot to go around existing code doing some min_t()->min() conversions?