Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Wed, 27 Sep 2023 22:44:22 +0800
From:   Philip Li <philip.li@intel.com>
To:     Christian Marangi <ansuelsmth@gmail.com>
CC:     kernel test robot <lkp@intel.com>, Andrew Lunn <andrew@lunn.ch>,
        <oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: drivers/leds/trigger/ledtrig-netdev.c:120:34: warning: array
 subscript 17 is above array bounds of 'char[16]'
Message-ID: <ZRQ/xt1FFJ5k0G8w@rli9-mobl>
References: <202309192035.GTJEEbem-lkp@intel.com>
 <6512163f.5d0a0220.e4212.8150@mx.google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6512163f.5d0a0220.e4212.8150@mx.google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mMESMwuawJDtXiikWwQyUFNzNl9KOQvti4RU/+HMgLj816ke9GKsXaNnQQTB?=
 =?us-ascii?Q?cdrgNmmY/JRahox80mPcKlU7d7jwuM1Qs/178oCl3rUdSMdd1QMDpieF9w1G?=
 =?us-ascii?Q?g8k+XIpOE1p6jAuPWK7YBEXE05Mju/udE3gmVeBG9igr9g77//fFWeNvPogJ?=
 =?us-ascii?Q?H+AczvjFhj7Tmth9JG5MGUuTQ1PySL08WyRQ0YM7QT95Q2tUpr1ZqNhpAj9n?=
 =?us-ascii?Q?PII1gQbTpfObtJsXhAP6mcWo7SrZL/LeCIxcXVGVlvGOzAqBioDPWvRHDFfu?=
 =?us-ascii?Q?6mjS04dtrYeOpfaElSCx1BG/eOhAUhUN9YpRoHSMaj1x0REniXojvheZEUPK?=
 =?us-ascii?Q?rN0St3CyQqNIvtRgX6kI7s8hqwkiao8Q5a9v7xKsCqOEgVevzLFxp/vW+4fM?=
 =?us-ascii?Q?rcoD4uaFrdGWHJe9JHzVj8bH2d2acamPTyFyEx4gqkez/UZpKJwSNnaXE0NH?=
 =?us-ascii?Q?fgnh7Xr/H8PqO/r3za5/fg8VANI3stqKpJ2kD+BffuzQehRA93ksQRdNOqCY?=
 =?us-ascii?Q?YmZsxmo9Lhg+zbJGgig7xrCk973OQqyHy6VZooLDW49wAShKSnz0rhUyqIBM?=
 =?us-ascii?Q?/6UVq8kIu4vlGEIwaN3Ifruz7Dgf7vZ9yF4JxulNGbSTxAn3jjTIGaQwzR3o?=
 =?us-ascii?Q?Q7Biq1R6eDMMP2M+4c7rJHWNvv0bl8u/qSUWxZgBeay4NTOXI/mxdMs1L1XC?=
 =?us-ascii?Q?0uxzq+pC6MVg8mbJER/TjXjxJzdV+vD7Q7Zl274r1vwyjhPvAiyLNtexrphE?=
 =?us-ascii?Q?2A5voYefob2dcF02pe3MFefMp2JcARe41yJNUdHRD8zcCbW6E2amGL3dp0yw?=
 =?us-ascii?Q?eTb3CW9R2iATdzYLTU9cLtXa0hUAljPSxhaaoQ5T6hUatr2FLmX58N02jSQ0?=
 =?us-ascii?Q?hHdQyadqaBR2qgEgcppOqHWp4mcFZc31ppsgJ002yuFVddL2NjmnXJmeXnjD?=
 =?us-ascii?Q?+YJAiBZH9vqCTzevv17LwofEPoFOqHG2RPrMiuW5LAuqX03YMruuTAI/RXk2?=
 =?us-ascii?Q?wIYgwNXmSXC2XnmJiBqOvq5y1UQ3mud1uv8WLOvi0zNaGlqNP1+igHGj+t03?=
 =?us-ascii?Q?UrT5XpvgzwewszxLeH3S/E/lwotkSVJkFaAK5TAGcPPMG42iUG3ASpfInQ6F?=
 =?us-ascii?Q?Xcxt0qGU0AtW7XkMVMGoVrTjcFosKC1xnSqdiw3+/VfU0RYavql9QTfupmCP?=
 =?us-ascii?Q?amYA7H+cnhUsG4xbroHUyD31RlXQQA7Z/RxFCuCeB3pNJ2qB4vUBtKdwp5x2?=
 =?us-ascii?Q?zZbp+ClBtH0LdBHAae3iTY+j+XNNTCYLsEv6EOFrC+/Ms78mHd0mXNQmySok?=
 =?us-ascii?Q?GAnPKRFMat0RXp+9YNs4wpYgQNPkL/g/Wnte9jYbiMj1rj5cFoAHFQeo1PWV?=
 =?us-ascii?Q?U/9dJwb6527s1TGkq2RUlTlUd1QZrTo35Ean01TCu1tKEO3k5mncZpJmR3Cl?=
 =?us-ascii?Q?I73dN93xf9DBXU7ssc8GIQQDfjRvXpL95WNW4rASRHZeAGd4G4+eXonVQIJ1?=
 =?us-ascii?Q?mZDwcjAxOtTCFD9tnlc94/mFGpmGif9DNFPrIMfsALfblbtBx0k/Jomlj20C?=
 =?us-ascii?Q?4MYtRXnvrnnTVUXoGZfS6vFFK9flvjg1swlEWXdB?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e7c55388-27d0-47a7-b3b8-08dbbf684411
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3006.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 14:44:34.6432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SsPGW9mgrU58fy3ze1Fu7p6tThr1AFwmiDOkXdikMu3pchYblg8+RvIwYkGzoq84eWfZRQ9zLv7XTFouaVnywg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6535
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 27 Sep 2023 07:45:03 -0700 (PDT)

On Tue, Sep 26, 2023 at 01:22:35AM +0200, Christian Marangi wrote:
> On Tue, Sep 19, 2023 at 08:21:03PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   2cf0f715623872823a72e451243bbf555d10d032
> > commit: 28a6a2ef18ad840a390d519840c303b03040961c leds: trigger: netdev: refactor code setting device name
> > date:   4 months ago
> > config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20230919/202309192035.GTJEEbem-lkp@intel.com/config)
> > compiler: loongarch64-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230919/202309192035.GTJEEbem-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202309192035.GTJEEbem-lkp@intel.com/
> > 
> > All warnings (new ones prefixed by >>):
> > 
> >    drivers/leds/trigger/ledtrig-netdev.c: In function 'set_device_name':
> > >> drivers/leds/trigger/ledtrig-netdev.c:120:34: warning: array subscript 17 is above array bounds of 'char[16]' [-Warray-bounds=]
> >      120 |         trigger_data->device_name[size] = 0;
> >          |         ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
> >    drivers/leds/trigger/ledtrig-netdev.c:48:14: note: while referencing 'device_name'
> >       48 |         char device_name[IFNAMSIZ];
> >          |              ^~~~~~~~~~~
> > >> drivers/leds/trigger/ledtrig-netdev.c:120:34: warning: array subscript 17 is above array bounds of 'char[16]' [-Warray-bounds=]
> >      120 |         trigger_data->device_name[size] = 0;
> >          |         ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
> >    drivers/leds/trigger/ledtrig-netdev.c:48:14: note: while referencing 'device_name'
> >       48 |         char device_name[IFNAMSIZ];
> >          |              ^~~~~~~~~~~
> > 
> > 
> > vim +120 drivers/leds/trigger/ledtrig-netdev.c
> > 
> > 06f502f57d0d77 Ben Whitten       2017-12-10  106  
> > 28a6a2ef18ad84 Andrew Lunn       2023-05-29  107  static int set_device_name(struct led_netdev_data *trigger_data,
> > 28a6a2ef18ad84 Andrew Lunn       2023-05-29  108  			   const char *name, size_t size)
> > 06f502f57d0d77 Ben Whitten       2017-12-10  109  {
> > 06f502f57d0d77 Ben Whitten       2017-12-10  110  	cancel_delayed_work_sync(&trigger_data->work);
> > 06f502f57d0d77 Ben Whitten       2017-12-10  111  
> > d1b9e1391ab2dc Christian Marangi 2023-04-19  112  	mutex_lock(&trigger_data->lock);
> > 06f502f57d0d77 Ben Whitten       2017-12-10  113  
> > 06f502f57d0d77 Ben Whitten       2017-12-10  114  	if (trigger_data->net_dev) {
> > 06f502f57d0d77 Ben Whitten       2017-12-10  115  		dev_put(trigger_data->net_dev);
> > 06f502f57d0d77 Ben Whitten       2017-12-10  116  		trigger_data->net_dev = NULL;
> > 06f502f57d0d77 Ben Whitten       2017-12-10  117  	}
> > 06f502f57d0d77 Ben Whitten       2017-12-10  118  
> > 28a6a2ef18ad84 Andrew Lunn       2023-05-29  119  	memcpy(trigger_data->device_name, name, size);
> > 909346433064b8 Rasmus Villemoes  2019-03-14 @120  	trigger_data->device_name[size] = 0;
> > 06f502f57d0d77 Ben Whitten       2017-12-10  121  	if (size > 0 && trigger_data->device_name[size - 1] == '\n')
> > 06f502f57d0d77 Ben Whitten       2017-12-10  122  		trigger_data->device_name[size - 1] = 0;
> > 06f502f57d0d77 Ben Whitten       2017-12-10  123  
> > 06f502f57d0d77 Ben Whitten       2017-12-10  124  	if (trigger_data->device_name[0] != 0)
> > 06f502f57d0d77 Ben Whitten       2017-12-10  125  		trigger_data->net_dev =
> > 06f502f57d0d77 Ben Whitten       2017-12-10  126  		    dev_get_by_name(&init_net, trigger_data->device_name);
> > 06f502f57d0d77 Ben Whitten       2017-12-10  127  
> > e2f24cb1b5daf9 Christian Marangi 2023-04-19  128  	trigger_data->carrier_link_up = false;
> > 06f502f57d0d77 Ben Whitten       2017-12-10  129  	if (trigger_data->net_dev != NULL)
> > e2f24cb1b5daf9 Christian Marangi 2023-04-19  130  		trigger_data->carrier_link_up = netif_carrier_ok(trigger_data->net_dev);
> > 06f502f57d0d77 Ben Whitten       2017-12-10  131  
> > 06f502f57d0d77 Ben Whitten       2017-12-10  132  	trigger_data->last_activity = 0;
> > 06f502f57d0d77 Ben Whitten       2017-12-10  133  
> > 06f502f57d0d77 Ben Whitten       2017-12-10  134  	set_baseline_state(trigger_data);
> > d1b9e1391ab2dc Christian Marangi 2023-04-19  135  	mutex_unlock(&trigger_data->lock);
> > 06f502f57d0d77 Ben Whitten       2017-12-10  136  
> > 28a6a2ef18ad84 Andrew Lunn       2023-05-29  137  	return 0;
> > 28a6a2ef18ad84 Andrew Lunn       2023-05-29  138  }
> > 28a6a2ef18ad84 Andrew Lunn       2023-05-29  139  
> > 
> > :::::: The code at line 120 was first introduced by commit
> > :::::: 909346433064b8d840dc82af26161926b8d37558 leds: trigger: netdev: use memcpy in device_name_store
> > 
> > :::::: TO: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > :::::: CC: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> > 
> > -- 
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> 
> Can't repro so I guess this was a false-positive that got fixed? (I used
> the repro commands and doesn't print any error)

Hi Ansuel, the issue requires to build with -Warray-bounds flag. We will fix
the reproduce steps in earliest time. Sorry for the inconvenience.

> 
> -- 
> 	Ansuel
>