Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <ec0a63fc-081a-a4bf-8ebf-d501b1d44cc0@intel.com>
Date:   Wed, 27 Sep 2023 15:16:18 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v4 0/2] selftests/resctrl: Bug fix and optimization
Content-Language: en-US
To:     Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        <shuah@kernel.org>, <fenghua.yu@intel.com>
CC:     <ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>
References: <cover.1695369120.git.maciej.wieczor-retman@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <cover.1695369120.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEpva0ZjV1VYbTdMdEN2anJSRERQWmg0Z09FNExBdEJvVlowdDNJZnROcDdG?=
 =?utf-8?B?OFJEY3BKM3AyS1dCNUIwakhoR092QmJzemFyYkU0L2EydU5rYjJtb3pIaEsz?=
 =?utf-8?B?dFQzektHbmx3elR2elZWTWZBeVBOK3YvQ0gwejIrQXdJWHFUN3hNSHE2VjJS?=
 =?utf-8?B?TS9hc3RNUmFaVEdkMVJId3hxYk05MG0zR0xRTmpEZk56alo0NVJ5MjFtUFlJ?=
 =?utf-8?B?WUJXWSszQ0N5eWVGMkhJVi9Bem8vakJaZTJSczlQZkRBSjltK2pDc3BuTWds?=
 =?utf-8?B?U2hwWERrcktsSm1kM0l6TG95cFNDRXdDYkJzZVRJTHl3VDN1TlZWU2xxU20v?=
 =?utf-8?B?SDRMd1JESElUc3dUelBhUlVmejE3dTRVRWhpNkpvTFVBZlgxZURWTlF4UVZX?=
 =?utf-8?B?TE5SRllmdGtLVXRiRTgvOVJtbUpVTUMwdkpHSjMvSGoxZDFoMlRCc0ZVdkJP?=
 =?utf-8?B?MXRSeFhEWXFUUG5lTENGQ0N0UC9oNUEwL214MjFjN0pwN0JtNDYwR3YwTlhn?=
 =?utf-8?B?eGVMQVU4d2hmOWU3YkNBM2xnSjFUT2p6d1ZLNnBjLzYxYmUrUkNKMGRHSjNW?=
 =?utf-8?B?cGlyRllkV1RWRWk5T1paSHRVQ25hSlRjcU9ycS81R24xUTMrN1RRSUwvd09W?=
 =?utf-8?B?WG1BczZQdXAyMXM5VW9kZk1IczVUUlFpaHArRDBNamtFMDlJRmFuWHZFRzEx?=
 =?utf-8?B?L0lUZXRCcE5hTTc0UVhNUU5CUU1WdHhSL21uZnRiOHVDM1NpOHpTK0tFM2pr?=
 =?utf-8?B?NDNPZjJrWlllNW5sQlVUZkRNVEJEa3pQRklFZk9icFFYOGZpQUI2a0ZsT1Rn?=
 =?utf-8?B?Zk1qSGxVL1lXUVQwUURsVVZSaVZpVkxUVmx1UWcrbG1rcDAvSmtkVTZoRnhB?=
 =?utf-8?B?MnJSa2xPOVovbUxxQ3pXUXRYcFdoQWVXT1hFc0RGQ2VIalJYL1NRUndTcGd4?=
 =?utf-8?B?Z3pUS1hXcDUrWUg4a1RqQ2hTNGlwUVlqTFMxWFJxbk5xWjFuaFREam1wNWJt?=
 =?utf-8?B?OWtQNC9tQXl5SDIyc28xVVhtMmRHMlpUQjdDWm9JSmszQnlycnZVdk96ZzdG?=
 =?utf-8?B?cUNBbys2eXJEeEF6SVZyTERVSDkySlhkUFJKelhicENZQXdNOEd1Sk5aS3VG?=
 =?utf-8?B?OTFmUk0xazlMSGJ1K2dHaHp4bjRyL0dlQzExb1YzZWtlUHJ6dCtmN0pYVy94?=
 =?utf-8?B?aFNNdm83cndhYXowRnZDMkpQZ0UrcWN2TjBpY3B0c3VDNVU2Q1cvLzZORk9x?=
 =?utf-8?B?RW9zK2xwY09NcTExWmYvMzFwTXU3RjFtWmg3RHI5YTA3UCtzUHJrK0VMb2Ux?=
 =?utf-8?B?bUhCcVRJN1lhazY5N25wU2hPRTNoSEVNMzFueU9jb0hZdEpCOHVnTVVOQ0Uy?=
 =?utf-8?B?QmdNRTNiK2tVb0k1UlhRbzN1Mk5KQmRFdnpVVUZncDBURWJ5YVJzMzRicXAv?=
 =?utf-8?B?cnd1RnNGVm1iRERsNXRhK0QvVTN0d1RnS0Uvby9xNDBON2lqQTMybFNSdlMy?=
 =?utf-8?B?dEJLNzc5aGlIYm9Lc2paYTYzbzZnN2psN1R5WDRXbDFYeFRqZ090eGhwMzF5?=
 =?utf-8?B?V1M4NE1LSys5eS9UaDVVc2xScDhKYVpLYVpNNU5aWlp6djRGNVhycjVLTXdR?=
 =?utf-8?B?eXlDVkNCYUMxc0hCY3lGcjlKYXhKSFJmNEU0dnZKeit3QmxTYnpGZmE1Qi9r?=
 =?utf-8?B?dytIc0hhQk9kMGNvcEM3d0lrU0hGWGdkei9TZW5teE96b1lnUW0ydW56SU83?=
 =?utf-8?B?OTZ3QWZjb0dlMVd1TTJ2c3hnQUJuREhHRzJmOStrRmtmcUpmWjdiUUtBK1NT?=
 =?utf-8?B?eXQ5Y1FVbmVCQzRZaXo5ZlR3aDNWY2NTYk5ZYmJ3L3FPR09DY2tERDhHRFRW?=
 =?utf-8?B?NExkUEhJVnRqMkZwdFVIOU5PbEgyeEVmZ0dzZnViNmhQSVRCZFZ1UEJuQnp6?=
 =?utf-8?B?bHdiU0Y3RUtRY0JHN29lRHJtWEp1WGRxNndYbXdIVG5yM2x5MU96b2xtdXJ3?=
 =?utf-8?B?RlRHRWRXVTRCUWhmamRRcGpLN0N1aCt0SVRmcldEc1pDWmYrZ09kdG1VdWdE?=
 =?utf-8?B?Um9XRjFycjAvZkxEbXFKWnpVcnptOFpVNW9USkFSd2hwaU9zbEJXM0puZ0ho?=
 =?utf-8?B?UGl3dkd0bWlyWSs2ZjF3S1RNKzVLMno2ZDF0YzJlSEptN2d6RFN1RVBaVWJX?=
 =?utf-8?B?cnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 69570406-763f-4c5c-d95e-08dbbfa7607e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 22:16:20.3627
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5l6k0bJBaGHh1boiGq129fLeIbb1LAQdzXR3MAYccLXPFK1MLXn0Oos9F5Rd6bywiPoyaOwX91g1YU3xl0VqsCsBHt3JZhVfAaFhiAhWyF4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8441
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 27 Sep 2023 15:17:26 -0700 (PDT)

Hi Maciej,

On 9/22/2023 1:09 AM, Maciej Wieczor-Retman wrote:
> The resctrlfs.c file defines functions that interact with the resctrl FS
> while resctrl_val.c file defines functions that perform measurements on
> the cache. Run_benchmark() fits logically into the second file before
> resctrl_val() function that uses it.

nitpick ... if there are comments in one patch of the series please consider
if it applies to other places in the series.

> 
> Move run_benchmark() from resctrlfs.c to resctrl_val.c and remove
> redundant part of the kernel-doc comment. Make run_benchmark() static
> and remove it from the header file.
> 
> Patch series is based on [1] which is based on [2] which are based on
> ksefltest next branch.

ksefltest -> kselftest

Reinette