Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2910231rdh; Wed, 27 Sep 2023 17:31:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzqy7QmjUSvd8vdFqk5+dq83oYE1kM/26urPg1ybnwHhhKG0uAPLLd4J6khm9rMaDKUblb X-Received: by 2002:a05:620a:3195:b0:773:db7b:26e6 with SMTP id bi21-20020a05620a319500b00773db7b26e6mr3209566qkb.52.1695861116995; Wed, 27 Sep 2023 17:31:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695861116; cv=none; d=google.com; s=arc-20160816; b=LzOk+wB80ollTbmtt/oO0pf27OGwDJPahoOFlnSDVW7EPpL9rMlF+mRx6TMTbgSmfq qvNarBbZhZggAs+x0j9V6MPcAmKRnAwVxxF7low0Bl4QCRlJfF28bXiwGDaqPWrtG5W6 gK0CuRSwA59RKU7WJGV7bjdP56JUQgAcIIuOsmvm2+C7IGB1JeRz567uujjBDs0wDOcv 9c691/f/gvZdo1It3SShgJghxjijgI26bkqyILJPt+lfJD/aNj09oREgJulJilG/eLbs w3TlWUZDUyCCkHTYmLb7T6rJeWugACV+E6pQadVgkZ8XcbRdJOc3Uf3pfAdne5y4ls2w 3wFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0TX0pYmxB88OVlFyckq/yed1Ptdee9WWy7e0AsIM+RE=; fh=e4T4tc6Yseqw0wNl8J+K5gTylUBL83nmpT0wjlTzYzs=; b=naqWh7dcGR+22Cw+B2dGBnzIUE+HvM/vKTAqyjbGj+qj8HnhD9NGv53FM28vRuF4Nq iZzdEAw/cYgkxqCplnqr4KRHGaH6LxwWaL71F8/yI1X/ICqU9KSNeLM6Be6a5qpTMpTP LUltakQ+ce/KXZh04LtBz5NMZWWEFXK80Veg0BdL951fWuLAOIm4UQMDHsPujcXzrG9m wjmF9F6ppRmh6gGjshVq7x0RKuKs6CqebSF445BhgsvBlGHLl5JVX0eTHM/ljwChO5oR OmVt3cQGBsdmBXRi9Bb7JjQVrjFrmjydZQOCu9d55OcKldZJWURmvzqCtQ3iPuHnHmtE t0UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="SqUbQX/p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id x23-20020a631717000000b005440b9f013csi17212999pgl.899.2023.09.27.17.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 17:31:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="SqUbQX/p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 7E4B980A8B85; Wed, 27 Sep 2023 17:31:16 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230061AbjI1AaP (ORCPT + 99 others); Wed, 27 Sep 2023 20:30:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbjI1AaH (ORCPT ); Wed, 27 Sep 2023 20:30:07 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6088F5; Wed, 27 Sep 2023 17:30:05 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 342DAC433CD; Thu, 28 Sep 2023 00:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695861005; bh=mADzmhR0WfSJpY+TxsIk5ESzAgjDkZcDjKss6S44Hgk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SqUbQX/pEf5mk2bFsl6aCkx3D9yqZt1sbYFdTYyw1TOzQJvAZ4Zc9T0eOQXyNHeVl QVoLTLI9a7fclQH9mFHFAHL0nG1veibwdALbc/5IAFBhUcZlniTOX1kobD118tkcBW jsNHn8WzvgiVqLDUrIh2wB7a6HRbTkliukUw/17GAiQ3c6RmSDSyp5M4XbiryMk5Ht lTRfjVq4SZ+EtCLqsQnxPJhw+JR5viunYAwUmqFfIHV2bS5BVYftKFa19iy0naY4nd Epe9yYG4UuVNz4ycC8OuXjopJSPURYrJ7IYbktJL31pdTlwEzZzMJWGLgqt6w1lfjk lQXWMBiUc6ROw== From: Bjorn Andersson To: Andy Gross , Konrad Dybcio , Elliot Berman , Kathiravan Thirumoorthy Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] firmware: qcom_scm: use 64-bit calling convention only when client is 64-bit Date: Wed, 27 Sep 2023 17:34:10 -0700 Message-ID: <169586125040.1226038.6973458146206642205.b4-ty@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230925-scm-v3-1-8790dff6a749@quicinc.com> References: <20230925-scm-v3-1-8790dff6a749@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 27 Sep 2023 17:31:16 -0700 (PDT) On Mon, 25 Sep 2023 13:59:22 +0530, Kathiravan Thirumoorthy wrote: > Per the "SMC calling convention specification", the 64-bit calling > convention can only be used when the client is 64-bit. Whereas the > 32-bit calling convention can be used by either a 32-bit or a 64-bit > client. > > Currently during SCM probe, irrespective of the client, 64-bit calling > convention is made, which is incorrect and may lead to the undefined > behaviour when the client is 32-bit. Let's fix it. > > [...] Applied, thanks! [1/1] firmware: qcom_scm: use 64-bit calling convention only when client is 64-bit commit: 3337a6fea25370d3d244ec6bb38c71ee86fcf837 Best regards, -- Bjorn Andersson